Permission changes (#29570)

* update permission mistakes

* add getAnalytics to TeamStatistics

* add PermissionGetAnalytics to ReadTeamStatistics

* add mocks for migrations

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

server/public/model/migration.go

@@ -51,4 +51,6 @@ const (
 	MigrationKeyAddManageJobAncillaryPermissions       = "add_manage_jobs_ancillary_permissions"
 	MigrationKeyAddUploadFilePermission                = "add_upload_file_permission"
 	RestrictAccessToChannelConversionToPublic          = "restrict_access_to_channel_conversion_to_public_permissions"
+	MigrationKeyFixReadAuditsPermission                = "fix_read_audits_permission"
+	MigrationRemoveGetAnalyticsPermission              = "remove_get_analytics_permission"
 )

server/public/model/role.go

@@ -70,7 +70,6 @@ func init() {
 		},
 		PermissionSysconsoleReadUserManagementUsers.Id: {
 			PermissionReadOtherUsersTeams,
-			PermissionGetAnalytics,
 		},
 		PermissionSysconsoleReadUserManagementTeams.Id: {
 			PermissionListPrivateTeams,
@@ -111,6 +110,7 @@ func init() {
 		},
 		PermissionSysconsoleReadReportingTeamStatistics.Id: {
 			PermissionViewTeam,
+			PermissionGetAnalytics,
 		},
 		PermissionSysconsoleWriteUserManagementUsers.Id: {
 			PermissionEditOtherUsers,
@@ -161,7 +161,7 @@ func init() {
 			PermissionReadComplianceExportJob,
 			PermissionDownloadComplianceExportResult,
 		},
-		PermissionSysconsoleReadComplianceCustomTermsOfService.Id: {
+		PermissionSysconsoleReadComplianceComplianceMonitoring.Id: {
 			PermissionReadAudits,
 		},
 		PermissionSysconsoleWriteExperimentalBleve.Id: {

server/public/model/role_test.go

@@ -275,3 +275,33 @@ func TestGetChannelModeratedPermissions(t *testing.T) {
 		})
 	}
 }
+
+func TestAddAncillaryPermissions(t *testing.T) {
+	tests := []struct {
+		Name        string
+		Permissions []string
+		Expected    []string
+	}{
+		{
+			"Add For ReadUserManagementUsers",
+			[]string{PermissionSysconsoleReadUserManagementUsers.Id},
+			[]string{PermissionSysconsoleReadUserManagementUsers.Id, PermissionReadOtherUsersTeams.Id},
+		},
+		{
+			"Add For ReadCompliance",
+			[]string{PermissionSysconsoleReadComplianceComplianceMonitoring.Id},
+			[]string{PermissionSysconsoleReadComplianceComplianceMonitoring.Id, PermissionReadAudits.Id},
+		},
+		{
+			"Add None",
+			[]string{PermissionSysconsoleReadComplianceCustomTermsOfService.Id},
+			[]string{PermissionSysconsoleReadComplianceCustomTermsOfService.Id},
+		},
+	}
+	for _, tc := range tests {
+		t.Run(tc.Name, func(t *testing.T) {
+			permissions := AddAncillaryPermissions(tc.Permissions)
+			assert.Equal(t, permissions, tc.Expected)
+		})
+	}
+}