v8.0 module release (#22975)
https://mattermost.atlassian.net/browse/MM-52079 ```release-note We upgrade the module version to 8.0. The new module path is github.com/mattermost-server/server/v8. ``` Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
Этот коммит содержится в:
Agniva De Sarker
коммит произвёл
GitHub
GitHub
родитель
831ea38f7e
Коммит
b200a07881
355
server/model/user_test.go
Обычный файл
355
server/model/user_test.go
Обычный файл
@@ -0,0 +1,355 @@
|
||||
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
||||
// See LICENSE.txt for license information.
|
||||
|
||||
package model
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"net/http"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func TestUserDeepCopy(t *testing.T) {
|
||||
id := NewId()
|
||||
authData := "authdata"
|
||||
mapKey := "key"
|
||||
mapValue := "key"
|
||||
|
||||
user := &User{Id: id, AuthData: NewString(authData), Props: map[string]string{}, NotifyProps: map[string]string{}, Timezone: map[string]string{}}
|
||||
user.Props[mapKey] = mapValue
|
||||
user.NotifyProps[mapKey] = mapValue
|
||||
user.Timezone[mapKey] = mapValue
|
||||
|
||||
copyUser := user.DeepCopy()
|
||||
copyUser.Id = "someid"
|
||||
*copyUser.AuthData = "changed"
|
||||
copyUser.Props[mapKey] = "changed"
|
||||
copyUser.NotifyProps[mapKey] = "changed"
|
||||
copyUser.Timezone[mapKey] = "changed"
|
||||
|
||||
assert.Equal(t, id, user.Id)
|
||||
assert.Equal(t, authData, *user.AuthData)
|
||||
assert.Equal(t, mapValue, user.Props[mapKey])
|
||||
assert.Equal(t, mapValue, user.NotifyProps[mapKey])
|
||||
assert.Equal(t, mapValue, user.Timezone[mapKey])
|
||||
|
||||
user = &User{Id: id}
|
||||
copyUser = user.DeepCopy()
|
||||
|
||||
assert.Equal(t, id, copyUser.Id)
|
||||
}
|
||||
|
||||
func TestUserPreSave(t *testing.T) {
|
||||
user := User{Password: "test"}
|
||||
user.PreSave()
|
||||
user.Etag(true, true)
|
||||
assert.NotNil(t, user.Timezone, "Timezone is nil")
|
||||
assert.Equal(t, user.Timezone["useAutomaticTimezone"], "true", "Timezone is not set to default")
|
||||
}
|
||||
|
||||
func TestUserPreUpdate(t *testing.T) {
|
||||
user := User{Password: "test"}
|
||||
user.PreUpdate()
|
||||
}
|
||||
|
||||
func TestUserUpdateMentionKeysFromUsername(t *testing.T) {
|
||||
user := User{Username: "user"}
|
||||
user.SetDefaultNotifications()
|
||||
assert.Equalf(t, user.NotifyProps["mention_keys"], "", "default mention keys are invalid: %v", user.NotifyProps["mention_keys"])
|
||||
|
||||
user.Username = "person"
|
||||
user.UpdateMentionKeysFromUsername("user")
|
||||
assert.Equalf(t, user.NotifyProps["mention_keys"], "", "mention keys are invalid after changing username: %v", user.NotifyProps["mention_keys"])
|
||||
|
||||
user.NotifyProps["mention_keys"] += ",mention"
|
||||
user.UpdateMentionKeysFromUsername("person")
|
||||
assert.Equalf(t, user.NotifyProps["mention_keys"], ",mention", "mention keys are invalid after adding extra mention keyword: %v", user.NotifyProps["mention_keys"])
|
||||
|
||||
user.Username = "user"
|
||||
user.UpdateMentionKeysFromUsername("person")
|
||||
assert.Equalf(t, user.NotifyProps["mention_keys"], ",mention", "mention keys are invalid after changing username with extra mention keyword: %v", user.NotifyProps["mention_keys"])
|
||||
}
|
||||
|
||||
func TestUserIsValid(t *testing.T) {
|
||||
user := User{}
|
||||
appErr := user.IsValid()
|
||||
require.True(t, HasExpectedUserIsValidError(appErr, "id", "", user.Id), "expected user is valid error: %s", appErr.Error())
|
||||
|
||||
user.Id = NewId()
|
||||
appErr = user.IsValid()
|
||||
require.True(t, HasExpectedUserIsValidError(appErr, "create_at", user.Id, user.CreateAt), "expected user is valid error: %s", appErr.Error())
|
||||
|
||||
user.CreateAt = GetMillis()
|
||||
appErr = user.IsValid()
|
||||
require.True(t, HasExpectedUserIsValidError(appErr, "update_at", user.Id, user.UpdateAt), "expected user is valid error: %s", appErr.Error())
|
||||
|
||||
user.UpdateAt = GetMillis()
|
||||
appErr = user.IsValid()
|
||||
require.True(t, HasExpectedUserIsValidError(appErr, "username", user.Id, user.Username), "expected user is valid error: %s", appErr.Error())
|
||||
|
||||
user.Username = NewId() + "^hello#"
|
||||
appErr = user.IsValid()
|
||||
require.True(t, HasExpectedUserIsValidError(appErr, "username", user.Id, user.Username), "expected user is valid error: %s", appErr.Error())
|
||||
|
||||
user.Username = NewId()
|
||||
appErr = user.IsValid()
|
||||
require.True(t, HasExpectedUserIsValidError(appErr, "email", user.Id, user.Email), "expected user is valid error: %s", appErr.Error())
|
||||
|
||||
user.Email = strings.Repeat("01234567890", 20)
|
||||
appErr = user.IsValid()
|
||||
require.True(t, HasExpectedUserIsValidError(appErr, "email", user.Id, user.Email), "expected user is valid error: %s", appErr.Error())
|
||||
|
||||
user.Email = "user@example.com"
|
||||
|
||||
user.Nickname = strings.Repeat("a", 65)
|
||||
appErr = user.IsValid()
|
||||
require.True(t, HasExpectedUserIsValidError(appErr, "nickname", user.Id, user.Nickname), "expected user is valid error: %s", appErr.Error())
|
||||
|
||||
user.Nickname = strings.Repeat("a", 64)
|
||||
require.Nil(t, user.IsValid())
|
||||
|
||||
user.FirstName = ""
|
||||
user.LastName = ""
|
||||
require.Nil(t, user.IsValid())
|
||||
|
||||
user.FirstName = strings.Repeat("a", 65)
|
||||
appErr = user.IsValid()
|
||||
require.True(t, HasExpectedUserIsValidError(appErr, "first_name", user.Id, user.FirstName), "expected user is valid error: %s", appErr.Error())
|
||||
|
||||
user.FirstName = strings.Repeat("a", 64)
|
||||
user.LastName = strings.Repeat("a", 65)
|
||||
appErr = user.IsValid()
|
||||
require.True(t, HasExpectedUserIsValidError(appErr, "last_name", user.Id, user.LastName), "expected user is valid error: %s", appErr.Error())
|
||||
|
||||
user.LastName = strings.Repeat("a", 64)
|
||||
user.Position = strings.Repeat("a", 128)
|
||||
require.Nil(t, user.IsValid())
|
||||
|
||||
user.Position = strings.Repeat("a", 129)
|
||||
appErr = user.IsValid()
|
||||
require.True(t, HasExpectedUserIsValidError(appErr, "position", user.Id, user.Position), "expected user is valid error: %s", appErr.Error())
|
||||
user.Position = ""
|
||||
|
||||
user.Roles = strings.Repeat("a", UserRolesMaxLength)
|
||||
appErr = user.IsValid()
|
||||
require.Nil(t, appErr)
|
||||
|
||||
user.Roles = strings.Repeat("a", UserRolesMaxLength+1)
|
||||
appErr = user.IsValid()
|
||||
require.True(t, HasExpectedUserIsValidError(appErr, "roles_limit", user.Id, user.Roles), "expected user is valid error: %s", appErr.Error())
|
||||
}
|
||||
|
||||
func HasExpectedUserIsValidError(err *AppError, fieldName, userId string, fieldValue any) bool {
|
||||
if err == nil {
|
||||
return false
|
||||
}
|
||||
|
||||
return err.Where == "User.IsValid" &&
|
||||
err.Id == fmt.Sprintf("model.user.is_valid.%s.app_error", fieldName) &&
|
||||
err.StatusCode == http.StatusBadRequest &&
|
||||
(userId == "" || err.DetailedError == fmt.Sprintf("user_id=%s %s=%v", userId, fieldName, fieldValue))
|
||||
}
|
||||
|
||||
func TestUserGetFullName(t *testing.T) {
|
||||
user := User{}
|
||||
assert.Equal(t, user.GetFullName(), "", "Full name should be blank")
|
||||
|
||||
user.FirstName = "first"
|
||||
assert.Equal(t, user.GetFullName(), "first", "Full name should be first name")
|
||||
|
||||
user.FirstName = ""
|
||||
user.LastName = "last"
|
||||
assert.Equal(t, user.GetFullName(), "last", "Full name should be last name")
|
||||
|
||||
user.FirstName = "first"
|
||||
assert.Equal(t, user.GetFullName(), "first last", "Full name should be first name and last name")
|
||||
}
|
||||
|
||||
func TestUserGetDisplayName(t *testing.T) {
|
||||
user := User{Username: "username"}
|
||||
|
||||
assert.Equal(t, user.GetDisplayName(ShowFullName), "username", "Display name should be username")
|
||||
assert.Equal(t, user.GetDisplayName(ShowNicknameFullName), "username", "Display name should be username")
|
||||
assert.Equal(t, user.GetDisplayName(ShowUsername), "username", "Display name should be username")
|
||||
|
||||
user.FirstName = "first"
|
||||
user.LastName = "last"
|
||||
|
||||
assert.Equal(t, user.GetDisplayName(ShowFullName), "first last", "Display name should be full name")
|
||||
assert.Equal(t, user.GetDisplayName(ShowNicknameFullName), "first last", "Display name should be full name since there is no nickname")
|
||||
assert.Equal(t, user.GetDisplayName(ShowUsername), "username", "Display name should be username")
|
||||
|
||||
user.Nickname = "nickname"
|
||||
assert.Equal(t, user.GetDisplayName(ShowNicknameFullName), "nickname", "Display name should be nickname")
|
||||
}
|
||||
|
||||
func TestUserGetDisplayNameWithPrefix(t *testing.T) {
|
||||
user := User{Username: "username"}
|
||||
|
||||
assert.Equal(t, user.GetDisplayNameWithPrefix(ShowFullName, "@"), "@username", "Display name should be username")
|
||||
assert.Equal(t, user.GetDisplayNameWithPrefix(ShowNicknameFullName, "@"), "@username", "Display name should be username")
|
||||
assert.Equal(t, user.GetDisplayNameWithPrefix(ShowUsername, "@"), "@username", "Display name should be username")
|
||||
|
||||
user.FirstName = "first"
|
||||
user.LastName = "last"
|
||||
|
||||
assert.Equal(t, user.GetDisplayNameWithPrefix(ShowFullName, "@"), "first last", "Display name should be full name")
|
||||
assert.Equal(t, user.GetDisplayNameWithPrefix(ShowNicknameFullName, "@"), "first last", "Display name should be full name since there is no nickname")
|
||||
assert.Equal(t, user.GetDisplayNameWithPrefix(ShowUsername, "@"), "@username", "Display name should be username")
|
||||
|
||||
user.Nickname = "nickname"
|
||||
assert.Equal(t, user.GetDisplayNameWithPrefix(ShowNicknameFullName, "@"), "nickname", "Display name should be nickname")
|
||||
}
|
||||
|
||||
type usernamesTest struct {
|
||||
value string
|
||||
expected bool
|
||||
expectedWhenRemote bool
|
||||
}
|
||||
|
||||
var usernames = []usernamesTest{
|
||||
{"spin-punch", true, true},
|
||||
{"sp", true, true},
|
||||
{"s", true, true},
|
||||
{"1spin-punch", true, true},
|
||||
{"-spin-punch", true, true},
|
||||
{".spin-punch", true, true},
|
||||
{"Spin-punch", false, false},
|
||||
{"spin punch-", false, false},
|
||||
{"spin_punch", true, true},
|
||||
{"spin", true, true},
|
||||
{"PUNCH", false, false},
|
||||
{"spin.punch", true, true},
|
||||
{"spin'punch", false, false},
|
||||
{"spin*punch", false, false},
|
||||
{"all", false, false},
|
||||
{"system", false, false},
|
||||
{"spin:punch", false, true},
|
||||
}
|
||||
|
||||
func TestValidUsername(t *testing.T) {
|
||||
for _, v := range usernames {
|
||||
if IsValidUsername(v.value) != v.expected {
|
||||
t.Errorf("expect %v as %v", v.value, v.expected)
|
||||
}
|
||||
}
|
||||
for _, v := range usernames {
|
||||
if IsValidUsernameAllowRemote(v.value) != v.expectedWhenRemote {
|
||||
t.Errorf("expect %v as %v", v.value, v.expectedWhenRemote)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestNormalizeUsername(t *testing.T) {
|
||||
assert.Equal(t, NormalizeUsername("Spin-punch"), "spin-punch", "didn't normalize username properly")
|
||||
assert.Equal(t, NormalizeUsername("PUNCH"), "punch", "didn't normalize username properly")
|
||||
assert.Equal(t, NormalizeUsername("spin"), "spin", "didn't normalize username properly")
|
||||
}
|
||||
|
||||
func TestNormalizeEmail(t *testing.T) {
|
||||
assert.Equal(t, NormalizeEmail("TEST@EXAMPLE.COM"), "test@example.com", "didn't normalize email properly")
|
||||
assert.Equal(t, NormalizeEmail("TEST2@example.com"), "test2@example.com", "didn't normalize email properly")
|
||||
assert.Equal(t, NormalizeEmail("test3@example.com"), "test3@example.com", "didn't normalize email properly")
|
||||
}
|
||||
|
||||
func TestCleanUsername(t *testing.T) {
|
||||
assert.Equal(t, CleanUsername("Spin-punch"), "spin-punch", "didn't clean name properly")
|
||||
assert.Equal(t, CleanUsername("PUNCH"), "punch", "didn't clean name properly")
|
||||
assert.Equal(t, CleanUsername("spin'punch"), "spin-punch", "didn't clean name properly")
|
||||
assert.Equal(t, CleanUsername("spin"), "spin", "didn't clean name properly")
|
||||
assert.Len(t, CleanUsername("all"), 27, "didn't clean name properly")
|
||||
}
|
||||
|
||||
func TestRoles(t *testing.T) {
|
||||
require.True(t, IsValidUserRoles("team_user"))
|
||||
require.False(t, IsValidUserRoles("system_admin"))
|
||||
require.True(t, IsValidUserRoles("system_user system_admin"))
|
||||
require.False(t, IsInRole("system_admin junk", "admin"))
|
||||
require.True(t, IsInRole("system_admin junk", "system_admin"))
|
||||
require.False(t, IsInRole("admin", "system_admin"))
|
||||
}
|
||||
|
||||
func TestIsValidLocale(t *testing.T) {
|
||||
for _, test := range []struct {
|
||||
Name string
|
||||
Locale string
|
||||
Expected bool
|
||||
}{
|
||||
{
|
||||
Name: "empty locale",
|
||||
Locale: "",
|
||||
Expected: true,
|
||||
},
|
||||
{
|
||||
Name: "locale with only language",
|
||||
Locale: "fr",
|
||||
Expected: true,
|
||||
},
|
||||
{
|
||||
Name: "locale with region",
|
||||
Locale: "en-DE", // English, as used in Germany
|
||||
Expected: true,
|
||||
},
|
||||
{
|
||||
Name: "invalid locale",
|
||||
Locale: "'",
|
||||
Expected: false,
|
||||
},
|
||||
|
||||
// Note that the following cases are all valid language tags, but they're considered invalid here because of
|
||||
// the max length of the User.Locale field.
|
||||
{
|
||||
Name: "locale with extended language subtag",
|
||||
Locale: "zh-yue-HK", // Chinese, Cantonese, as used in Hong Kong
|
||||
Expected: false,
|
||||
},
|
||||
{
|
||||
Name: "locale with script",
|
||||
Locale: "hy-Latn-IT-arevela", // Eastern Armenian written in Latin script, as used in Italy
|
||||
Expected: false,
|
||||
},
|
||||
{
|
||||
Name: "locale with variant",
|
||||
Locale: "sl-rozaj-biske", // San Giorgio dialect of Resian dialect of Slovenian
|
||||
Expected: false,
|
||||
},
|
||||
{
|
||||
Name: "locale with extension",
|
||||
Locale: "de-DE-u-co-phonebk", // German, as used in Germany, using German phonebook sort order
|
||||
Expected: false,
|
||||
},
|
||||
} {
|
||||
t.Run(test.Name, func(t *testing.T) {
|
||||
assert.Equal(t, test.Expected, IsValidLocale(test.Locale))
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestUserSlice(t *testing.T) {
|
||||
t.Run("FilterByActive", func(t *testing.T) {
|
||||
user0 := &User{Id: "user0", DeleteAt: 0, IsBot: true}
|
||||
user1 := &User{Id: "user1", DeleteAt: 0, IsBot: true}
|
||||
user2 := &User{Id: "user2", DeleteAt: 1, IsBot: false}
|
||||
|
||||
slice := UserSlice([]*User{user0, user1, user2})
|
||||
|
||||
activeUsers := slice.FilterByActive(true)
|
||||
assert.Len(t, activeUsers, 2)
|
||||
for _, user := range activeUsers {
|
||||
assert.True(t, user.DeleteAt == 0)
|
||||
}
|
||||
|
||||
inactiveUsers := slice.FilterByActive(false)
|
||||
assert.Len(t, inactiveUsers, 1)
|
||||
for _, user := range inactiveUsers {
|
||||
assert.True(t, user.DeleteAt != 0)
|
||||
}
|
||||
|
||||
nonBotUsers := slice.FilterWithoutBots()
|
||||
assert.Len(t, nonBotUsers, 1)
|
||||
})
|
||||
}
|
||||
Ссылка в новой задаче
Block a user