From b0cdc51aa48c88ea051c18bacf74e8485156b5d1 Mon Sep 17 00:00:00 2001 From: Arya Khochare <91268931+Aryakoste@users.noreply.github.com> Date: Tue, 15 Oct 2024 16:16:06 +0530 Subject: [PATCH] errcheck issues fixed (#28572) Co-authored-by: Ben Schumacher --- server/.golangci.yml | 1 - server/channels/api4/websocket_test.go | 9 ++++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index a826cb5345..95db8828f4 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -93,7 +93,6 @@ issues: channels/api4/user.go|\ channels/api4/user_test.go|\ channels/api4/webhook_test.go|\ - channels/api4/websocket_test.go|\ channels/app/admin.go|\ channels/app/app_test.go|\ channels/app/authorization_test.go|\ diff --git a/server/channels/api4/websocket_test.go b/server/channels/api4/websocket_test.go index 200fba41c4..a8cac6a2fb 100644 --- a/server/channels/api4/websocket_test.go +++ b/server/channels/api4/websocket_test.go @@ -258,7 +258,8 @@ func TestWebSocketSendBinary(t *testing.T) { time.Sleep(1000 * time.Millisecond) - WebSocketClient.SendBinaryMessage("get_statuses", nil) + err = WebSocketClient.SendBinaryMessage("get_statuses", nil) + require.NoError(t, err) resp = <-WebSocketClient.ResponseChannel require.Nil(t, resp.Error, resp.Error) require.Equal(t, resp.SeqReply, WebSocketClient.Sequence-1) @@ -270,9 +271,10 @@ func TestWebSocketSendBinary(t *testing.T) { require.True(t, ok) require.Equal(t, model.StatusOnline, status) - WebSocketClient.SendBinaryMessage("get_statuses_by_ids", map[string]any{ + err = WebSocketClient.SendBinaryMessage("get_statuses_by_ids", map[string]any{ "user_ids": []string{th.BasicUser2.Id}, }) + require.NoError(t, err) status, ok = resp.Data[th.BasicUser2.Id] require.True(t, ok) require.Equal(t, model.StatusOnline, status) @@ -308,7 +310,8 @@ func TestWebSocketStatuses(t *testing.T) { _, err = th.App.Srv().Store().User().VerifyEmail(ruser2.Id, ruser2.Email) require.NoError(t, err) - client.Login(context.Background(), user.Email, user.Password) + _, _, err = client.Login(context.Background(), user.Email, user.Password) + require.NoError(t, err) th.LoginBasic2()