From abce5d620f4f580d279eeaf6e5448f2d031a9bdb Mon Sep 17 00:00:00 2001 From: Agniva De Sarker Date: Fri, 22 May 2020 15:14:42 +0530 Subject: [PATCH] MM-25439: Skip SuddenClose flaky test (#14628) Automatic Merge --- model/websocket_client_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/model/websocket_client_test.go b/model/websocket_client_test.go index f86a233d9c..855d6c4b39 100644 --- a/model/websocket_client_test.go +++ b/model/websocket_client_test.go @@ -57,6 +57,11 @@ func TestWebSocketRace(t *testing.T) { } func TestWebSocketClose(t *testing.T) { + // This fails in SuddenClose because we check for closing the writeChan + // only after waiting the closure of Event and Response channels. + // Therefore, it is still racy and can panic. There is no use chasing this + // again because it will be completely overhauled in v6. + t.Skip("Skipping the test. Will be changed in v6.") s := httptest.NewServer(dummyWebsocketHandler(t)) defer s.Close()