Fixing group code review issues

api/user.go

@@ -430,7 +430,7 @@ func Login(c *Context, w http.ResponseWriter, r *http.Request, user *model.User,
 	w.Header().Set(model.HEADER_TOKEN, session.Token)
 
 	tokens := GetMultiSessionCookie(r)
-	multiToken = ""
+	multiToken := ""
 	seen := make(map[string]string)
 	seen[session.TeamId] = session.TeamId
 	for _, token := range tokens {

api/web_team_hub.go

@@ -96,7 +96,8 @@ func ShouldSendEvent(webCon *WebConn, msg *model.Message) bool {
 		}
 	} else {
 		// Don't share a user's view events with other users
-		if msg.Action == model.ACTION_CHANNEL_VIEWED {
+		// but you still need to share it with yourself
+		if webCon.UserId != msg.UserId && msg.Action == model.ACTION_CHANNEL_VIEWED {
 			return false
 		}
 

web/react/utils/client.jsx

@@ -4,8 +4,8 @@ var BrowserStore = require('../stores/browser_store.jsx');
 var TeamStore = require('../stores/team_store.jsx');
 var ErrorStore = require('../stores/error_store.jsx');
 
-export function track(category, action, label, prop, val) {
+export function track(category, action, label, property, value) {
-    global.window.analytics.track(action, {category: category, label: label, property: prop, value: val});
+    global.window.analytics.track(action, {category, label, property, value});
 }
 
 export function trackPage() {