mirrors/mostlymatter
1
0
Форкнуть 0
Код Задачи Запросы на слияние Действия Пакеты Проекты Релизы Вики Активность

Additional refactoring according to issues not caught by eslint

Просмотр исходного кода
Этот коммит содержится в:
Reed Garmsen
2015-09-02 09:46:40 -07:00
родитель e2a24f40b7
Коммит aac83dcedc
8 изменённых файлов: 56 добавлений и 60 удалений
Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

80
web/react/components/user_settings_notifications.jsx
Просмотреть файл

@@ -163,15 +163,15 @@ export default class NotificationsTab extends React.Component {
}
handleNotifyRadio(notifyLevel) {
this.setState({notifyLevel: notifyLevel});
this.refs.wrapper.getDOMNode().focus();
React.findDOMNode(this.refs.wrapper).focus();
}
handleEmailRadio(enableEmail) {
this.setState({enableEmail: enableEmail});
this.refs.wrapper.getDOMNode().focus();
React.findDOMNode(this.refs.wrapper).focus();
}
handleSoundRadio(enableSound) {
this.setState({enableSound: enableSound});
this.refs.wrapper.getDOMNode().focus();
React.findDOMNode(this.refs.wrapper).focus();
}
updateUsernameKey(val) {
this.setState({usernameKey: val});
@@ -189,10 +189,10 @@ export default class NotificationsTab extends React.Component {
this.setState({channelKey: val});
}
updateCustomMentionKeys() {
var checked = this.refs.customcheck.getDOMNode().checked;
var checked = React.findDOMNode(this.refs.customcheck).checked;
if (checked) {
var text = this.refs.custommentions.getDOMNode().value;
var text = React.findDOMNode(this.refs.custommentions).value;
// remove all spaces and split string into individual keys
this.setState({customKeys: text.replace(/ /g, ''), customKeysChecked: true});
@@ -201,7 +201,7 @@ export default class NotificationsTab extends React.Component {
}
}
onCustomChange() {
this.refs.customcheck.getDOMNode().checked = true;
React.findDOMNode(this.refs.customcheck).checked = true;
this.updateCustomMentionKeys();
}
render() {
@@ -210,8 +210,6 @@ export default class NotificationsTab extends React.Component {
serverError = this.state.serverError;
}
var self = this;
var user = this.props.user;
var desktopSection;
@@ -234,7 +232,7 @@ export default class NotificationsTab extends React.Component {
<label>
<input type='radio'
checked={notifyActive[0]}
onChange={self.handleNotifyRadio.bind(this, 'all')}
onChange={this.handleNotifyRadio.bind(this, 'all')}
>
For all activity
</input>
@@ -246,7 +244,7 @@ export default class NotificationsTab extends React.Component {
<input
type='radio'
checked={notifyActive[1]}
onChange={self.handleNotifyRadio.bind(this, 'mention')}
onChange={this.handleNotifyRadio.bind(this, 'mention')}
>
Only for mentions and private messages
</input>
@@ -258,7 +256,7 @@ export default class NotificationsTab extends React.Component {
<input
type='radio'
checked={notifyActive[2]}
onChange={self.handleNotifyRadio.bind(this, 'none')}
onChange={this.handleNotifyRadio.bind(this, 'none')}
>
Never
</input>
@@ -268,9 +266,9 @@ export default class NotificationsTab extends React.Component {
);
handleUpdateDesktopSection = function updateDesktopSection(e) {
self.props.updateSection('');
this.props.updateSection('');
e.preventDefault();
};
}.bind(this);
let extraInfo = (
<div className='setting-list__hint'>
@@ -299,8 +297,8 @@ export default class NotificationsTab extends React.Component {
}
handleUpdateDesktopSection = function updateDesktopSection() {
self.props.updateSection('desktop');
};
this.props.updateSection('desktop');
}.bind(this);
desktopSection = (
<SettingItemMin
@@ -330,7 +328,7 @@ export default class NotificationsTab extends React.Component {
<input
type='radio'
checked={soundActive[0]}
onChange={self.handleSoundRadio.bind(this, 'true')}
onChange={this.handleSoundRadio.bind(this, 'true')}
>
On
</input>
@@ -342,7 +340,7 @@ export default class NotificationsTab extends React.Component {
<input
type='radio'
checked={soundActive[1]}
onChange={self.handleSoundRadio.bind(this, 'false')}
onChange={this.handleSoundRadio.bind(this, 'false')}
>
Off
</input>
@@ -353,9 +351,9 @@ export default class NotificationsTab extends React.Component {
);
handleUpdateSoundSection = function updateSoundSection(e) {
self.props.updateSection('');
this.props.updateSection('');
e.preventDefault();
};
}.bind(this);
soundSection = (
<SettingItemMax
@@ -377,8 +375,8 @@ export default class NotificationsTab extends React.Component {
}
handleUpdateSoundSection = function updateSoundSection() {
self.props.updateSection('sound');
};
this.props.updateSection('sound');
}.bind(this);
soundSection = (
<SettingItemMin
@@ -409,7 +407,7 @@ export default class NotificationsTab extends React.Component {
<input
type='radio'
checked={emailActive[0]}
onChange={self.handleEmailRadio.bind(this, 'true')}
onChange={this.handleEmailRadio.bind(this, 'true')}
>
On
</input>
@@ -421,7 +419,7 @@ export default class NotificationsTab extends React.Component {
<input
type='radio'
checked={emailActive[1]}
onChange={self.handleEmailRadio.bind(this, 'false')}
onChange={this.handleEmailRadio.bind(this, 'false')}
>
Off
</input>
@@ -433,9 +431,9 @@ export default class NotificationsTab extends React.Component {
);
handleUpdateEmailSection = function updateEmailSection(e) {
self.props.updateSection('');
this.props.updateSection('');
e.preventDefault();
};
}.bind(this);
emailSection = (
<SettingItemMax
@@ -455,8 +453,8 @@ export default class NotificationsTab extends React.Component {
}
handleUpdateEmailSection = function updateEmailSection() {
self.props.updateSection('email');
};
this.props.updateSection('email');
}.bind(this);
emailSection = (
<SettingItemMin
@@ -480,8 +478,8 @@ export default class NotificationsTab extends React.Component {
if (user.first_name) {
handleUpdateFirstNameKey = function handleFirstNameKeyChange(e) {
self.updateFirstNameKey(e.target.checked);
};
this.updateFirstNameKey(e.target.checked);
}.bind(this);
inputs.push(
<div key='userNotificationFirstNameOption'>
<div className='checkbox'>
@@ -500,8 +498,8 @@ export default class NotificationsTab extends React.Component {
}
handleUpdateUsernameKey = function handleUsernameKeyChange(e) {
self.updateUsernameKey(e.target.checked);
};
this.updateUsernameKey(e.target.checked);
}.bind(this);
inputs.push(
<div key='userNotificationUsernameOption'>
<div className='checkbox'>
@@ -519,8 +517,8 @@ export default class NotificationsTab extends React.Component {
);
handleUpdateMentionKey = function handleMentionKeyChange(e) {
self.updateMentionKey(e.target.checked);
};
this.updateMentionKey(e.target.checked);
}.bind(this);
inputs.push(
<div key='userNotificationMentionOption'>
<div className='checkbox'>
@@ -538,8 +536,8 @@ export default class NotificationsTab extends React.Component {
);
handleUpdateAllKey = function handleAllKeyChange(e) {
self.updateAllKey(e.target.checked);
};
this.updateAllKey(e.target.checked);
}.bind(this);
inputs.push(
<div key='userNotificationAllOption'>
<div className='checkbox'>
@@ -557,8 +555,8 @@ export default class NotificationsTab extends React.Component {
);
handleUpdateChannelKey = function handleChannelKeyChange(e) {
self.updateChannelKey(e.target.checked);
};
this.updateChannelKey(e.target.checked);
}.bind(this);
inputs.push(
<div key='userNotificationChannelOption'>
<div className='checkbox'>
@@ -600,9 +598,9 @@ export default class NotificationsTab extends React.Component {
);
handleUpdateKeysSection = function updateKeysSection(e) {
self.props.updateSection('');
this.props.updateSection('');
e.preventDefault();
};
}.bind(this);
keysSection = (
<SettingItemMax
title='Words that trigger mentions'
@@ -645,8 +643,8 @@ export default class NotificationsTab extends React.Component {
}
handleUpdateKeysSection = function updateKeysSection() {
self.props.updateSection('keys');
};
this.props.updateSection('keys');
}.bind(this);
keysSection = (
<SettingItemMin