[MM-64686] Expose audit logging functionality via plugin API (#31204)

This commit exposes audit logging functionality to plugins via the plugin API, allowing plugins to create and log audit records. Additionally, it addresses a gob encoding issue that could cause plugin crashes when audit data contains nil pointers or unregistered types.
Этот коммит содержится в:
David Krauser
2025-06-25 20:37:32 -04:00
коммит произвёл GitHub
родитель efb960a160
Коммит aaa62a40ae
68 изменённых файлов: 878 добавлений и 750 удалений

Просмотреть файл

@@ -11,7 +11,6 @@ import (
"github.com/mattermost/mattermost/server/public/model"
"github.com/mattermost/mattermost/server/public/shared/mlog"
"github.com/mattermost/mattermost/server/v8/channels/audit"
)
func (api *API) InitAccessControlPolicy() {
@@ -42,9 +41,9 @@ func createAccessControlPolicy(c *Context, w http.ResponseWriter, r *http.Reques
return
}
auditRec := c.MakeAuditRecord("createAccessControlPolicy", audit.Fail)
auditRec := c.MakeAuditRecord("createAccessControlPolicy", model.AuditStatusFail)
defer c.LogAuditRec(auditRec)
audit.AddEventParameterAuditable(auditRec, "requested", &policy)
model.AddEventParameterAuditableToAuditRec(auditRec, "requested", &policy)
if !c.App.SessionHasPermissionTo(*c.AppContext.Session(), model.PermissionManageSystem) {
c.SetPermissionError(model.PermissionManageSystem)
@@ -113,9 +112,9 @@ func deleteAccessControlPolicy(c *Context, w http.ResponseWriter, r *http.Reques
}
policyID := c.Params.PolicyId
auditRec := c.MakeAuditRecord("deleteAccessControlPolicy", audit.Fail)
auditRec := c.MakeAuditRecord("deleteAccessControlPolicy", model.AuditStatusFail)
defer c.LogAuditRec(auditRec)
audit.AddEventParameter(auditRec, "id", policyID)
model.AddEventParameterToAuditRec(auditRec, "id", policyID)
appErr := c.App.DeleteAccessControlPolicy(c.AppContext, policyID)
if appErr != nil {
@@ -246,9 +245,9 @@ func updateActiveStatus(c *Context, w http.ResponseWriter, r *http.Request) {
policyID := c.Params.PolicyId
auditRec := c.MakeAuditRecord("updateActiveStatus", audit.Fail)
auditRec := c.MakeAuditRecord("updateActiveStatus", model.AuditStatusFail)
defer c.LogAuditRec(auditRec)
audit.AddEventParameter(auditRec, "id", policyID)
model.AddEventParameterToAuditRec(auditRec, "id", policyID)
active := r.URL.Query().Get("active")
if active != "true" && active != "false" {
@@ -260,7 +259,7 @@ func updateActiveStatus(c *Context, w http.ResponseWriter, r *http.Request) {
c.SetInvalidParamWithErr("active", err)
return
}
audit.AddEventParameter(auditRec, "active", activeBool)
model.AddEventParameterToAuditRec(auditRec, "active", activeBool)
appErr := c.App.UpdateAccessControlPolicyActive(c.AppContext, policyID, activeBool)
if appErr != nil {
@@ -293,10 +292,10 @@ func assignAccessPolicy(c *Context, w http.ResponseWriter, r *http.Request) {
return
}
auditRec := c.MakeAuditRecord("assignAccessPolicy", audit.Fail)
auditRec := c.MakeAuditRecord("assignAccessPolicy", model.AuditStatusFail)
defer c.LogAuditRec(auditRec)
audit.AddEventParameter(auditRec, "id", policyID)
audit.AddEventParameter(auditRec, "channel_ids", assignments.ChannelIds)
model.AddEventParameterToAuditRec(auditRec, "id", policyID)
model.AddEventParameterToAuditRec(auditRec, "channel_ids", assignments.ChannelIds)
if len(assignments.ChannelIds) != 0 {
_, appErr := c.App.AssignAccessControlPolicyToChannels(c.AppContext, policyID, assignments.ChannelIds)
@@ -325,10 +324,10 @@ func unassignAccessPolicy(c *Context, w http.ResponseWriter, r *http.Request) {
ChannelIds []string `json:"channel_ids"`
}
auditRec := c.MakeAuditRecord("unassignAccessPolicy", audit.Fail)
auditRec := c.MakeAuditRecord("unassignAccessPolicy", model.AuditStatusFail)
defer c.LogAuditRec(auditRec)
audit.AddEventParameter(auditRec, "id", policyID)
audit.AddEventParameter(auditRec, "channel_ids", assignments.ChannelIds)
model.AddEventParameterToAuditRec(auditRec, "id", policyID)
model.AddEventParameterToAuditRec(auditRec, "channel_ids", assignments.ChannelIds)
err := json.NewDecoder(r.Body).Decode(&assignments)
if err != nil {