Add read_channel_content permission (#24118)

* Add read_channel_content permission

* fix tests

* update system console default permissions per role

* add read_channel_content to e2e defaultRolesPermissions

* Migration to include custom roles

* change deprecated isNotExactRole for isNotRole

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

webapp/channels/src/components/admin_console/permission_schemes_settings/guest_permissions_tree/index.tsx

@@ -17,6 +17,8 @@ export const GUEST_INCLUDED_PERMISSIONS = [
     Permissions.DELETE_POST,
     Permissions.ADD_REACTION,
     Permissions.REMOVE_REACTION,
+    Permissions.READ_CHANNEL,
+    Permissions.UPLOAD_FILE,
     Permissions.USE_CHANNEL_MENTIONS,
     Permissions.USE_GROUP_MENTIONS,
     Permissions.CREATE_POST,

webapp/channels/src/packages/mattermost-redux/src/constants/permissions.ts

@@ -33,6 +33,7 @@ const values = {
     DELETE_PRIVATE_CHANNEL: 'delete_private_channel',
     EDIT_OTHER_USERS: 'edit_other_users',
     READ_CHANNEL: 'read_channel',
+    READ_CHANNEL_CONTENT: 'read_channel_content',
     READ_PUBLIC_CHANNEL: 'read_public_channel',
     ADD_REACTION: 'add_reaction',
     REMOVE_REACTION: 'remove_reaction',
@@ -107,6 +108,7 @@ const values = {
     CREATE_ELASTICSEARCH_POST_AGGREGATION_JOB: 'create_elasticsearch_post_aggregation_job',
     READ_ELASTICSEARCH_POST_INDEXING_JOB: 'read_elasticsearch_post_indexing_job',
     READ_ELASTICSEARCH_POST_AGGREGATION_JOB: 'read_elasticsearch_post_aggregation_job',
+    USE_SLASH_COMMANDS: 'use_slash_commands',
 
     SYSCONSOLE_READ_ABOUT_EDITION_AND_LICENSE: 'sysconsole_read_about_edition_and_license',
     SYSCONSOLE_WRITE_ABOUT_EDITION_AND_LICENSE: 'sysconsole_write_about_edition_and_license',

webapp/channels/src/utils/constants.tsx

@@ -1184,6 +1184,7 @@ export const PermissionsScope = {
     [Permissions.DELETE_PRIVATE_CHANNEL]: 'channel_scope',
     [Permissions.EDIT_OTHER_USERS]: 'system_scope',
     [Permissions.READ_CHANNEL]: 'channel_scope',
+    [Permissions.READ_CHANNEL_CONTENT]: 'channel_scope',
     [Permissions.READ_PUBLIC_CHANNEL]: 'team_scope',
     [Permissions.ADD_REACTION]: 'channel_scope',
     [Permissions.REMOVE_REACTION]: 'channel_scope',
@@ -1243,13 +1244,13 @@ export const PermissionsScope = {
     [Permissions.DELETE_CUSTOM_GROUP]: 'system_scope',
     [Permissions.RESTORE_CUSTOM_GROUP]: 'system_scope',
     [Permissions.MANAGE_CUSTOM_GROUP_MEMBERS]: 'system_scope',
+    [Permissions.USE_SLASH_COMMANDS]: 'channel_scope',
 };
 
 export const DefaultRolePermissions = {
     all_users: [
         Permissions.CREATE_DIRECT_CHANNEL,
         Permissions.CREATE_GROUP_CHANNEL,
-        Permissions.PERMANENT_DELETE_USER,
         Permissions.CREATE_TEAM,
         Permissions.LIST_TEAM_CHANNELS,
         Permissions.JOIN_PUBLIC_CHANNELS,
@@ -1264,6 +1265,7 @@ export const DefaultRolePermissions = {
         Permissions.INVITE_USER,
         Permissions.ADD_USER_TO_TEAM,
         Permissions.READ_CHANNEL,
+        Permissions.READ_CHANNEL_CONTENT,
         Permissions.ADD_REACTION,
         Permissions.REMOVE_REACTION,
         Permissions.MANAGE_PUBLIC_CHANNEL_MEMBERS,
@@ -1275,8 +1277,6 @@ export const DefaultRolePermissions = {
         Permissions.MANAGE_PRIVATE_CHANNEL_MEMBERS,
         Permissions.DELETE_POST,
         Permissions.EDIT_POST,
-        Permissions.LIST_PUBLIC_TEAMS,
-        Permissions.JOIN_PUBLIC_TEAMS,
         Permissions.USE_CHANNEL_MENTIONS,
         Permissions.USE_GROUP_MENTIONS,
         Permissions.CREATE_CUSTOM_GROUP,
@@ -1289,8 +1289,13 @@ export const DefaultRolePermissions = {
         Permissions.PLAYBOOK_PRIVATE_MANAGE_MEMBERS,
         Permissions.PLAYBOOK_PUBLIC_MANAGE_PROPERTIES,
         Permissions.PLAYBOOK_PRIVATE_MANAGE_PROPERTIES,
-        Permissions.PLAYBOOK_PUBLIC_MAKE_PRIVATE,
         Permissions.RUN_CREATE,
+        Permissions.USE_SLASH_COMMANDS,
+        Permissions.DELETE_EMOJIS,
+        Permissions.INVITE_GUEST,
+        Permissions.CREATE_EMOJIS,
+        Permissions.RUN_VIEW,
+        Permissions.RESTORE_CUSTOM_GROUP,
     ],
     channel_admin: [
         Permissions.MANAGE_CHANNEL_ROLES,