Add read_channel_content permission (#24118)

* Add read_channel_content permission

* fix tests

* update system console default permissions per role

* add read_channel_content to e2e defaultRolesPermissions

* Migration to include custom roles

* change deprecated isNotExactRole for isNotRole

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

server/channels/store/sqlstore/integrity_test.go

@@ -258,6 +258,7 @@ func createDefaultRoles(ss store.Store) {
 		DisplayName: model.ChannelUserRoleId,
 		Permissions: []string{
 			model.PermissionReadChannel.Id,
+			model.PermissionReadChannelContent.Id,
 			model.PermissionCreatePost.Id,
 		},
 	})
@@ -267,6 +268,7 @@ func createDefaultRoles(ss store.Store) {
 		DisplayName: model.ChannelGuestRoleId,
 		Permissions: []string{
 			model.PermissionReadChannel.Id,
+			model.PermissionReadChannelContent.Id,
 			model.PermissionCreatePost.Id,
 		},
 	})

server/channels/store/storetest/scheme_store.go

@@ -67,6 +67,7 @@ func createDefaultRoles(ss store.Store) {
 		DisplayName: model.ChannelUserRoleId,
 		Permissions: []string{
 			model.PermissionReadChannel.Id,
+			model.PermissionReadChannelContent.Id,
 			model.PermissionCreatePost.Id,
 		},
 	})
@@ -76,6 +77,7 @@ func createDefaultRoles(ss store.Store) {
 		DisplayName: model.ChannelGuestRoleId,
 		Permissions: []string{
 			model.PermissionReadChannel.Id,
+			model.PermissionReadChannelContent.Id,
 			model.PermissionCreatePost.Id,
 		},
 	})
@@ -158,7 +160,7 @@ func testSchemeStoreSave(t *testing.T, ss store.Store) {
 
 	role4, err := ss.Role().GetByName(context.Background(), d1.DefaultChannelUserRole)
 	assert.NoError(t, err)
-	assert.Equal(t, role4.Permissions, []string{"read_channel", "create_post"})
+	assert.Equal(t, role4.Permissions, []string{"read_channel", "read_channel_content", "create_post"})
 	assert.True(t, role4.SchemeManaged)
 
 	role5, err := ss.Role().GetByName(context.Background(), d1.DefaultTeamGuestRole)
@@ -168,7 +170,7 @@ func testSchemeStoreSave(t *testing.T, ss store.Store) {
 
 	role6, err := ss.Role().GetByName(context.Background(), d1.DefaultChannelGuestRole)
 	assert.NoError(t, err)
-	assert.Equal(t, role6.Permissions, []string{"read_channel", "create_post"})
+	assert.Equal(t, role6.Permissions, []string{"read_channel", "read_channel_content", "create_post"})
 	assert.True(t, role6.SchemeManaged)
 
 	// Change the scheme description and update.
@@ -386,7 +388,7 @@ func testSchemeStoreDelete(t *testing.T, ss store.Store) {
 
 	role4, err := ss.Role().GetByName(context.Background(), d1.DefaultChannelUserRole)
 	assert.NoError(t, err)
-	assert.Equal(t, role4.Permissions, []string{"read_channel", "create_post"})
+	assert.Equal(t, role4.Permissions, []string{"read_channel", "read_channel_content", "create_post"})
 	assert.True(t, role4.SchemeManaged)
 
 	role5, err := ss.Role().GetByName(context.Background(), d1.DefaultTeamGuestRole)
@@ -396,7 +398,7 @@ func testSchemeStoreDelete(t *testing.T, ss store.Store) {
 
 	role6, err := ss.Role().GetByName(context.Background(), d1.DefaultChannelGuestRole)
 	assert.NoError(t, err)
-	assert.Equal(t, role6.Permissions, []string{"read_channel", "create_post"})
+	assert.Equal(t, role6.Permissions, []string{"read_channel", "read_channel_content", "create_post"})
 	assert.True(t, role6.SchemeManaged)
 
 	// Delete the scheme.