mirrors/mostlymatter
1
0
Форкнуть 0
Код Задачи Запросы на слияние Действия Пакеты Проекты Релизы Вики Активность

MM-40414: Add empty state icons (#25282)

Просмотр исходного кода 
Automatic Merge
Этот коммит содержится в:
Ashish Dhama
2023-11-20 09:30:14 +05:30
коммит произвёл GitHub
родитель 8bd603eb12
Коммит a9a879d00d
57 изменённых файлов: 809 добавлений и 151 удалений
Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

6
e2e-tests/cypress/tests/integration/channels/accessibility/accessibility_buttons_spec.js
Просмотреть файл

@@ -69,13 +69,13 @@ describe('Verify Accessibility Support in different Buttons', () => {
tab({shift: true}).
tab();
// # Press tab until the focus is on the Pinned posts button
// # Press tab until the focus is on the Pinned messages button
cy.focused().tab().tab();
// * Verify accessibility support in Pinned Posts button
// * Verify accessibility support in Pinned messages button
cy.uiGetChannelPinButton().
should('be.focused').
and('have.attr', 'aria-label', 'Pinned posts').
and('have.attr', 'aria-label', 'Pinned messages').
tab().tab().tab().tab();
});
});

4
e2e-tests/cypress/tests/integration/channels/accessibility/accessibility_post_spec.js
Просмотреть файл

@@ -185,7 +185,7 @@ describe('Verify Accessibility Support in Post', () => {
cy.focused().tab();
// * Verify focus is on the save post button
cy.get(`#CENTER_flagIcon_${postId}`).should('be.focused').and('have.attr', 'aria-label', 'save');
cy.get(`#CENTER_flagIcon_${postId}`).should('be.focused').and('have.attr', 'aria-label', 'save message');
cy.focused().tab();
// * Verify focus is on message actions button
@@ -243,7 +243,7 @@ describe('Verify Accessibility Support in Post', () => {
cy.focused().tab({shift: true});
// * Verify focus is on the save icon
cy.get(`#RHS_COMMENT_flagIcon_${postId}`).should('be.focused').and('have.attr', 'aria-label', 'save');
cy.get(`#RHS_COMMENT_flagIcon_${postId}`).should('be.focused').and('have.attr', 'aria-label', 'save message');
cy.focused().tab({shift: true});
// * Verify focus is on the reactions button

8
e2e-tests/cypress/tests/integration/channels/bot_accounts/tags_spec.js
Просмотреть файл

@@ -73,21 +73,21 @@ describe('Bot tags', () => {
rhsPostHasBotBadge(postId);
});
it('MM-T1833 BOT tag is visible in Pinned Posts', () => {
it('MM-T1833 BOT tag is visible in Pinned Messages', () => {
// # Open pinned posts
cy.uiGetChannelPinButton().click();
// * Verify bot badge
cy.get('.sidebar--right__title').should('contain.text', 'Pinned Posts');
cy.get('.sidebar--right__title').should('contain.text', 'Pinned messages');
rhsPostHasBotBadge(postId);
});
it('MM-T3659 BOT tag is visible in Saved Posts', () => {
it('MM-T3659 BOT tag is visible in Saved Messages', () => {
// # Open saved posts
cy.uiGetSavedPostButton().click();
// * Verify bot badge
cy.get('.sidebar--right__title').should('contain.text', 'Saved Posts');
cy.get('.sidebar--right__title').should('contain.text', 'Saved messages');
rhsPostHasBotBadge(postId);
});
});

2
e2e-tests/cypress/tests/integration/channels/channel/channel_info_rhs_spec.js
Просмотреть файл

@@ -248,7 +248,7 @@ describe('Channel Info RHS', () => {
cy.get('#channel-info-btn').click();
// # Click on "Pinned Messages"
cy.uiGetRHS().findByTestId('channel_info_rhs-menu').findByText('Pinned Messages').should('be.visible').click();
cy.uiGetRHS().findByTestId('channel_info_rhs-menu').findByText('Pinned messages').should('be.visible').click();
// * Ensure we see the Pinned Post RHS
cy.uiGetRHS().findByText('Hello channel info rhs spec').should('be.visible');

24
e2e-tests/cypress/tests/integration/channels/channel/open_rhs_coming_from_system_console_spec.ts
Просмотреть файл

@@ -72,32 +72,32 @@ describe('Channel RHS', () => {
verifyRHSisOpenAndHasTitle('Recent Mentions');
});
it('MM-T5312 - should be able to open saved posts, visit the system console and come back without issues', () => {
// # Click on the saved posts button
it('MM-T5312 - should be able to open saved messages, visit the system console and come back without issues', () => {
// # Click on the saved messages button
cy.uiGetSavedPostButton().click();
// * Verify that the saved posts is opened in RHS
verifyRHSisOpenAndHasTitle('Saved Posts');
// * Verify that the saved messages is opened in RHS
verifyRHSisOpenAndHasTitle('Saved messages');
// # visit the system console and leave it
openSystemConsoleAndLeave();
// * Verify that the saved posts is still opened in RHS
verifyRHSisOpenAndHasTitle('Saved Posts');
// * Verify that the saved messages is still opened in RHS
verifyRHSisOpenAndHasTitle('Saved messages');
});
it('MM-T5313 - should be able to open pinned posts, visit the system console and come back without issues', () => {
// # Click on the pinned posts button
it('MM-T5313 - should be able to open Pinned messages, visit the system console and come back without issues', () => {
// # Click on the Pinned messages button
cy.uiGetChannelPinButton().click();
// * Verify that the pinned posts is opened in RHS
verifyRHSisOpenAndHasTitle('Pinned Posts');
// * Verify that the Pinned messages is opened in RHS
verifyRHSisOpenAndHasTitle('Pinned messages');
// # visit the system console and leave it
openSystemConsoleAndLeave();
// * Verify that the pinned posts is still opened in RHS
verifyRHSisOpenAndHasTitle('Pinned Posts');
// * Verify that the Pinned messages is still opened in RHS
verifyRHSisOpenAndHasTitle('Pinned messages');
});
it('MM-T5314 - should be able to open channel members, visit the system console and come back without issues', () => {

2
e2e-tests/cypress/tests/integration/channels/emoji/custom_emoji_1_spec.ts
Просмотреть файл

@@ -95,7 +95,7 @@ describe('Custom emojis', () => {
cy.findByPlaceholderText('Search emojis').should('be.visible').type(customEmoji, {delay: TIMEOUTS.QUARTER_SEC});
// * Validate that we cannot find the emoji name in the search result list
cy.get('.no-results__title').should('be.visible').and('have.text', 'No results for "' + customEmoji + '"');
cy.get('.no-results__title').should('be.visible').and('have.text', 'No results for “' + customEmoji + '”');
});
it('MM-T2182 Custom emoji - animated gif', () => {

2
e2e-tests/cypress/tests/integration/channels/emoji/custom_emoji_2_spec.ts
Просмотреть файл

@@ -78,7 +78,7 @@ describe('Custom emojis', () => {
cy.findByPlaceholderText('Search emojis').should('be.visible').type(emojiNameForSearch1, {delay: TIMEOUTS.QUARTER_SEC});
// * Get list of emojis based on search text
cy.get('.no-results__title').should('be.visible').and('have.text', 'No results for "' + emojiNameForSearch1 + '"');
cy.get('.no-results__title').should('be.visible').and('have.text', 'No results for “' + emojiNameForSearch1 + '”');
// # Search for an existing emoji
cy.findByPlaceholderText('Search emojis').should('be.visible').clear().type(emojiNameForSearch2, {delay: TIMEOUTS.QUARTER_SEC});

4
e2e-tests/cypress/tests/integration/channels/emoji/custom_emoji_3_spec.ts
Просмотреть файл

@@ -218,7 +218,7 @@ describe('Custom emojis', () => {
cy.findByPlaceholderText('Search emojis').should('be.visible').type(customEmojiWithColons, {delay: TIMEOUTS.HALF_SEC});
// * Get list of emojis based on search text
cy.get('.no-results__title').should('be.visible').and('have.text', 'No results for "' + customEmoji + '"');
cy.get('.no-results__title').should('be.visible').and('have.text', 'No results for “' + customEmoji + '”');
// # Navigate to a channel
cy.visit(townsquareLink);
@@ -302,7 +302,7 @@ describe('Custom emojis', () => {
cy.findByPlaceholderText('Search emojis').should('be.visible').type(customEmojiWithColons, {delay: TIMEOUTS.HALF_SEC});
// * Get list of emojis based on search text
cy.get('.no-results__title').should('be.visible').and('have.text', 'No results for "' + customEmoji + '"');
cy.get('.no-results__title').should('be.visible').and('have.text', 'No results for “' + customEmoji + '”');
// # Navigate to a channel
cy.visit(townsquareLink);

2
e2e-tests/cypress/tests/integration/channels/keyboard_shortcuts/dot_menu_spec.js
Просмотреть файл

@@ -98,7 +98,7 @@ describe('Keyboard Shortcuts', () => {
cy.findByText('Saved').should('not.exist');
// # Save Post
cy.uiPostDropdownMenuShortcut(postId, 'Save', 'S', 'RHS_ROOT');
cy.uiPostDropdownMenuShortcut(postId, 'Save Message', 'S', 'RHS_ROOT');
// * Verify post is Saved
cy.get(`#post_${postId}`).find('.post-pre-header').should('be.visible').and('have.text', 'Saved');

2
e2e-tests/cypress/tests/integration/channels/keyboard_shortcuts/esc_close_modal_spec.js
Просмотреть файл

@@ -30,7 +30,7 @@ describe('Keyboard Shortcuts', () => {
cy.get('#quickSwitchInput').typeWithForce(searchTerm);
// * Verify that the no search result test is displayed
cy.get('.no-results__title').should('be.visible').and('have.text', 'No results for "' + searchTerm + '"');
cy.get('.no-results__title').should('be.visible').and('have.text', 'No results for “' + searchTerm + '”');
// # Press escape key
cy.get('#quickSwitchInput').typeWithForce('{esc}');

2
e2e-tests/cypress/tests/integration/channels/messaging/pinned_posts_1_spec.js
Просмотреть файл

@@ -40,7 +40,7 @@ describe('Messaging', () => {
cy.uiGetChannelPinButton().click();
// * RHS title displays as "Pinned Posts" and "[channel name]"
cy.get('#sidebar-right').should('be.visible').and('contain', 'Pinned Posts').and('contain', `${testChannel.display_name}`);
cy.get('#sidebar-right').should('be.visible').and('contain', 'Pinned messages').and('contain', `${testChannel.display_name}`);
// * Pinned post appear in RHS
cy.get(`#rhsPostMessageText_${postId}`).should('exist');

36
e2e-tests/cypress/tests/integration/channels/messaging/pinned_posts_2_spec.js
Просмотреть файл

@@ -12,7 +12,7 @@
import {getAdminAccount} from '../../../support/env';
describe('Pinned posts', () => {
describe('pinned messages', () => {
let testTeam;
let testChannel;
let testUser;
@@ -62,12 +62,12 @@ describe('Pinned posts', () => {
// # Click pin icon
cy.uiGetChannelPinButton().click();
// * Should not have any pinned posts
cy.get('#search-items-container .no-results__title').should('have.text', 'No pinned posts yet');
// * Should not have any pinned messages
cy.get('#search-items-container .no-results__title').should('have.text', 'No pinned messages yet');
});
});
it('MM-T2174 Switching channels in center also changes pinned posts RHS', () => {
it('MM-T2174 Switching channels in center also changes pinned messages RHS', () => {
// # Login
cy.apiLogin(testUser);
@@ -81,16 +81,16 @@ describe('Pinned posts', () => {
// # Click pin icon
cy.uiGetChannelPinButton().click();
// * Number of pinned posts in RHS should be 1
// * Number of pinned messages in RHS should be 1
cy.findByTestId('search-item-container').should('have.length', 1);
// # Go to town square
cy.get('#sidebarItem_town-square').should('be.visible').click();
// * Should not have any pinned posts
cy.get('#search-items-container .no-results__title').should('have.text', 'No pinned posts yet');
// * Should not have any pinned messages
cy.get('#search-items-container .no-results__title').should('have.text', 'No pinned messages yet');
// * Number of pinned posts in RHS should be 0
// * Number of pinned messages in RHS should be 0
cy.findByTestId('search-item-container').should('not.exist');
// # Visit a test channel
@@ -117,7 +117,7 @@ describe('Pinned posts', () => {
return cy.getLastPostId();
}).then((postId) => {
// * Number of pinned posts in RHS should be 0
// * Number of pinned messages in RHS should be 0
cy.findByTestId('search-item-container').should('not.exist');
// # Pin the post
@@ -131,7 +131,7 @@ describe('Pinned posts', () => {
});
});
it('MM-T2177 Deleting pinned post while viewing RHS pinned posts removes post from RHS', () => {
it('MM-T2177 Deleting pinned post while viewing RHS pinned messages removes post from RHS', () => {
// # Login
cy.apiLogin(testUser);
@@ -141,8 +141,8 @@ describe('Pinned posts', () => {
// # Click pin icon
cy.uiGetChannelPinButton().click();
// * Should not have any pinned posts
cy.get('#search-items-container .no-results__title').should('have.text', 'No pinned posts yet');
// * Should not have any pinned messages
cy.get('#search-items-container .no-results__title').should('have.text', 'No pinned messages yet');
// # Post a message
cy.postMessage('Hello again');
@@ -162,8 +162,8 @@ describe('Pinned posts', () => {
cy.get(`#delete_post_${postId}`).scrollIntoView().should('be.visible').click();
cy.get('#deletePostModalButton').should('be.visible').click();
// * Should not have any pinned posts
cy.get('#search-items-container .no-results__title').should('have.text', 'No pinned posts yet');
// * Should not have any pinned messages
cy.get('#search-items-container .no-results__title').should('have.text', 'No pinned messages yet');
// * Post should be deleted
cy.get(`#post_${postId}`).should('not.exist');
@@ -200,15 +200,15 @@ describe('Pinned posts', () => {
// # Click pin icon
cy.uiGetChannelPinButton().click();
// * Should not have any pinned posts
cy.get('#search-items-container .no-results__title').should('have.text', 'No pinned posts yet');
// * Should not have any pinned messages
cy.get('#search-items-container .no-results__title').should('have.text', 'No pinned messages yet');
// * The old post should be gone
cy.get(`#post_${postId}`).should('not.exist');
});
});
it('MM-T2922 Pinned post count indicates the number of pinned posts in currently viewed channel', () => {
it('MM-T2922 Pinned post count indicates the number of pinned messages in currently viewed channel', () => {
// # Login
cy.apiLogin(testUser);
@@ -274,7 +274,7 @@ describe('Pinned posts', () => {
// * Pinned count should be 1
cy.get('#channelPinnedPostCountText').should('have.text', '1');
// * Number of pinned posts in RHS should also be 1
// * Number of pinned messages in RHS should also be 1
cy.findByTestId('search-item-container').should('have.length', 1);
});
});

2
e2e-tests/cypress/tests/integration/channels/messaging/post_options_menu_spec.js
Просмотреть файл

@@ -52,7 +52,7 @@ describe('Messaging', () => {
cy.findByText('Add Reaction').should('be.visible');
cy.findByText('Mark as Unread').should('be.visible');
cy.findByText('Copy Link').should('be.visible');
cy.findByText('Save').should('be.visible');
cy.findByText('Save Message').should('be.visible');
cy.findByText('Pin to Channel').should('be.visible');
cy.findByText('Edit').should('be.visible');
cy.findByText('Delete').should('be.visible');

2
e2e-tests/cypress/tests/integration/channels/messaging/post_pre_header_spec.js
Просмотреть файл

@@ -104,7 +104,7 @@ describe('Post PreHeader', () => {
cy.get('#searchContainer').should('be.visible').within(() => {
cy.get('.sidebar--right__title').
should('be.visible').
and('contain', 'Pinned Posts').
and('contain', 'Pinned messages').
and('contain', 'Off-Topic');
// * Check that the post pre-header is not shown for the pinned message in RHS

2
e2e-tests/cypress/tests/integration/channels/messaging/private_channel_open_spec.js
Просмотреть файл

@@ -35,7 +35,7 @@ describe('Messaging - Opening a private channel using keyboard shortcuts', () =>
cy.findByRole('textbox', {name: 'quick switch input'}).type('Pr').type('{downarrow}').type('{enter}');
// * Private channel opens
cy.get('#channelHeaderTitle').should('be.visible').should('contain', 'Private channel').wait(TIMEOUTS.HALF_SEC);
cy.get('#channelHeaderTitle').should('be.visible').should('contain', 'Private').wait(TIMEOUTS.HALF_SEC);
// * Focus in the message box
cy.uiGetPostTextBox().should('be.focused');

2
e2e-tests/cypress/tests/integration/channels/messaging/save_post_spec.js
Просмотреть файл

@@ -33,7 +33,7 @@ describe('Save Post', () => {
cy.get('@postId1').then((postId) => {
// # Save message by clicking the menu item in the dotmenu
cy.uiClickPostDropdownMenu(postId, 'Save');
cy.uiClickPostDropdownMenu(postId, 'Save Message');
// * Assert the post pre-header is displayed and works as expected
verifySavedPost(postId, message);

4
e2e-tests/cypress/tests/integration/channels/search/clear_input_spec.js
Просмотреть файл

@@ -56,12 +56,12 @@ describe('Search', () => {
cy.uiGetChannelPinButton().click();
// * Verify the pinned post RHS is open
cy.uiGetRHS().should('contain', 'Pinned Posts');
cy.uiGetRHS().should('contain', 'Pinned messages');
// # Now click on the saved post button from the header
cy.uiGetSavedPostButton().click();
// * Verify the pinned post RHS is open
cy.uiGetRHS().should('contain', 'Saved posts');
cy.uiGetRHS().should('contain', 'Saved messages');
});
});

4
e2e-tests/cypress/tests/integration/channels/search/cleared_search_term_spec.js
Просмотреть файл

@@ -45,9 +45,9 @@ describe('Search', () => {
// # Verify that the cleared search text does not appear on the search box
cy.uiGetSearchBox().should('be.empty');
// # Click the pin icon to open the pinned posts RHS
// # Click the pin icon to open the pinned messages RHS
cy.uiGetChannelPinButton().click();
cy.uiGetRHS().should('contain', 'Pinned Posts');
cy.uiGetRHS().should('contain', 'Pinned messages');
// # Verify that the Search term input box is still cleared and search term does not reappear when RHS opens
cy.uiGetSearchBox().and('be.empty');

2
e2e-tests/cypress/tests/integration/channels/search_filter/helpers.js
Просмотреть файл

@@ -34,7 +34,7 @@ export function searchAndValidate(query, expectedResults = []) {
});
} else {
// * If we expect no results, verify results message
cy.get('.no-results__title').should('be.visible').and('have.text', `No results for "${query}"`);
cy.get('.no-results__title').should('be.visible').and('have.text', `No results for “${query}”`);
}
});

2
e2e-tests/cypress/tests/integration/channels/search_filter/negative_spec.js
Просмотреть файл

@@ -86,7 +86,7 @@ function searchAndVerify(query, expectedMessage) {
search(`-${query}`);
// * If we expect no results, verify results message
cy.get('.no-results__title').should('be.visible').and('have.text', `No results for "-${query}"`);
cy.get('.no-results__title').should('be.visible').and('have.text', `No results for “-${query}”`);
cy.uiCloseRHS();
cy.uiGetRHSSearchContainer({visible: false});

6
e2e-tests/cypress/tests/integration/playbooks/channels/rhs_spec.js
Просмотреть файл

@@ -81,7 +81,7 @@ describe('channels > rhs', {testIsolation: true}, () => {
if ($body.find('#channelHeaderFlagButton').length > 0) {
cy.get('#channelHeaderFlagButton').click({force: true});
} else {
cy.findByRole('button', {name: 'Saved posts'}).
cy.findByRole('button', {name: 'Saved messages'}).
click({force: true});
}
});
@@ -346,11 +346,11 @@ describe('channels > rhs', {testIsolation: true}, () => {
cy.get('#post-create').should('exist');
// # Open the saved posts RHS
cy.findByRole('button', {name: 'Saved posts'}).
cy.findByRole('button', {name: 'Saved messages'}).
click({force: true});
// * Verify Saved Posts is open
cy.get('.sidebar--right__title').should('contain.text', 'Saved Posts');
cy.get('.sidebar--right__title').should('contain.text', 'Saved messages');
// # Start a playbook run with a slash command
const now = Date.now();

2
e2e-tests/cypress/tests/support/ui/global_header.js
Просмотреть файл

@@ -115,7 +115,7 @@ Cypress.Commands.add('uiGetRecentMentionButton', () => {
});
Cypress.Commands.add('uiGetSavedPostButton', () => {
return cy.findByRole('button', {name: 'Saved posts'}).should('be.visible');
return cy.findByRole('button', {name: 'Saved messages'}).should('be.visible');
});
Cypress.Commands.add('uiGetSettingsButton', () => {

8
e2e-tests/cypress/tests/support/ui/post.ts
Просмотреть файл

@@ -111,7 +111,7 @@ export function verifySavedPost(postId, message) {
cy.get('#searchContainer').should('be.visible').within(() => {
cy.get('.sidebar--right__title').
should('be.visible').
and('have.text', 'Saved Posts');
and('have.text', 'Saved messages');
// * Check that the post pre-header is not shown for the saved message in RHS
cy.get(`#searchResult_${postId}`).within(() => {
@@ -129,14 +129,14 @@ export function verifyUnsavedPost(postId) {
cy.get(`#post_${postId}`).trigger('mouseover', {force: true});
cy.get(`#CENTER_flagIcon_${postId}`).
should('have.class', 'post-menu__item').
and('have.attr', 'aria-label', 'save');
and('have.attr', 'aria-label', 'save message');
// # Open the post-dotmenu
cy.clickPostDotMenu(postId, 'CENTER');
// * Check that the dotmenu item is changed accordingly
cy.findAllByTestId(`post-menu-${postId}`).eq(0).should('be.visible');
cy.findByText('Save').scrollIntoView().should('be.visible');
cy.findByText('Save Message').scrollIntoView().should('be.visible');
cy.get(`#CENTER_dropdown_${postId}`).should('be.visible').type('{esc}');
cy.get('#postListContent').within(() => {
@@ -165,7 +165,7 @@ export function verifyUnsavedPost(postId) {
cy.get('#searchContainer').should('be.visible').within(() => {
cy.get('.sidebar--right__title').
should('be.visible').
and('have.text', 'Saved Posts');
and('have.text', 'Saved messages');
// * Check that the post pre-header is not shown for the saved message in RHS
cy.get('#search-items-container').within(() => {