Avoids returning an error if sharing a direct channel fails after its creation (#26895)

* Avoids returning an error if sharing a direct channel fails after its creation

* Update logline to use snake-case

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

server/channels/app/channel.go

@@ -481,7 +481,7 @@ func (a *App) createDirectChannelWithUser(c request.CTX, user, otherUser *model.
 		}
 
 		if _, err := a.ShareChannel(c, sc); err != nil {
-			return nil, model.NewAppError("CreateDirectChannel", "app.sharedchannel.dm_channel_creation.internal_error", nil, "", http.StatusInternalServerError).Wrap(err)
+			c.Logger().Error("Failed to share newly created direct channel", mlog.String("channel_id", channel.Id), mlog.Err(err))
 		}
 	}
 

server/i18n/en.json

@@ -6478,10 +6478,6 @@
     "id": "app.session.update_device_id.app_error",
     "translation": "Unable to update the device id."
   },
-  {
-    "id": "app.sharedchannel.dm_channel_creation.internal_error",
-    "translation": "Encountered an error while creating a direct shared channel."
-  },
   {
     "id": "app.status.get.app_error",
     "translation": "Encountered an error retrieving the status."