Idiomatic error handling for app/{job,license,login}.go (#9474)

app/license.go

@@ -46,47 +46,45 @@ func (a *App) LoadLicense() {
 }
 
 func (a *App) SaveLicense(licenseBytes []byte) (*model.License, *model.AppError) {
-	var license *model.License
-
-	if success, licenseStr := utils.ValidateLicense(licenseBytes); success {
-		license = model.LicenseFromJson(strings.NewReader(licenseStr))
-
-		if result := <-a.Srv.Store.User().AnalyticsUniqueUserCount(""); result.Err != nil {
-			return nil, model.NewAppError("addLicense", "api.license.add_license.invalid_count.app_error", nil, result.Err.Error(), http.StatusBadRequest)
-		} else {
-			uniqueUserCount := result.Data.(int64)
-
-			if uniqueUserCount > int64(*license.Features.Users) {
-				return nil, model.NewAppError("addLicense", "api.license.add_license.unique_users.app_error", map[string]interface{}{"Users": *license.Features.Users, "Count": uniqueUserCount}, "", http.StatusBadRequest)
-			}
-		}
-
-		if ok := a.SetLicense(license); !ok {
-			return nil, model.NewAppError("addLicense", model.EXPIRED_LICENSE_ERROR, nil, "", http.StatusBadRequest)
-		}
-
-		record := &model.LicenseRecord{}
-		record.Id = license.Id
-		record.Bytes = string(licenseBytes)
-		rchan := a.Srv.Store.License().Save(record)
-
-		if result := <-rchan; result.Err != nil {
-			a.RemoveLicense()
-			return nil, model.NewAppError("addLicense", "api.license.add_license.save.app_error", nil, "err="+result.Err.Error(), http.StatusInternalServerError)
-		}
-
-		sysVar := &model.System{}
-		sysVar.Name = model.SYSTEM_ACTIVE_LICENSE_ID
-		sysVar.Value = license.Id
-		schan := a.Srv.Store.System().SaveOrUpdate(sysVar)
-
-		if result := <-schan; result.Err != nil {
-			a.RemoveLicense()
-			return nil, model.NewAppError("addLicense", "api.license.add_license.save_active.app_error", nil, "", http.StatusInternalServerError)
-		}
-	} else {
+	success, licenseStr := utils.ValidateLicense(licenseBytes)
+	if !success {
 		return nil, model.NewAppError("addLicense", model.INVALID_LICENSE_ERROR, nil, "", http.StatusBadRequest)
 	}
+	license := model.LicenseFromJson(strings.NewReader(licenseStr))
+
+	result := <-a.Srv.Store.User().AnalyticsUniqueUserCount("")
+	if result.Err != nil {
+		return nil, model.NewAppError("addLicense", "api.license.add_license.invalid_count.app_error", nil, result.Err.Error(), http.StatusBadRequest)
+	}
+	uniqueUserCount := result.Data.(int64)
+
+	if uniqueUserCount > int64(*license.Features.Users) {
+		return nil, model.NewAppError("addLicense", "api.license.add_license.unique_users.app_error", map[string]interface{}{"Users": *license.Features.Users, "Count": uniqueUserCount}, "", http.StatusBadRequest)
+	}
+
+	if ok := a.SetLicense(license); !ok {
+		return nil, model.NewAppError("addLicense", model.EXPIRED_LICENSE_ERROR, nil, "", http.StatusBadRequest)
+	}
+
+	record := &model.LicenseRecord{}
+	record.Id = license.Id
+	record.Bytes = string(licenseBytes)
+	rchan := a.Srv.Store.License().Save(record)
+
+	if result := <-rchan; result.Err != nil {
+		a.RemoveLicense()
+		return nil, model.NewAppError("addLicense", "api.license.add_license.save.app_error", nil, "err="+result.Err.Error(), http.StatusInternalServerError)
+	}
+
+	sysVar := &model.System{}
+	sysVar.Name = model.SYSTEM_ACTIVE_LICENSE_ID
+	sysVar.Value = license.Id
+	schan := a.Srv.Store.System().SaveOrUpdate(sysVar)
+
+	if result := <-schan; result.Err != nil {
+		a.RemoveLicense()
+		return nil, model.NewAppError("addLicense", "api.license.add_license.save_active.app_error", nil, "", http.StatusInternalServerError)
+	}
 
 	a.ReloadConfig()
 	a.InvalidateAllCaches()