MM-36764 mlog refactor (#18118)

Refactor mlog
- simplify mlog by removing redundant code
- remove Zap dependency
- update unit test helpers
- update logging config
- update auditing

testlib/assertions.go

@@ -4,14 +4,13 @@
 package testlib
 
 import (
-	"bytes"
 	"encoding/json"
 	"io"
 	"testing"
 )
 
 // AssertLog asserts that a JSON-encoded buffer of logs contains one with the given level and message.
-func AssertLog(t *testing.T, logs *bytes.Buffer, level, message string) {
+func AssertLog(t *testing.T, logs io.Reader, level, message string) {
 	dec := json.NewDecoder(logs)
 	for {
 		var log struct {
@@ -33,7 +32,7 @@ func AssertLog(t *testing.T, logs *bytes.Buffer, level, message string) {
 }
 
 // AssertNoLog asserts that a JSON-encoded buffer of logs does not contains one with the given level and message.
-func AssertNoLog(t *testing.T, logs *bytes.Buffer, level, message string) {
+func AssertNoLog(t *testing.T, logs io.Reader, level, message string) {
 	dec := json.NewDecoder(logs)
 	for {
 		var log struct {

testlib/helper.go

@@ -16,7 +16,6 @@ import (
 
 	"github.com/mattermost/mattermost-server/v6/model"
 	"github.com/mattermost/mattermost-server/v6/services/searchengine"
-	"github.com/mattermost/mattermost-server/v6/shared/mlog"
 	"github.com/mattermost/mattermost-server/v6/store"
 	"github.com/mattermost/mattermost-server/v6/store/searchlayer"
 	"github.com/mattermost/mattermost-server/v6/store/sqlstore"
@@ -53,16 +52,6 @@ func NewMainHelperWithOptions(options *HelperOptions) *MainHelper {
 	var mainHelper MainHelper
 	flag.Parse()
 
-	// Setup a global logger to catch tests logging outside of app context
-	// The global logger will be stomped by apps initializing but that's fine for testing.
-	// Ideally this won't happen.
-	mlog.InitGlobalLogger(mlog.NewLogger(&mlog.LoggerConfiguration{
-		EnableConsole: true,
-		ConsoleJson:   true,
-		ConsoleLevel:  "error",
-		EnableFile:    false,
-	}))
-
 	utils.TranslationsPreInit()
 
 	if options != nil {