[MM-13889] Limit OpenGraph data response size (#10213)
* Limit OpenGraph data response size * Add LimitReader to Metadata Image
Этот коммит содержится в:
коммит произвёл
GitHub
родитель
4e0840969b
Коммит
a2f46c0466
@@ -14,6 +14,8 @@ import (
|
||||
"github.com/mattermost/mattermost-server/mlog"
|
||||
)
|
||||
|
||||
const MaxOpenGraphResponseSize = 1024 * 1024 * 50
|
||||
|
||||
func (a *App) GetOpenGraphMetadata(requestURL string) *opengraph.OpenGraph {
|
||||
res, err := a.HTTPService.MakeClient(false).Get(requestURL)
|
||||
if err != nil {
|
||||
@@ -21,14 +23,12 @@ func (a *App) GetOpenGraphMetadata(requestURL string) *opengraph.OpenGraph {
|
||||
return nil
|
||||
}
|
||||
defer res.Body.Close()
|
||||
|
||||
return a.ParseOpenGraphMetadata(requestURL, res.Body, res.Header.Get("Content-Type"))
|
||||
}
|
||||
|
||||
func (a *App) ParseOpenGraphMetadata(requestURL string, body io.Reader, contentType string) *opengraph.OpenGraph {
|
||||
og := opengraph.NewOpenGraph()
|
||||
|
||||
body = forceHTMLEncodingToUTF8(body, contentType)
|
||||
body = forceHTMLEncodingToUTF8(io.LimitReader(body, MaxOpenGraphResponseSize), contentType)
|
||||
|
||||
if err := og.ProcessHTML(body); err != nil {
|
||||
mlog.Error("ParseOpenGraphMetadata processing failed", mlog.String("requestURL", requestURL), mlog.Any("err", err))
|
||||
|
||||
Ссылка в новой задаче
Block a user