[MM-34838] Remove Ancillary Permissions That Are Purposefully Being Removed (#17466)

* remove ancillary permissions

* Start writing tests

* Move Ancillary Permissions to FrontEnd

* remove function

* remove test

* clean up

* fix comment

* Update api4/permission.go

Co-authored-by: Martin Kraft <martinkraft@gmail.com>

* Update api4/permission.go

* Update api4/permission.go

* license info

* Add Tests

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Martin Kraft <martinkraft@gmail.com>

api4/permissions_test.go

@@ -0,0 +1,42 @@
+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+package api4
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+
+	"github.com/mattermost/mattermost-server/v5/model"
+)
+
+func TestGetAncillaryPermissions(t *testing.T) {
+	th := Setup(t).InitBasic()
+	defer th.TearDown()
+
+	var subsectionPermissions []string
+	var expectedAncillaryPermissions []string
+	t.Run("Valid Case, Passing in SubSection Permissions", func(t *testing.T) {
+		subsectionPermissions = []string{model.PERMISSION_SYSCONSOLE_READ_REPORTING_SITE_STATISTICS.Id}
+		expectedAncillaryPermissions = []string{model.PERMISSION_GET_ANALYTICS.Id}
+		actualAncillaryPermissions, resp := th.Client.GetAncillaryPermissions(subsectionPermissions)
+		CheckNoError(t, resp)
+		assert.Equal(t, append(subsectionPermissions, expectedAncillaryPermissions...), actualAncillaryPermissions)
+	})
+
+	t.Run("Invalid Case, Passing in SubSection Permissions That Don't Exist", func(t *testing.T) {
+		subsectionPermissions = []string{"All", "The", "Things", "She", "Said", "Running", "Through", "My", "Head"}
+		expectedAncillaryPermissions = []string{}
+		actualAncillaryPermissions, resp := th.Client.GetAncillaryPermissions(subsectionPermissions)
+		CheckNoError(t, resp)
+		assert.Equal(t, append(subsectionPermissions, expectedAncillaryPermissions...), actualAncillaryPermissions)
+	})
+
+	t.Run("Invalid Case, Passing in nothing", func(t *testing.T) {
+		subsectionPermissions = []string{}
+		expectedAncillaryPermissions = []string{}
+		_, resp := th.Client.GetAncillaryPermissions(subsectionPermissions)
+		CheckBadRequestStatus(t, resp)
+	})
+}