Add read_channel_content permission (#24018)

* Add read_channel_content permission

* fix tests

* update system console default permissions per role

* add read_channel_content to e2e defaultRolesPermissions

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

server/public/model/migration.go

@@ -40,5 +40,6 @@ const (
 	MigrationKeyAddPlayboosksManageRolesPermissions    = "playbooks_manage_roles"
 	MigrationKeyAddProductsBoardsPermissions           = "products_boards"
 	MigrationKeyAddCustomUserGroupsPermissionRestore   = "custom_groups_permission_restore"
+	MigrationKeyAddReadChannelContentPermissions       = "read_channel_content_permissions"
 	MigrationKeyElasticsearchFixChannelIndex           = "elasticsearch_fix_channel_index_migration"
 )

server/public/model/permission.go

@@ -51,6 +51,7 @@ var PermissionDeletePublicChannel *Permission
 var PermissionDeletePrivateChannel *Permission
 var PermissionEditOtherUsers *Permission
 var PermissionReadChannel *Permission
+var PermissionReadChannelContent *Permission
 var PermissionReadPublicChannelGroups *Permission
 var PermissionReadPrivateChannelGroups *Permission
 var PermissionReadPublicChannel *Permission
@@ -561,6 +562,12 @@ func initializePermissions() {
 		"authentication.permissions.read_channel.description",
 		PermissionScopeChannel,
 	}
+	PermissionReadChannelContent = &Permission{
+		"read_channel_content",
+		"authentication.permissions.read_channel_content.name",
+		"authentication.permissions.read_channel_content.description",
+		PermissionScopeChannel,
+	}
 	PermissionReadPublicChannelGroups = &Permission{
 		"read_public_channel_groups",
 		"authentication.permissions.read_public_channel_groups.name",
@@ -2329,6 +2336,7 @@ func initializePermissions() {
 		PermissionDeletePublicChannel,
 		PermissionDeletePrivateChannel,
 		PermissionReadChannel,
+		PermissionReadChannelContent,
 		PermissionReadPublicChannelGroups,
 		PermissionReadPrivateChannelGroups,
 		PermissionAddReaction,

server/public/model/role.go

@@ -749,6 +749,7 @@ func MakeDefaultRoles() map[string]*Role {
 		Description: "authentication.roles.channel_guest.description",
 		Permissions: []string{
 			PermissionReadChannel.Id,
+			PermissionReadChannelContent.Id,
 			PermissionAddReaction.Id,
 			PermissionRemoveReaction.Id,
 			PermissionUploadFile.Id,
@@ -766,6 +767,7 @@ func MakeDefaultRoles() map[string]*Role {
 		Description: "authentication.roles.channel_user.description",
 		Permissions: []string{
 			PermissionReadChannel.Id,
+			PermissionReadChannelContent.Id,
 			PermissionAddReaction.Id,
 			PermissionRemoveReaction.Id,
 			PermissionManagePublicChannelMembers.Id,