From 9d6adbfea29850d030b1ad646286a84119bf3020 Mon Sep 17 00:00:00 2001 From: Rohan Sharma <117426013+RS-labhub@users.noreply.github.com> Date: Tue, 8 Oct 2024 14:16:22 +0530 Subject: [PATCH] fix: role errcheck issues (#28544) Co-authored-by: Ben Schumacher --- server/.golangci.yml | 1 - server/channels/api4/role.go | 10 ++++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index 23822c8525..810c42cdd6 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -91,7 +91,6 @@ issues: channels/api4/preference_test.go|\ channels/api4/reaction_test.go|\ channels/api4/remote_cluster.go|\ - channels/api4/role.go|\ channels/api4/role_test.go|\ channels/api4/saml.go|\ channels/api4/scheme.go|\ diff --git a/server/channels/api4/role.go b/server/channels/api4/role.go index f2193fcd0f..a4009a902e 100644 --- a/server/channels/api4/role.go +++ b/server/channels/api4/role.go @@ -47,7 +47,10 @@ func getAllRoles(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(js) + if _, err := w.Write(js); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + return + } } func getRole(c *Context, w http.ResponseWriter, r *http.Request) { @@ -119,7 +122,10 @@ func getRolesByNames(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(js) + if _, err := w.Write(js); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + return + } } func patchRole(c *Context, w http.ResponseWriter, r *http.Request) {