From 9c4ce9016ff4627341472ad54c894c84203c8d62 Mon Sep 17 00:00:00 2001 From: Conor Macpherson Date: Tue, 20 Dec 2022 09:18:20 -0500 Subject: [PATCH] Fix error check placement. --- api4/license.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/api4/license.go b/api4/license.go index 6240be1190..9233e3751f 100644 --- a/api4/license.go +++ b/api4/license.go @@ -403,16 +403,15 @@ func requestTrueUpReview(c *Context, w http.ResponseWriter, r *http.Request) { // Convert true up review profile struct to map var telemetryProperties map[string]interface{} reviewProfileJson, err := json.Marshal(reviewProfile) - json.Unmarshal(reviewProfileJson, &telemetryProperties) - - // Send telemetry data. - telemetryService := c.App.Srv().GetTelemetryService() - telemetryService.SendTelemetry(model.TrueUpReviewTelemetryName, telemetryProperties) - if err != nil { http.Error(w, err.Error(), http.StatusInternalServerError) return } + // Send telemetry data. + json.Unmarshal(reviewProfileJson, &telemetryProperties) + telemetryService := c.App.Srv().GetTelemetryService() + telemetryService.SendTelemetry(model.TrueUpReviewTelemetryName, telemetryProperties) + ReturnStatusOK(w) }