[MM-16751] golint model (#17896)
Этот коммит содержится в:
Ben Schumacher
коммит произвёл
Claudio Costa
Claudio Costa
родитель
953eebdef4
Коммит
97ccf0bdf6
@@ -180,7 +180,7 @@ func TestPluginAPIGetUserPreferences(t *testing.T) {
|
||||
assert.Equal(t, 1, len(preferences))
|
||||
|
||||
assert.Equal(t, user1.Id, preferences[0].UserId)
|
||||
assert.Equal(t, model.PREFERENCE_CATEGORY_TUTORIAL_STEPS, preferences[0].Category)
|
||||
assert.Equal(t, model.PreferenceCategoryTutorialSteps, preferences[0].Category)
|
||||
assert.Equal(t, user1.Id, preferences[0].Name)
|
||||
assert.Equal(t, "0", preferences[0].Value)
|
||||
}
|
||||
@@ -219,7 +219,7 @@ func TestPluginAPIDeleteUserPreferences(t *testing.T) {
|
||||
preference := model.Preference{
|
||||
Name: user2.Id,
|
||||
UserId: user2.Id,
|
||||
Category: model.PREFERENCE_CATEGORY_THEME,
|
||||
Category: model.PreferenceCategoryTheme,
|
||||
Value: `{"color": "#ff0000", "color2": "#faf"}`,
|
||||
}
|
||||
err = api.UpdatePreferencesForUser(user2.Id, []model.Preference{preference})
|
||||
@@ -234,7 +234,7 @@ func TestPluginAPIDeleteUserPreferences(t *testing.T) {
|
||||
preferences, err = api.GetPreferencesForUser(user2.Id)
|
||||
require.Nil(t, err)
|
||||
assert.Equal(t, 1, len(preferences))
|
||||
assert.Equal(t, model.PREFERENCE_CATEGORY_TUTORIAL_STEPS, preferences[0].Category)
|
||||
assert.Equal(t, model.PreferenceCategoryTutorialSteps, preferences[0].Category)
|
||||
}
|
||||
|
||||
func TestPluginAPIUpdateUserPreferences(t *testing.T) {
|
||||
@@ -254,14 +254,14 @@ func TestPluginAPIUpdateUserPreferences(t *testing.T) {
|
||||
require.Nil(t, err)
|
||||
assert.Equal(t, 1, len(preferences))
|
||||
assert.Equal(t, user1.Id, preferences[0].UserId)
|
||||
assert.Equal(t, model.PREFERENCE_CATEGORY_TUTORIAL_STEPS, preferences[0].Category)
|
||||
assert.Equal(t, model.PreferenceCategoryTutorialSteps, preferences[0].Category)
|
||||
assert.Equal(t, user1.Id, preferences[0].Name)
|
||||
assert.Equal(t, "0", preferences[0].Value)
|
||||
|
||||
preference := model.Preference{
|
||||
Name: user1.Id,
|
||||
UserId: user1.Id,
|
||||
Category: model.PREFERENCE_CATEGORY_THEME,
|
||||
Category: model.PreferenceCategoryTheme,
|
||||
Value: `{"color": "#ff0000", "color2": "#faf"}`,
|
||||
}
|
||||
|
||||
@@ -272,12 +272,12 @@ func TestPluginAPIUpdateUserPreferences(t *testing.T) {
|
||||
require.Nil(t, err)
|
||||
|
||||
assert.Equal(t, 2, len(preferences))
|
||||
expectedCategories := []string{model.PREFERENCE_CATEGORY_TUTORIAL_STEPS, model.PREFERENCE_CATEGORY_THEME}
|
||||
expectedCategories := []string{model.PreferenceCategoryTutorialSteps, model.PreferenceCategoryTheme}
|
||||
for _, pref := range preferences {
|
||||
assert.Contains(t, expectedCategories, pref.Category)
|
||||
assert.Equal(t, user1.Id, pref.UserId)
|
||||
assert.Equal(t, user1.Id, pref.Name)
|
||||
if pref.Category == model.PREFERENCE_CATEGORY_TUTORIAL_STEPS {
|
||||
if pref.Category == model.PreferenceCategoryTutorialSteps {
|
||||
assert.Equal(t, "0", pref.Value)
|
||||
} else {
|
||||
newTheme, _ := json.Marshal(map[string]string{"color": "#ff0000", "color2": "#faf"})
|
||||
@@ -586,7 +586,7 @@ func TestPluginAPIGetFileInfos(t *testing.T) {
|
||||
t.Run("get file infos filtered by channel ordered by created at descending", func(t *testing.T) {
|
||||
fileInfos, err := api.GetFileInfos(0, 5, &model.GetFileInfosOptions{
|
||||
ChannelIds: []string{th.BasicChannel.Id},
|
||||
SortBy: model.FILEINFO_SORT_BY_CREATED,
|
||||
SortBy: model.FileinfoSortByCreated,
|
||||
SortDescending: true,
|
||||
})
|
||||
require.Nil(t, err)
|
||||
@@ -1316,33 +1316,33 @@ func TestPluginAPIGetConfig(t *testing.T) {
|
||||
|
||||
config := api.GetConfig()
|
||||
if config.LdapSettings.BindPassword != nil && *config.LdapSettings.BindPassword != "" {
|
||||
assert.Equal(t, *config.LdapSettings.BindPassword, model.FAKE_SETTING)
|
||||
assert.Equal(t, *config.LdapSettings.BindPassword, model.FakeSetting)
|
||||
}
|
||||
|
||||
assert.Equal(t, *config.FileSettings.PublicLinkSalt, model.FAKE_SETTING)
|
||||
assert.Equal(t, *config.FileSettings.PublicLinkSalt, model.FakeSetting)
|
||||
|
||||
if *config.FileSettings.AmazonS3SecretAccessKey != "" {
|
||||
assert.Equal(t, *config.FileSettings.AmazonS3SecretAccessKey, model.FAKE_SETTING)
|
||||
assert.Equal(t, *config.FileSettings.AmazonS3SecretAccessKey, model.FakeSetting)
|
||||
}
|
||||
|
||||
if config.EmailSettings.SMTPPassword != nil && *config.EmailSettings.SMTPPassword != "" {
|
||||
assert.Equal(t, *config.EmailSettings.SMTPPassword, model.FAKE_SETTING)
|
||||
assert.Equal(t, *config.EmailSettings.SMTPPassword, model.FakeSetting)
|
||||
}
|
||||
|
||||
if *config.GitLabSettings.Secret != "" {
|
||||
assert.Equal(t, *config.GitLabSettings.Secret, model.FAKE_SETTING)
|
||||
assert.Equal(t, *config.GitLabSettings.Secret, model.FakeSetting)
|
||||
}
|
||||
|
||||
assert.Equal(t, *config.SqlSettings.DataSource, model.FAKE_SETTING)
|
||||
assert.Equal(t, *config.SqlSettings.AtRestEncryptKey, model.FAKE_SETTING)
|
||||
assert.Equal(t, *config.ElasticsearchSettings.Password, model.FAKE_SETTING)
|
||||
assert.Equal(t, *config.SqlSettings.DataSource, model.FakeSetting)
|
||||
assert.Equal(t, *config.SqlSettings.AtRestEncryptKey, model.FakeSetting)
|
||||
assert.Equal(t, *config.ElasticsearchSettings.Password, model.FakeSetting)
|
||||
|
||||
for i := range config.SqlSettings.DataSourceReplicas {
|
||||
assert.Equal(t, config.SqlSettings.DataSourceReplicas[i], model.FAKE_SETTING)
|
||||
assert.Equal(t, config.SqlSettings.DataSourceReplicas[i], model.FakeSetting)
|
||||
}
|
||||
|
||||
for i := range config.SqlSettings.DataSourceSearchReplicas {
|
||||
assert.Equal(t, config.SqlSettings.DataSourceSearchReplicas[i], model.FAKE_SETTING)
|
||||
assert.Equal(t, config.SqlSettings.DataSourceSearchReplicas[i], model.FakeSetting)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1353,33 +1353,33 @@ func TestPluginAPIGetUnsanitizedConfig(t *testing.T) {
|
||||
|
||||
config := api.GetUnsanitizedConfig()
|
||||
if config.LdapSettings.BindPassword != nil && *config.LdapSettings.BindPassword != "" {
|
||||
assert.NotEqual(t, *config.LdapSettings.BindPassword, model.FAKE_SETTING)
|
||||
assert.NotEqual(t, *config.LdapSettings.BindPassword, model.FakeSetting)
|
||||
}
|
||||
|
||||
assert.NotEqual(t, *config.FileSettings.PublicLinkSalt, model.FAKE_SETTING)
|
||||
assert.NotEqual(t, *config.FileSettings.PublicLinkSalt, model.FakeSetting)
|
||||
|
||||
if *config.FileSettings.AmazonS3SecretAccessKey != "" {
|
||||
assert.NotEqual(t, *config.FileSettings.AmazonS3SecretAccessKey, model.FAKE_SETTING)
|
||||
assert.NotEqual(t, *config.FileSettings.AmazonS3SecretAccessKey, model.FakeSetting)
|
||||
}
|
||||
|
||||
if config.EmailSettings.SMTPPassword != nil && *config.EmailSettings.SMTPPassword != "" {
|
||||
assert.NotEqual(t, *config.EmailSettings.SMTPPassword, model.FAKE_SETTING)
|
||||
assert.NotEqual(t, *config.EmailSettings.SMTPPassword, model.FakeSetting)
|
||||
}
|
||||
|
||||
if *config.GitLabSettings.Secret != "" {
|
||||
assert.NotEqual(t, *config.GitLabSettings.Secret, model.FAKE_SETTING)
|
||||
assert.NotEqual(t, *config.GitLabSettings.Secret, model.FakeSetting)
|
||||
}
|
||||
|
||||
assert.NotEqual(t, *config.SqlSettings.DataSource, model.FAKE_SETTING)
|
||||
assert.NotEqual(t, *config.SqlSettings.AtRestEncryptKey, model.FAKE_SETTING)
|
||||
assert.NotEqual(t, *config.ElasticsearchSettings.Password, model.FAKE_SETTING)
|
||||
assert.NotEqual(t, *config.SqlSettings.DataSource, model.FakeSetting)
|
||||
assert.NotEqual(t, *config.SqlSettings.AtRestEncryptKey, model.FakeSetting)
|
||||
assert.NotEqual(t, *config.ElasticsearchSettings.Password, model.FakeSetting)
|
||||
|
||||
for i := range config.SqlSettings.DataSourceReplicas {
|
||||
assert.NotEqual(t, config.SqlSettings.DataSourceReplicas[i], model.FAKE_SETTING)
|
||||
assert.NotEqual(t, config.SqlSettings.DataSourceReplicas[i], model.FakeSetting)
|
||||
}
|
||||
|
||||
for i := range config.SqlSettings.DataSourceSearchReplicas {
|
||||
assert.NotEqual(t, config.SqlSettings.DataSourceSearchReplicas[i], model.FAKE_SETTING)
|
||||
assert.NotEqual(t, config.SqlSettings.DataSourceSearchReplicas[i], model.FakeSetting)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1712,7 +1712,7 @@ func TestPluginHTTPUpgradeWebSocket(t *testing.T) {
|
||||
defer wsc.Close()
|
||||
|
||||
resp := <-wsc.ResponseChannel
|
||||
require.Equal(t, resp.Status, model.STATUS_OK)
|
||||
require.Equal(t, resp.Status, model.StatusOk)
|
||||
|
||||
for i := 0; i < 10; i++ {
|
||||
wsc.SendMessage("custom_action", map[string]interface{}{"value": i})
|
||||
@@ -1722,7 +1722,7 @@ func TestPluginHTTPUpgradeWebSocket(t *testing.T) {
|
||||
case <-time.After(1 * time.Second):
|
||||
}
|
||||
require.NotNil(t, resp)
|
||||
require.Equal(t, resp.Status, model.STATUS_OK)
|
||||
require.Equal(t, resp.Status, model.StatusOk)
|
||||
require.Equal(t, "custom_action", resp.Data["action"])
|
||||
require.Equal(t, float64(i), resp.Data["value"])
|
||||
}
|
||||
@@ -1750,7 +1750,7 @@ func (mscp *MockSlashCommandProvider) DoCommand(a *App, c *request.Context, args
|
||||
mscp.Message = message
|
||||
return &model.CommandResponse{
|
||||
Text: "mock",
|
||||
ResponseType: model.COMMAND_RESPONSE_TYPE_EPHEMERAL,
|
||||
ResponseType: model.CommandResponseTypeEphemeral,
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Ссылка в новой задаче
Block a user