From 97496d4e291b2c6e0ef133f0562918e4ce27c87d Mon Sep 17 00:00:00 2001 From: Marc Argent Date: Fri, 11 Oct 2019 18:54:04 +0100 Subject: [PATCH] Migrate tests from model/search_params_test.go to use testify (#12650) --- model/search_params_test.go | 134 +++++++++++++++++++++--------------- 1 file changed, 80 insertions(+), 54 deletions(-) diff --git a/model/search_params_test.go b/model/search_params_test.go index df9386a39b..056a5c9b68 100644 --- a/model/search_params_test.go +++ b/model/search_params_test.go @@ -12,77 +12,103 @@ import ( ) func TestSplitWords(t *testing.T) { - if words := splitWords(""); len(words) != 0 { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words := splitWords("") + require.Equal(t, 0, len(words)) - if words := splitWords(" "); len(words) != 0 { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords(" ") + require.Equal(t, 0, len(words)) - if words := splitWords("word"); len(words) != 1 || words[0] != "word" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("word") + require.Equal(t, 1, len(words)) + require.Equal(t, "word", words[0]) - if words := splitWords("wo\"rd"); len(words) != 2 || words[0] != "wo" || words[1] != "\"rd" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("wo\"rd") + require.Equal(t, 2, len(words)) + require.Equal(t, "wo", words[0]) + require.Equal(t, "\"rd", words[1]) - if words := splitWords("wo\"rd\""); len(words) != 2 || words[0] != "wo" || words[1] != "\"rd\"" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("wo\"rd\"") + require.Equal(t, 2, len(words)) + require.Equal(t, "wo", words[0]) + require.Equal(t, "\"rd\"", words[1]) - if words := splitWords("wo-\"rd\""); len(words) != 2 || words[0] != "wo" || words[1] != "-\"rd\"" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("wo-\"rd\"") + require.Equal(t, 2, len(words)) + require.Equal(t, "wo", words[0]) + require.Equal(t, "-\"rd\"", words[1]) - if words := splitWords("word1 word2 word3"); len(words) != 3 || words[0] != "word1" || words[1] != "word2" || words[2] != "word3" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("word1 word2 word3") + require.Equal(t, 3, len(words)) + require.Equal(t, "word1", words[0]) + require.Equal(t, "word2", words[1]) + require.Equal(t, "word3", words[2]) - if words := splitWords("word1 \"word2 word3"); len(words) != 3 || words[0] != "word1" || words[1] != "\"word2" || words[2] != "word3" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("word1 \"word2 word3") + require.Equal(t, 3, len(words)) + require.Equal(t, "word1", words[0]) + require.Equal(t, "\"word2", words[1]) + require.Equal(t, "word3", words[2]) - if words := splitWords("\"word1 word2 word3"); len(words) != 3 || words[0] != "\"word1" || words[1] != "word2" || words[2] != "word3" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("\"word1 word2 word3") + require.Equal(t, 3, len(words)) + require.Equal(t, "\"word1", words[0]) + require.Equal(t, "word2", words[1]) + require.Equal(t, "word3", words[2]) - if words := splitWords("word1 word2 word3\""); len(words) != 4 || words[0] != "word1" || words[1] != "word2" || words[2] != "word3" || words[3] != "\"" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("word1 word2 word3\"") + require.Equal(t, 4, len(words)) + require.Equal(t, "word1", words[0]) + require.Equal(t, "word2", words[1]) + require.Equal(t, "word3", words[2]) + require.Equal(t, "\"", words[3]) - if words := splitWords("word1 #word2 ##word3"); len(words) != 3 || words[0] != "word1" || words[1] != "#word2" || words[2] != "##word3" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("word1 #word2 ##word3") + require.Equal(t, 3, len(words)) + require.Equal(t, "word1", words[0]) + require.Equal(t, "#word2", words[1]) + require.Equal(t, "##word3", words[2]) - if words := splitWords(" word1 word2 word3 "); len(words) != 3 || words[0] != "word1" || words[1] != "word2" || words[2] != "word3" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords(" word1 word2 word3 ") + require.Equal(t, 3, len(words)) + require.Equal(t, "word1", words[0]) + require.Equal(t, "word2", words[1]) + require.Equal(t, "word3", words[2]) - if words := splitWords("\"quoted\""); len(words) != 1 || words[0] != "\"quoted\"" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("\"quoted\"") + require.Equal(t, 1, len(words)) + require.Equal(t, "\"quoted\"", words[0]) - if words := splitWords("-\"quoted\""); len(words) != 1 || words[0] != "-\"quoted\"" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("-\"quoted\"") + require.Equal(t, 1, len(words)) + require.Equal(t, "-\"quoted\"", words[0]) - if words := splitWords("\"quoted multiple words\""); len(words) != 1 || words[0] != "\"quoted multiple words\"" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("\"quoted multiple words\"") + require.Equal(t, 1, len(words)) + require.Equal(t, "\"quoted multiple words\"", words[0]) - if words := splitWords("some stuff \"quoted multiple words\" more stuff"); len(words) != 5 || words[0] != "some" || words[1] != "stuff" || words[2] != "\"quoted multiple words\"" || words[3] != "more" || words[4] != "stuff" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("some stuff \"quoted multiple words\" more stuff") + require.Equal(t, 5, len(words)) + require.Equal(t, "some", words[0]) + require.Equal(t, "stuff", words[1]) + require.Equal(t, "\"quoted multiple words\"", words[2]) + require.Equal(t, "more", words[3]) + require.Equal(t, "stuff", words[4]) - if words := splitWords("some stuff -\"quoted multiple words\" more stuff"); len(words) != 5 || words[0] != "some" || words[1] != "stuff" || words[2] != "-\"quoted multiple words\"" || words[3] != "more" || words[4] != "stuff" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("some stuff -\"quoted multiple words\" more stuff") + require.Equal(t, 5, len(words)) + require.Equal(t, "some", words[0]) + require.Equal(t, "stuff", words[1]) + require.Equal(t, "-\"quoted multiple words\"", words[2]) + require.Equal(t, "more", words[3]) + require.Equal(t, "stuff", words[4]) - if words := splitWords("some \"stuff\" \"quoted multiple words\" #some \"more stuff\""); len(words) != 5 || words[0] != "some" || words[1] != "\"stuff\"" || words[2] != "\"quoted multiple words\"" || words[3] != "#some" || words[4] != "\"more stuff\"" { - t.Fatalf("Incorrect output splitWords: %v", words) - } + words = splitWords("some \"stuff\" \"quoted multiple words\" #some \"more stuff\"") + require.Equal(t, 5, len(words)) + require.Equal(t, "some", words[0]) + require.Equal(t, "\"stuff\"", words[1]) + require.Equal(t, "\"quoted multiple words\"", words[2]) + require.Equal(t, "#some", words[3]) + require.Equal(t, "\"more stuff\"", words[4]) } func TestParseSearchFlags(t *testing.T) {