fix reaction test (#7978)

api4/reaction_test.go

@@ -7,7 +7,7 @@ import (
 	"strings"
 	"testing"
 
-	"reflect"
+	"github.com/stretchr/testify/assert"
 
 	"github.com/mattermost/mattermost-server/model"
 )
@@ -180,20 +180,15 @@ func TestGetReactions(t *testing.T) {
 	rr, resp := Client.GetReactions(postId)
 	CheckNoError(t, resp)
 
-	if len(rr) != 5 {
+	assert.Len(t, rr, 5)
-		t.Fatal("reactions should returned correct length")
+	for _, r := range reactions {
-	}
+		assert.Contains(t, reactions, r)
-
-	if !reflect.DeepEqual(rr, reactions) {
-		t.Fatal("reactions should have matched")
 	}
 
 	rr, resp = Client.GetReactions("junk")
 	CheckBadRequestStatus(t, resp)
 
-	if len(rr) != 0 {
+	assert.Empty(t, rr)
-		t.Fatal("reactions should return empty")
-	}
 
 	_, resp = Client.GetReactions(GenerateTestId())
 	CheckForbiddenStatus(t, resp)