From 9534efe534d09d0378e9e1f1b51b9bb8b059bb66 Mon Sep 17 00:00:00 2001 From: Agniva De Sarker Date: Wed, 23 Feb 2022 13:20:31 +0530 Subject: [PATCH] Use error log level for websocket timeouts (#19609) For timeouts, the administrator would want to know about this. Therefore, we detect that error specifically and use the error level. This happened in our staging environment. Co-authored-by: Mattermod --- app/web_conn.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/web_conn.go b/app/web_conn.go index f71532174c..1b2146fff4 100644 --- a/app/web_conn.go +++ b/app/web_conn.go @@ -811,6 +811,10 @@ func (wc *WebConn) logSocketErr(source string, err error) { if websocket.IsCloseError(err, websocket.CloseNormalClosure, websocket.CloseNoStatusReceived) { mlog.Debug(source+": client side closed socket", mlog.String("user_id", wc.UserId)) } else { - mlog.Debug(source+": closing websocket", mlog.String("user_id", wc.UserId), mlog.Err(err)) + logFunc := mlog.Debug + if e, ok := err.(net.Error); ok && e.Timeout() { + logFunc = mlog.Error + } + logFunc(source+": closing websocket", mlog.String("user_id", wc.UserId), mlog.Err(err)) } }