Includes mmctl into the mono-repo (#23091)
* Includes mmctl into the mono-repo * Update to use the new public module paths * Adds docs check to the mmctl CI * Fix public utils import path * Tidy up modules * Fix linter * Update CI tasks to use the new file structure * Update CI references
Этот коммит содержится в:
коммит произвёл
GitHub
родитель
412109b02e
Коммит
951456c780
158
server/cmd/mmctl/commands/auth_utils_test.go
Обычный файл
158
server/cmd/mmctl/commands/auth_utils_test.go
Обычный файл
@@ -0,0 +1,158 @@
|
||||
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
||||
// See LICENSE.txt for license information.
|
||||
|
||||
package commands
|
||||
|
||||
import (
|
||||
"io/ioutil"
|
||||
"os"
|
||||
"os/user"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/spf13/viper"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func TestResolveConfigFilePath(t *testing.T) {
|
||||
originalUser := *currentUser
|
||||
defer func() {
|
||||
SetUser(&originalUser)
|
||||
}()
|
||||
|
||||
testUser, err := user.Current()
|
||||
require.NoError(t, err)
|
||||
|
||||
t.Run("should return the default config file location if nothing else is set", func(t *testing.T) {
|
||||
tmp, _ := ioutil.TempDir("", "mmctl-")
|
||||
defer os.RemoveAll(tmp)
|
||||
testUser.HomeDir = tmp
|
||||
SetUser(testUser)
|
||||
|
||||
expected := filepath.Join(getDefaultConfigHomePath(), configParent, configFileName)
|
||||
|
||||
viper.Set("config", filepath.Join(xdgConfigHomeVar, configParent, configFileName))
|
||||
|
||||
p := resolveConfigFilePath()
|
||||
require.Equal(t, expected, p)
|
||||
})
|
||||
|
||||
t.Run("should return config file location from xdg environment variable", func(t *testing.T) {
|
||||
tmp, _ := ioutil.TempDir("", "mmctl-")
|
||||
defer os.RemoveAll(tmp)
|
||||
testUser.HomeDir = tmp
|
||||
SetUser(testUser)
|
||||
|
||||
expected := filepath.Join(testUser.HomeDir, ".config", configParent, configFileName)
|
||||
|
||||
_ = os.Setenv("XDG_CONFIG_HOME", filepath.Join(testUser.HomeDir, ".config"))
|
||||
viper.Set("config", filepath.Join(xdgConfigHomeVar, configParent, configFileName))
|
||||
|
||||
p := resolveConfigFilePath()
|
||||
require.Equal(t, expected, p)
|
||||
})
|
||||
|
||||
t.Run("should return the user-defined config file path if one is set", func(t *testing.T) {
|
||||
tmp, _ := ioutil.TempDir("", "mmctl-")
|
||||
defer os.RemoveAll(tmp)
|
||||
|
||||
testUser.HomeDir = "path/should/be/ignored"
|
||||
SetUser(testUser)
|
||||
|
||||
expected := filepath.Join(tmp, configFileName)
|
||||
|
||||
err := os.Setenv("XDG_CONFIG_HOME", "path/should/be/ignored")
|
||||
require.NoError(t, err)
|
||||
viper.Set("config", expected)
|
||||
|
||||
p := resolveConfigFilePath()
|
||||
require.Equal(t, expected, p)
|
||||
})
|
||||
|
||||
t.Run("should resolve config file path if $HOME variable is used", func(t *testing.T) {
|
||||
tmp, _ := ioutil.TempDir("", "mmctl-")
|
||||
defer os.RemoveAll(tmp)
|
||||
|
||||
testUser.HomeDir = "path/should/be/ignored"
|
||||
SetUser(testUser)
|
||||
|
||||
expected := filepath.Join(testUser.HomeDir, "/.config/mmctl/config")
|
||||
|
||||
err := os.Setenv("XDG_CONFIG_HOME", "path/should/be/ignored")
|
||||
require.NoError(t, err)
|
||||
viper.Set("config", "$HOME/.config/mmctl/config")
|
||||
|
||||
p := resolveConfigFilePath()
|
||||
require.Equal(t, expected, p)
|
||||
})
|
||||
|
||||
t.Run("should create the user-defined config file path if one is set", func(t *testing.T) {
|
||||
tmp, _ := ioutil.TempDir("", "mmctl-")
|
||||
defer os.RemoveAll(tmp)
|
||||
|
||||
testUser.HomeDir = "path/should/be/ignored"
|
||||
SetUser(testUser)
|
||||
extraDir := "extra"
|
||||
|
||||
expected := filepath.Join(tmp, extraDir, "config.json")
|
||||
|
||||
err := os.Setenv("XDG_CONFIG_HOME", "path/should/be/ignored")
|
||||
require.NoError(t, err)
|
||||
viper.Set("config", expected)
|
||||
|
||||
err = SaveCredentials(Credentials{})
|
||||
require.NoError(t, err)
|
||||
info, err := os.Stat(expected)
|
||||
require.NoError(t, err)
|
||||
|
||||
assert.False(t, info.IsDir())
|
||||
assert.True(t, info.Name() == "config.json")
|
||||
})
|
||||
|
||||
t.Run("should return error if the config flag is set to a directory", func(t *testing.T) {
|
||||
tmp, _ := ioutil.TempDir("", "mmctl-")
|
||||
defer os.RemoveAll(tmp)
|
||||
|
||||
testUser.HomeDir = "path/should/be/ignored"
|
||||
SetUser(testUser)
|
||||
|
||||
err := os.Setenv("XDG_CONFIG_HOME", "path/should/be/ignored")
|
||||
require.NoError(t, err)
|
||||
viper.Set("config", tmp)
|
||||
|
||||
err = SaveCredentials(Credentials{})
|
||||
require.Error(t, err)
|
||||
require.True(t, strings.HasSuffix(err.Error(), "is a directory"))
|
||||
})
|
||||
}
|
||||
|
||||
func TestReadSecretFromFile(t *testing.T) {
|
||||
f, err := ioutil.TempFile(t.TempDir(), "mmctl")
|
||||
require.NoError(t, err)
|
||||
|
||||
_, err = f.WriteString("test-pass")
|
||||
require.NoError(t, err)
|
||||
|
||||
t.Run("password from file", func(t *testing.T) {
|
||||
var pass string
|
||||
err := readSecretFromFile(f.Name(), &pass)
|
||||
require.NoError(t, err)
|
||||
require.Equal(t, "test-pass", pass)
|
||||
})
|
||||
|
||||
t.Run("no file path is provided", func(t *testing.T) {
|
||||
pass := "test-pass-2"
|
||||
err := readSecretFromFile("", &pass)
|
||||
require.NoError(t, err)
|
||||
require.Equal(t, "test-pass-2", pass)
|
||||
})
|
||||
|
||||
t.Run("nonexistent file provided", func(t *testing.T) {
|
||||
var pass string
|
||||
err := readSecretFromFile(filepath.Join(t.TempDir(), "bla"), &pass)
|
||||
require.Error(t, err)
|
||||
require.Empty(t, pass)
|
||||
})
|
||||
}
|
||||
Ссылка в новой задаче
Block a user