Fix empty string comparison issues in the codebase (#16686)

Automatic Merge

model/team.go

@@ -152,7 +152,7 @@ func (o *Team) IsValid() *AppError {
 		return NewAppError("Team.IsValid", "model.team.is_valid.email.app_error", nil, "id="+o.Id, http.StatusBadRequest)
 	}
 
-	if len(o.Email) > 0 && !IsValidEmail(o.Email) {
+	if o.Email != "" && !IsValidEmail(o.Email) {
 		return NewAppError("Team.IsValid", "model.team.is_valid.email.app_error", nil, "id="+o.Id, http.StatusBadRequest)
 	}
 
@@ -168,7 +168,7 @@ func (o *Team) IsValid() *AppError {
 		return NewAppError("Team.IsValid", "model.team.is_valid.description.app_error", nil, "id="+o.Id, http.StatusBadRequest)
 	}
 
-	if len(o.InviteId) == 0 {
+	if o.InviteId == "" {
 		return NewAppError("Team.IsValid", "model.team.is_valid.invite_id.app_error", nil, "id="+o.Id, http.StatusBadRequest)
 	}
 
@@ -208,7 +208,7 @@ func (o *Team) PreSave() {
 	o.Description = SanitizeUnicode(o.Description)
 	o.CompanyName = SanitizeUnicode(o.CompanyName)
 
-	if len(o.InviteId) == 0 {
+	if o.InviteId == "" {
 		o.InviteId = NewId()
 	}
 }