Fix empty string comparison issues in the codebase (#16686)

Automatic Merge

app/plugin_api_test.go

@@ -1296,21 +1296,21 @@ func TestPluginAPIGetConfig(t *testing.T) {
 	api := th.SetupPluginAPI()
 
 	config := api.GetConfig()
-	if config.LdapSettings.BindPassword != nil && len(*config.LdapSettings.BindPassword) > 0 {
+	if config.LdapSettings.BindPassword != nil && *config.LdapSettings.BindPassword != "" {
 		assert.Equal(t, *config.LdapSettings.BindPassword, model.FAKE_SETTING)
 	}
 
 	assert.Equal(t, *config.FileSettings.PublicLinkSalt, model.FAKE_SETTING)
 
-	if len(*config.FileSettings.AmazonS3SecretAccessKey) > 0 {
+	if *config.FileSettings.AmazonS3SecretAccessKey != "" {
 		assert.Equal(t, *config.FileSettings.AmazonS3SecretAccessKey, model.FAKE_SETTING)
 	}
 
-	if config.EmailSettings.SMTPPassword != nil && len(*config.EmailSettings.SMTPPassword) > 0 {
+	if config.EmailSettings.SMTPPassword != nil && *config.EmailSettings.SMTPPassword != "" {
 		assert.Equal(t, *config.EmailSettings.SMTPPassword, model.FAKE_SETTING)
 	}
 
-	if len(*config.GitLabSettings.Secret) > 0 {
+	if *config.GitLabSettings.Secret != "" {
 		assert.Equal(t, *config.GitLabSettings.Secret, model.FAKE_SETTING)
 	}
 
@@ -1333,21 +1333,21 @@ func TestPluginAPIGetUnsanitizedConfig(t *testing.T) {
 	api := th.SetupPluginAPI()
 
 	config := api.GetUnsanitizedConfig()
-	if config.LdapSettings.BindPassword != nil && len(*config.LdapSettings.BindPassword) > 0 {
+	if config.LdapSettings.BindPassword != nil && *config.LdapSettings.BindPassword != "" {
 		assert.NotEqual(t, *config.LdapSettings.BindPassword, model.FAKE_SETTING)
 	}
 
 	assert.NotEqual(t, *config.FileSettings.PublicLinkSalt, model.FAKE_SETTING)
 
-	if len(*config.FileSettings.AmazonS3SecretAccessKey) > 0 {
+	if *config.FileSettings.AmazonS3SecretAccessKey != "" {
 		assert.NotEqual(t, *config.FileSettings.AmazonS3SecretAccessKey, model.FAKE_SETTING)
 	}
 
-	if config.EmailSettings.SMTPPassword != nil && len(*config.EmailSettings.SMTPPassword) > 0 {
+	if config.EmailSettings.SMTPPassword != nil && *config.EmailSettings.SMTPPassword != "" {
 		assert.NotEqual(t, *config.EmailSettings.SMTPPassword, model.FAKE_SETTING)
 	}
 
-	if len(*config.GitLabSettings.Secret) > 0 {
+	if *config.GitLabSettings.Secret != "" {
 		assert.NotEqual(t, *config.GitLabSettings.Secret, model.FAKE_SETTING)
 	}