From 94b4aa082c456914d89d9926d06814bd17309a73 Mon Sep 17 00:00:00 2001 From: VeraLyu Date: Thu, 23 Mar 2017 20:19:22 +0800 Subject: [PATCH] PLT-5913: Remove id from heading markdown compilation (#5782) Id for heading markdown is unnecessary as we didn't attach any style/effect on that id, and it also introduce duplicate id. So remove it from heading markdown generatiing. --- webapp/tests/formatting_hashtags.test.jsx | 2 +- webapp/utils/markdown.jsx | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/webapp/tests/formatting_hashtags.test.jsx b/webapp/tests/formatting_hashtags.test.jsx index 657dcf69de..cfda9aaa25 100644 --- a/webapp/tests/formatting_hashtags.test.jsx +++ b/webapp/tests/formatting_hashtags.test.jsx @@ -11,7 +11,7 @@ describe('TextFormatting.Hashtags', function() { it('Not hashtags', function(done) { assert.equal( TextFormatting.formatText('# hashtag').trim(), - '

hashtag

' + '

hashtag

' ); assert.equal( diff --git a/webapp/utils/markdown.jsx b/webapp/utils/markdown.jsx index c84df0fa50..db8e739e67 100644 --- a/webapp/utils/markdown.jsx +++ b/webapp/utils/markdown.jsx @@ -156,9 +156,8 @@ class MattermostMarkdownRenderer extends marked.Renderer { return out; } - heading(text, level, raw) { - const id = `${this.options.headerPrefix}${raw.toLowerCase().replace(/[^\w]+/g, '-')}`; - return `${text}`; + heading(text, level) { + return `${text}`; } link(href, title, text) {