[MM-19640] Retrieve Compliance files from the System Console (#14976)
* add query param for downloading file * Address PR comments * sanitize error messages * revert error santization * address PR comments * Log Error * Comment for clarification * Add test + Opt In Option * Fix typo * Remove line number * Check is downloadable in server * Don't use constants * Check for downloadExportResults in API * make actiance export zip * make i18n strings * Remove translations * Add translations * Revert "Add translations" This reverts commit adc5d28b3e7712f51cd3eff565e30fb8ddfd6f65. Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Этот коммит содержится в:
коммит произвёл
GitHub
родитель
77f7a97bee
Коммит
935ddaa251
@@ -4,6 +4,8 @@
|
||||
package api4
|
||||
|
||||
import (
|
||||
"os"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
@@ -172,6 +174,68 @@ func TestGetJobsByType(t *testing.T) {
|
||||
CheckForbiddenStatus(t, resp)
|
||||
}
|
||||
|
||||
func TestDownloadJob(t *testing.T) {
|
||||
th := Setup(t).InitBasic()
|
||||
defer th.TearDown()
|
||||
jobName := model.NewId()
|
||||
job := &model.Job{
|
||||
Id: jobName,
|
||||
Type: model.JOB_TYPE_MESSAGE_EXPORT,
|
||||
Data: map[string]string{
|
||||
"export_type": "csv",
|
||||
},
|
||||
Status: model.JOB_STATUS_SUCCESS,
|
||||
}
|
||||
|
||||
// DownloadExportResults is not set to true so we should get a not implemented error status
|
||||
_, resp := th.Client.DownloadJob(job.Id)
|
||||
CheckNotImplementedStatus(t, resp)
|
||||
|
||||
th.App.UpdateConfig(func(cfg *model.Config) {
|
||||
*cfg.MessageExportSettings.DownloadExportResults = true
|
||||
})
|
||||
|
||||
// Normal user cannot download the results of these job (Doesn't have permission)
|
||||
_, resp = th.Client.DownloadJob(job.Id)
|
||||
CheckForbiddenStatus(t, resp)
|
||||
|
||||
// System admin trying to download the results of a non-existant job
|
||||
_, resp = th.SystemAdminClient.DownloadJob(job.Id)
|
||||
CheckNotFoundStatus(t, resp)
|
||||
|
||||
// Here we have a job that exist in our database but the results do not exist therefore when we try to download the results
|
||||
// as a system admin, we should get a not found status.
|
||||
_, err := th.App.Srv().Store.Job().Save(job)
|
||||
require.Nil(t, err)
|
||||
defer th.App.Srv().Store.Job().Delete(job.Id)
|
||||
|
||||
filePath := "./data/export/" + job.Id + "/testdat.txt"
|
||||
mkdirAllErr := os.MkdirAll(filepath.Dir(filePath), 0770)
|
||||
require.Nil(t, mkdirAllErr)
|
||||
os.Create(filePath)
|
||||
|
||||
_, resp = th.SystemAdminClient.DownloadJob(job.Id)
|
||||
CheckBadRequestStatus(t, resp)
|
||||
|
||||
job.Data["is_downloadable"] = "true"
|
||||
updateStatus, err := th.App.Srv().Store.Job().UpdateOptimistically(job, model.JOB_STATUS_SUCCESS)
|
||||
require.True(t, updateStatus)
|
||||
require.Nil(t, err)
|
||||
|
||||
_, resp = th.SystemAdminClient.DownloadJob(job.Id)
|
||||
CheckNotFoundStatus(t, resp)
|
||||
|
||||
// Now we stub the results of the job into the same directory and try to download it again
|
||||
// This time we should successfully retrieve the results without any error
|
||||
filePath = "./data/export/" + job.Id + "/csv_export.zip"
|
||||
mkdirAllErr = os.MkdirAll(filepath.Dir(filePath), 0770)
|
||||
require.Nil(t, mkdirAllErr)
|
||||
os.Create(filePath)
|
||||
|
||||
_, resp = th.SystemAdminClient.DownloadJob(job.Id)
|
||||
require.Nil(t, resp.Error)
|
||||
}
|
||||
|
||||
func TestCancelJob(t *testing.T) {
|
||||
th := Setup(t)
|
||||
defer th.TearDown()
|
||||
|
||||
Ссылка в новой задаче
Block a user