From 92011a6c75976480cbf9bec160a1f0e2ff249371 Mon Sep 17 00:00:00 2001 From: Ben Schumacher Date: Wed, 7 May 2025 13:40:51 +0200 Subject: [PATCH] [MM-29111] Fix errcheck issues in server/channels/app/upload.go (#30678) Co-authored-by: Claude --- server/.golangci.yml | 1 - server/channels/app/upload.go | 11 ++++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index 1770eb2f2b..1ef1f81315 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -97,7 +97,6 @@ issues: channels/app/platform/license.go|\ channels/app/slashcommands/command_test.go|\ channels/app/slashcommands/helper_test.go|\ - channels/app/upload.go|\ channels/store/localcachelayer/channel_layer.go|\ channels/store/localcachelayer/channel_layer_test.go|\ channels/store/localcachelayer/emoji_layer.go|\ diff --git a/server/channels/app/upload.go b/server/channels/app/upload.go index 83bc302058..ac202bf1bd 100644 --- a/server/channels/app/upload.go +++ b/server/channels/app/upload.go @@ -230,7 +230,16 @@ func (a *App) UploadData(c request.CTX, us *model.UploadSession, rd io.Reader) ( return nil, err } if written < minFirstPartSize && written != us.FileSize { - a.RemoveFile(uploadPath) + if fileErr := a.RemoveFile(uploadPath); fileErr != nil { + c.Logger().Warn("Failed to remove initial upload chunk that was too small", + mlog.Err(fileErr), + mlog.String("upload_path", uploadPath), + mlog.String("upload_id", us.Id), + mlog.String("filename", us.Filename), + mlog.Int("chunk_size", int(written)), + mlog.Int("min_size", minFirstPartSize), + ) + } var errStr string if err != nil { errStr = err.Error()