[MM-19140] Migrate tests from "model/command_test.go" to use testify. (#12584)

* Migrate t.Fatal to testify.

* Migrate t.Fatal to testify.

* Code refactor.

* Test case fix.

model/command_test.go

@@ -6,6 +6,8 @@ package model
 import (
 	"strings"
 	"testing"
+
+	"github.com/stretchr/testify/require"
 )
 
 func TestCommandJson(t *testing.T) {
@@ -13,9 +15,7 @@ func TestCommandJson(t *testing.T) {
 	json := o.ToJson()
 	ro := CommandFromJson(strings.NewReader(json))
 
-	if o.Id != ro.Id {
+	require.Equal(t, o.Id, ro.Id, "Ids do not match")
-		t.Fatal("Ids do not match")
-	}
 }
 
 func TestCommandIsValid(t *testing.T) {
@@ -33,134 +33,82 @@ func TestCommandIsValid(t *testing.T) {
 		Description: "",
 	}
 
-	if err := o.IsValid(); err != nil {
+	require.Nil(t, o.IsValid())
-		t.Fatal(err)
-	}
 
 	o.Id = ""
-	if err := o.IsValid(); err == nil {
+	require.NotNil(t, o.IsValid(), "should be invalid")
-		t.Fatal("should be invalid")
-	}
 
 	o.Id = NewId()
-	if err := o.IsValid(); err != nil {
+	require.Nil(t, o.IsValid())
-		t.Fatal(err)
-	}
 
 	o.Token = ""
-	if err := o.IsValid(); err == nil {
+	require.NotNil(t, o.IsValid(), "should be invalid")
-		t.Fatal("should be invalid")
-	}
 
 	o.Token = NewId()
-	if err := o.IsValid(); err != nil {
+	require.Nil(t, o.IsValid())
-		t.Fatal(err)
-	}
 
 	o.CreateAt = 0
-	if err := o.IsValid(); err == nil {
+	require.NotNil(t, o.IsValid(), "should be invalid")
-		t.Fatal("should be invalid")
-	}
 
 	o.CreateAt = GetMillis()
-	if err := o.IsValid(); err != nil {
+	require.Nil(t, o.IsValid())
-		t.Fatal(err)
-	}
 
 	o.UpdateAt = 0
-	if err := o.IsValid(); err == nil {
+	require.NotNil(t, o.IsValid(), "should be invalid")
-		t.Fatal("should be invalid")
-	}
 
 	o.UpdateAt = GetMillis()
-	if err := o.IsValid(); err != nil {
+	require.Nil(t, o.IsValid())
-		t.Fatal(err)
-	}
 
 	o.CreatorId = ""
-	if err := o.IsValid(); err == nil {
+	require.NotNil(t, o.IsValid(), "should be invalid")
-		t.Fatal("should be invalid")
-	}
 
 	o.CreatorId = NewId()
-	if err := o.IsValid(); err != nil {
+	require.Nil(t, o.IsValid())
-		t.Fatal(err)
-	}
 
 	o.TeamId = ""
-	if err := o.IsValid(); err == nil {
+	require.NotNil(t, o.IsValid(), "should be invalid")
-		t.Fatal("should be invalid")
-	}
 
 	o.TeamId = NewId()
-	if err := o.IsValid(); err != nil {
+	require.Nil(t, o.IsValid())
-		t.Fatal(err)
-	}
 
 	o.Trigger = ""
-	if err := o.IsValid(); err == nil {
+	require.NotNil(t, o.IsValid(), "should be invalid")
-		t.Fatal("should be invalid")
-	}
 
 	o.Trigger = strings.Repeat("1", 129)
-	if err := o.IsValid(); err == nil {
+	require.NotNil(t, o.IsValid(), "should be invalid")
-		t.Fatal("should be invalid")
-	}
 
 	o.Trigger = strings.Repeat("1", 128)
-	if err := o.IsValid(); err != nil {
+	require.Nil(t, o.IsValid())
-		t.Fatal(err)
-	}
 
 	o.URL = ""
-	if err := o.IsValid(); err == nil {
+	require.NotNil(t, o.IsValid(), "should be invalid")
-		t.Fatal("should be invalid")
-	}
 
 	o.URL = "1234"
-	if err := o.IsValid(); err == nil {
+	require.NotNil(t, o.IsValid(), "should be invalid")
-		t.Fatal("should be invalid")
-	}
 
 	o.URL = "https://example.com"
-	if err := o.IsValid(); err != nil {
+	require.Nil(t, o.IsValid())
-		t.Fatal(err)
-	}
 
 	o.Method = "https://example.com"
-	if err := o.IsValid(); err == nil {
+	require.NotNil(t, o.IsValid(), "should be invalid")
-		t.Fatal("should be invalid")
-	}
 
 	o.Method = COMMAND_METHOD_GET
-	if err := o.IsValid(); err != nil {
+	require.Nil(t, o.IsValid())
-		t.Fatal(err)
-	}
 
 	o.Method = COMMAND_METHOD_POST
-	if err := o.IsValid(); err != nil {
+	require.Nil(t, o.IsValid())
-		t.Fatal(err)
-	}
 
 	o.DisplayName = strings.Repeat("1", 65)
-	if err := o.IsValid(); err == nil {
+	require.NotNil(t, o.IsValid(), "should be invalid")
-		t.Fatal("should be invalid")
-	}
 
 	o.DisplayName = strings.Repeat("1", 64)
-	if err := o.IsValid(); err != nil {
+	require.Nil(t, o.IsValid())
-		t.Fatal(err)
-	}
 
 	o.Description = strings.Repeat("1", 129)
-	if err := o.IsValid(); err == nil {
+	require.NotNil(t, o.IsValid(), "should be invalid")
-		t.Fatal("should be invalid")
-	}
 
 	o.Description = strings.Repeat("1", 128)
-	if err := o.IsValid(); err != nil {
+	require.Nil(t, o.IsValid())
-		t.Fatal(err)
-	}
 }
 
 func TestCommandPreSave(t *testing.T) {