From 8cd9dac632e47374d25cdf632eedc5a53d5e1dd1 Mon Sep 17 00:00:00 2001 From: Nikhil Ranjan Date: Fri, 20 Sep 2019 16:53:48 +0200 Subject: [PATCH] =?UTF-8?q?Convert=20app/user=5Fagent=5Ftest.go=20t.Fatal?= =?UTF-8?q?=20calls=20into=20assert/requi=E2=80=A6=20(#12224)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app/user_agent_test.go | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/app/user_agent_test.go b/app/user_agent_test.go index e4680bfc93..818ddf4a67 100644 --- a/app/user_agent_test.go +++ b/app/user_agent_test.go @@ -5,6 +5,7 @@ import ( "testing" "github.com/avct/uasurfer" + "github.com/stretchr/testify/assert" ) type testUserAgent struct { @@ -53,9 +54,8 @@ func TestGetPlatformName(t *testing.T) { t.Run(fmt.Sprintf("GetPlatformName_%v", i), func(t *testing.T) { ua := uasurfer.Parse(userAgent.UserAgent) - if actual := getPlatformName(ua); actual != expected[i] { - t.Fatalf("%v Got %v, expected %v", userAgent.Name, actual, expected[i]) - } + actual := getPlatformName(ua) + assert.Equal(t, expected[i], actual) }) } } @@ -83,9 +83,8 @@ func TestGetOSName(t *testing.T) { t.Run(fmt.Sprintf("GetOSName_%v", i), func(t *testing.T) { ua := uasurfer.Parse(userAgent.UserAgent) - if actual := getOSName(ua); actual != expected[i] { - t.Fatalf("Got %v, expected %v", actual, expected[i]) - } + actual := getOSName(ua) + assert.Equal(t, expected[i], actual) }) } } @@ -113,9 +112,8 @@ func TestGetBrowserName(t *testing.T) { t.Run(fmt.Sprintf("GetBrowserName_%v", i), func(t *testing.T) { ua := uasurfer.Parse(userAgent.UserAgent) - if actual := getBrowserName(ua, userAgent.UserAgent); actual != expected[i] { - t.Fatalf("Got %v, expected %v", actual, expected[i]) - } + actual := getBrowserName(ua, userAgent.UserAgent) + assert.Equal(t, expected[i], actual) }) } } @@ -143,9 +141,8 @@ func TestGetBrowserVersion(t *testing.T) { t.Run(fmt.Sprintf("GetBrowserVersion_%v", i), func(t *testing.T) { ua := uasurfer.Parse(userAgent.UserAgent) - if actual := getBrowserVersion(ua, userAgent.UserAgent); actual != expected[i] { - t.Fatalf("Got %v, expected %v", actual, expected[i]) - } + actual := getBrowserVersion(ua, userAgent.UserAgent) + assert.Equal(t, expected[i], actual) }) } }