Merge pull request #425 from rgarmsen2295/mm-1901

MM-1901 When a user joins a channel that channel is now automatically opened for them

web/react/components/more_channels.jsx

@@ -14,11 +14,21 @@ function getStateFromStores() {
     };
 }
 
-module.exports = React.createClass({
+export default class MoreChannels extends React.Component {
-    displayName: 'MoreChannelsModal',
+    constructor(props) {
+        super(props);
 
-    componentDidMount: function() {
+        this.onListenerChange = this.onListenerChange.bind(this);
-        ChannelStore.addMoreChangeListener(this._onChange);
+        this.handleJoin = this.handleJoin.bind(this);
+        this.handleNewChannel = this.handleNewChannel.bind(this);
+
+        var initState = getStateFromStores();
+        initState.channelType = '';
+        initState.joiningChannel = -1;
+        this.state = initState;
+    }
+    componentDidMount() {
+        ChannelStore.addMoreChangeListener(this.onListenerChange);
         $(this.refs.modal.getDOMNode()).on('shown.bs.modal', function shown() {
             asyncClient.getMoreChannels(true);
         });
@@ -28,43 +38,42 @@ module.exports = React.createClass({
             var button = e.relatedTarget;
             self.setState({channelType: $(button).attr('data-channeltype')});
         });
-    },
+    }
-    componentWillUnmount: function() {
+    componentWillUnmount() {
-        ChannelStore.removeMoreChangeListener(this._onChange);
+        ChannelStore.removeMoreChangeListener(this.onListenerChange);
-    },
+    }
-    _onChange: function() {
+    onListenerChange() {
         var newState = getStateFromStores();
         if (!utils.areStatesEqual(newState.channels, this.state.channels)) {
             this.setState(newState);
         }
-    },
+    }
-    getInitialState: function() {
+    handleJoin(channel, channelIndex) {
-        var initState = getStateFromStores();
+        this.setState({joiningChannel: channelIndex});
-        initState.channelType = '';
+        client.joinChannel(channel.id,
-        return initState;
+            function joinSuccess() {
-    },
-    handleJoin: function(id) {
-        client.joinChannel(id,
-            function() {
                 $(this.refs.modal.getDOMNode()).modal('hide');
-                asyncClient.getChannel(id);
+                asyncClient.getChannel(channel.id);
+                utils.switchChannel(channel);
+                this.setState({joiningChannel: -1});
             }.bind(this),
-            function(err) {
+            function joinFail(err) {
+                this.setState({joiningChannel: -1});
                 this.state.serverError = err.message;
                 this.setState(this.state);
             }.bind(this)
         );
-    },
+    }
-    handleNewChannel: function() {
+    handleNewChannel() {
         $(this.refs.modal.getDOMNode()).modal('hide');
-    },
+    }
-    render: function() {
+    render() {
         var serverError;
         if (this.state.serverError) {
             serverError = <div className='form-group has-error'><label className='control-label'>{this.state.serverError}</label></div>;
         }
 
-        var outter = this;
+        var self = this;
         var moreChannels;
 
         if (this.state.channels != null) {
@@ -74,14 +83,29 @@ module.exports = React.createClass({
                     moreChannels = (
                         <table className='more-channel-table table'>
                             <tbody>
-                                {channels.map(function cMap(channel) {
+                                {channels.map(function cMap(channel, index) {
+                                    var joinButton;
+                                    if (self.state.joiningChannel === index) {
+                                        joinButton = (<img
+                                                        className='join-channel-loading-gif'
+                                                        src='/static/images/load.gif'
+                                                    />);
+                                    } else {
+                                        joinButton = (<button
+                                                        onClick={self.handleJoin.bind(self, channel, index)}
+                                                        className='btn btn-primary'>Join
+                                                    </button>);
+                                    }
+
                                     return (
                                         <tr key={channel.id}>
                                             <td>
                                                 <p className='more-channel-name'>{channel.display_name}</p>
                                                 <p className='more-channel-description'>{channel.description}</p>
                                             </td>
-                                            <td className='td--action'><button onClick={outter.handleJoin.bind(outter, channel.id)} className='btn btn-primary'>Join</button></td>
+                                            <td className='td--action'>
+                                                {joinButton}
+                                            </td>
                                         </tr>
                                     );
                                 })}
@@ -102,23 +126,47 @@ module.exports = React.createClass({
         }
 
         return (
-            <div className='modal fade' id='more_channels' ref='modal' tabIndex='-1' role='dialog' aria-hidden='true'>
+            <div
+                className='modal fade'
+                id='more_channels'
+                ref='modal'
+                tabIndex='-1'
+                role='dialog'
+                aria-hidden='true'
+            >
                 <div className='modal-dialog'>
                     <div className='modal-content'>
                         <div className='modal-header'>
-                            <button type='button' className='close' data-dismiss='modal'>
+                            <button
+                                type='button'
+                                className='close'
+                                data-dismiss='modal'
+                            >
                                 <span aria-hidden='true'>&times;</span>
                                 <span className='sr-only'>Close</span>
                             </button>
                             <h4 className='modal-title'>More Channels</h4>
-                            <button data-toggle='modal' data-target='#new_channel' data-channeltype={this.state.channelType} type='button' className='btn btn-primary channel-create-btn' onClick={this.handleNewChannel}>Create New Channel</button>
+                            <button
+                                data-toggle='modal'
+                                data-target='#new_channel'
+                                data-channeltype={this.state.channelType}
+                                type='button'
+                                className='btn btn-primary channel-create-btn'
+                                onClick={this.handleNewChannel}>Create New Channel
+                            </button>
                         </div>
                         <div className='modal-body'>
                             {moreChannels}
                             {serverError}
                         </div>
                         <div className='modal-footer'>
-                            <button type='button' className='btn btn-default' data-dismiss='modal'>Close</button>
+                            <button
+                                type='button'
+                                className='btn btn-default'
+                                data-dismiss='modal'
+                            >
+                                Close
+                            </button>
                         </div>
                     </div>
                 </div>
@@ -126,4 +174,4 @@ module.exports = React.createClass({
 
         );
     }
-});
+}

web/sass-files/sass/partials/_sidebar--left.scss

@@ -124,7 +124,15 @@
 }
 
 .channel-loading-gif {
-    height:15px;
+    height: 15px;
-    width:15px;
+    width: 15px;
-    margin-top:2px;
+    margin-top: 2px;
+}
+
+.join-channel-loading-gif {
+    margin-top: 5px;
+    margin-left: 10px;
+    height: 25px;
+    width: 25px;
+
 }