PLT-3105 Files table migration (#4068)

* Implemented initial changes for files table

* Removed *_benchmark_test.go files

* Re-implemented GetPublicFile and added support for old path

* Localization for files table

* Moved file system code into utils package

* Finished server-side changes and added initial upgrade script

* Added getPostFiles api

* Re-add Extension and HasPreviewImage fields to FileInfo

* Removed unused translation

* Fixed merge conflicts left over after permissions changes

* Forced FileInfo.extension to be lower case

* Changed FileUploadResponse to contain the FileInfos instead of FileIds

* Fixed permissions on getFile* calls

* Fixed notifications for file uploads

* Added initial version of client code for files changes

* Permanently added FileIds field to Post object and removed Post.HasFiles

* Updated PostStore.Update to be usable in more circumstances

* Re-added Filenames field and switched file migration to be entirely lazy-loaded

* Increased max listener count for FileStore

* Removed unused fileInfoCache

* Moved file system code back into api

* Removed duplicate test case

* Fixed unit test running on ports other than 8065

* Renamed HasPermissionToPostContext to HasPermissionToChannelByPostContext

* Refactored handleImages to make it more easily understandable

* Renamed getPostFiles to getFileInfosForPost

* Re-added pre-FileIds posts to analytics

* Changed files to be saved as their ids as opposed to id/filename.ext

* Renamed FileInfo.UserId to FileInfo.CreatorId

* Fixed detection of language in CodePreview

* Fixed switching between threads in the RHS not loading new files

* Add serverside protection against a rare bug where the client sends the same file twice for a single post

* Refactored the important parts of uploadFile api call into a function that can be called without a web context

webapp/stores/file_store.jsx

@@ -16,41 +16,58 @@ class FileStore extends EventEmitter {
         this.handleEventPayload = this.handleEventPayload.bind(this);
         this.dispatchToken = AppDispatcher.register(this.handleEventPayload);
 
-        this.fileInfo = new Map();
+        this.setMaxListeners(600);
+
+        this.fileInfosByPost = new Map();
     }
 
     addChangeListener(callback) {
         this.on(CHANGE_EVENT, callback);
     }
+
     removeChangeListener(callback) {
         this.removeListener(CHANGE_EVENT, callback);
     }
-    emitChange(filename) {
-        this.emit(CHANGE_EVENT, filename);
+
+    emitChange() {
+        this.emit(CHANGE_EVENT);
     }
 
-    hasInfo(filename) {
-        return this.fileInfo.has(filename);
+    hasInfosForPost(postId) {
+        return this.fileInfosByPost.has(postId);
     }
 
-    getInfo(filename) {
-        return this.fileInfo.get(filename);
+    getInfosForPost(postId) {
+        return this.fileInfosByPost.get(postId);
     }
 
-    setInfo(filename, info) {
-        this.fileInfo.set(filename, info);
+    saveInfos(postId, infos) {
+        this.fileInfosByPost.set(postId, infos);
+    }
+
+    getFileUrl(fileId) {
+        return `/api/v3/files/${fileId}/get`;
+    }
+
+    getFileThumbnailUrl(fileId) {
+        return `/api/v3/files/${fileId}/get_thumbnail`;
+    }
+
+    getFilePreviewUrl(fileId) {
+        return `/api/v3/files/${fileId}/get_preview`;
     }
 
     handleEventPayload(payload) {
         const action = payload.action;
 
         switch (action.type) {
-        case ActionTypes.RECEIVED_FILE_INFO:
-            this.setInfo(action.filename, action.info);
-            this.emitChange(action.filename);
+        case ActionTypes.RECEIVED_FILE_INFOS:
+            // This assumes that all received file infos are for a single post
+            this.saveInfos(action.postId, action.infos);
+            this.emitChange(action.postId);
             break;
         }
     }
 }
 
-export default new FileStore();
+export default new FileStore();

webapp/stores/notification_store.jsx

@@ -84,7 +84,7 @@ class NotificationStoreClass extends EventEmitter {
                 if (msgProps.image) {
                     body = username + Utils.localizeMessage('channel_loader.uploadedImage', ' uploaded an image');
                 } else if (msgProps.otherFile) {
-                    body = Utils.localizeMessage('channel_loader.uploadedFile', ' uploaded a file');
+                    body = username + Utils.localizeMessage('channel_loader.uploadedFile', ' uploaded a file');
                 } else {
                     body = username + Utils.localizeMessage('channel_loader.something', ' did something new');
                 }

webapp/stores/post_store.jsx

@@ -224,7 +224,7 @@ class PostStoreClass extends EventEmitter {
                 } else if (combinedPosts.posts.hasOwnProperty(pid)) {
                     combinedPosts.posts[pid] = Object.assign({}, np, {
                         state: Constants.POST_DELETED,
-                        filenames: []
+                        fileIds: []
                     });
                 }
             }
@@ -318,7 +318,7 @@ class PostStoreClass extends EventEmitter {
             // make sure to copy the post so that component state changes work properly
             postList.posts[post.id] = Object.assign({}, post, {
                 state: Constants.POST_DELETED,
-                filenames: []
+                fileIds: []
             });
         }
     }
@@ -514,7 +514,7 @@ class PostStoreClass extends EventEmitter {
     }
 
     getEmptyDraft() {
-        return {message: '', uploadsInProgress: [], previews: []};
+        return {message: '', uploadsInProgress: [], fileInfos: []};
     }
 
     storeCurrentDraft(draft) {