RoleStore migration (#15017)

Automatic Merge

store/store.go

@@ -603,24 +603,24 @@ type PluginStore interface {
 }
 
 type RoleStore interface {
-	Save(role *model.Role) (*model.Role, *model.AppError)
-	Get(roleId string) (*model.Role, *model.AppError)
-	GetAll() ([]*model.Role, *model.AppError)
-	GetByName(name string) (*model.Role, *model.AppError)
-	GetByNames(names []string) ([]*model.Role, *model.AppError)
-	Delete(roleId string) (*model.Role, *model.AppError)
-	PermanentDeleteAll() *model.AppError
+	Save(role *model.Role) (*model.Role, error)
+	Get(roleId string) (*model.Role, error)
+	GetAll() ([]*model.Role, error)
+	GetByName(name string) (*model.Role, error)
+	GetByNames(names []string) ([]*model.Role, error)
+	Delete(roleId string) (*model.Role, error)
+	PermanentDeleteAll() error
 
 	// HigherScopedPermissions retrieves the higher-scoped permissions of a list of role names. The higher-scope
 	// (either team scheme or system scheme) is determined based on whether the team has a scheme or not.
-	ChannelHigherScopedPermissions(roleNames []string) (map[string]*model.RolePermissions, *model.AppError)
+	ChannelHigherScopedPermissions(roleNames []string) (map[string]*model.RolePermissions, error)
 
 	// AllChannelSchemeRoles returns all of the roles associated to channel schemes.
-	AllChannelSchemeRoles() ([]*model.Role, *model.AppError)
+	AllChannelSchemeRoles() ([]*model.Role, error)
 
 	// ChannelRolesUnderTeamRole returns all of the non-deleted roles that are affected by updates to the
 	// given role.
-	ChannelRolesUnderTeamRole(roleName string) ([]*model.Role, *model.AppError)
+	ChannelRolesUnderTeamRole(roleName string) ([]*model.Role, error)
 }
 
 type SchemeStore interface {