Remove remaining t.Fatal from the codebase (#13876)

* Remove remaining t.Fatal from the codebase

* Fix job_store test

* Address review comments

* Remove comments
Этот коммит содержится в:
Miguel de la Cruz
2020-02-13 17:53:23 +01:00
коммит произвёл GitHub
родитель 17523fa5d9
Коммит 84f45634a8
18 изменённых файлов: 119 добавлений и 229 удалений

Просмотреть файл

@@ -49,7 +49,7 @@ func TestWatcher(t *testing.T) {
ioutil.WriteFile(filepath.Join(tempDir, "unrelated"), []byte("data"), 0644)
select {
case <-called:
t.Fatal("callback should not have been called for unrelated file")
require.Fail(t, "callback should not have been called for unrelated file")
case <-time.After(1 * time.Second):
}
@@ -58,6 +58,6 @@ func TestWatcher(t *testing.T) {
select {
case <-called:
case <-time.After(5 * time.Second):
t.Fatal("callback should have been called when file written")
require.Fail(t, "callback should have been called when file written")
}
}