Remove remaining t.Fatal from the codebase (#13876)

* Remove remaining t.Fatal from the codebase

* Fix job_store test

* Address review comments

* Remove comments

api4/preference_test.go

@@ -328,9 +328,7 @@ func TestDeletePreferences(t *testing.T) {
 	CheckForbiddenStatus(t, resp)
 
 	prefs, _ = Client.GetPreferences(th.BasicUser.Id)
-	if len(prefs) != originalCount {
-		t.Fatal("should've deleted preferences")
-	}
+	require.Len(t, prefs, originalCount, "should've deleted preferences")
 
 	Client.Logout()
 	_, resp = Client.DeletePreferences(th.BasicUser.Id, &preferences)
@@ -358,15 +356,12 @@ func TestDeletePreferencesWebsocket(t *testing.T) {
 	CheckNoError(t, resp)
 
 	WebSocketClient, err := th.CreateWebSocketClient()
-	if err != nil {
-		t.Fatal(err)
-	}
+	require.Nil(t, err)
 
 	WebSocketClient.Listen()
 	time.Sleep(300 * time.Millisecond)
-	if resp := <-WebSocketClient.ResponseChannel; resp.Status != model.STATUS_OK {
-		t.Fatal("should have responded OK to authentication challenge")
-	}
+	wsResp := <-WebSocketClient.ResponseChannel
+	require.Equal(t, model.STATUS_OK, wsResp.Status, "should have responded OK to authentication challenge")
 
 	_, resp = th.Client.DeletePreferences(userId, preferences)
 	CheckNoError(t, resp)
@@ -383,19 +378,17 @@ func TestDeletePreferencesWebsocket(t *testing.T) {
 			}
 
 			received, err := model.PreferencesFromJson(strings.NewReader(event.GetData()["preferences"].(string)))
-			if err != nil {
-				t.Fatal(err)
-			}
+			require.Nil(t, err)
 
 			for i, preference := range *preferences {
-				if preference.UserId != received[i].UserId || preference.Category != received[i].Category || preference.Name != received[i].Name {
-					t.Fatal("received incorrect preference")
-				}
+				require.Equal(t, preference.UserId, received[i].UserId)
+				require.Equal(t, preference.Category, received[i].Category)
+				require.Equal(t, preference.Name, received[i].Name)
 			}
 
 			waiting = false
 		case <-timeout:
-			t.Fatal("timed out waiting for preference delete event")
+			require.Fail(t, "timed out waiting for preference delete event")
 		}
 	}
 }