[MM-45990] log JSON parsing errors in API4 (#20724)

api4/command_test.go

@@ -646,7 +646,7 @@ func TestExecuteInvalidCommand(t *testing.T) {
 		rc := &model.CommandResponse{}
 
 		if err := json.NewEncoder(w).Encode(rc); err != nil {
-			mlog.Warn("Error while writing response", mlog.Err(err))
+			th.TestLogger.Warn("Error while writing response", mlog.Err(err))
 		}
 	}))
 	defer ts.Close()
@@ -732,7 +732,7 @@ func TestExecuteGetCommand(t *testing.T) {
 
 		w.Header().Set("Content-Type", "application/json")
 		if err := json.NewEncoder(w).Encode(expectedCommandResponse); err != nil {
-			mlog.Warn("Error while writing response", mlog.Err(err))
+			th.TestLogger.Warn("Error while writing response", mlog.Err(err))
 		}
 	}))
 	defer ts.Close()
@@ -792,7 +792,7 @@ func TestExecutePostCommand(t *testing.T) {
 
 		w.Header().Set("Content-Type", "application/json")
 		if err := json.NewEncoder(w).Encode(expectedCommandResponse); err != nil {
-			mlog.Warn("Error while writing response", mlog.Err(err))
+			th.TestLogger.Warn("Error while writing response", mlog.Err(err))
 		}
 	}))
 	defer ts.Close()
@@ -846,7 +846,7 @@ func TestExecuteCommandAgainstChannelOnAnotherTeam(t *testing.T) {
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("Content-Type", "application/json")
 		if err := json.NewEncoder(w).Encode(expectedCommandResponse); err != nil {
-			mlog.Warn("Error while writing response", mlog.Err(err))
+			th.TestLogger.Warn("Error while writing response", mlog.Err(err))
 		}
 	}))
 	defer ts.Close()
@@ -898,7 +898,7 @@ func TestExecuteCommandAgainstChannelUserIsNotIn(t *testing.T) {
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("Content-Type", "application/json")
 		if err := json.NewEncoder(w).Encode(expectedCommandResponse); err != nil {
-			mlog.Warn("Error while writing response", mlog.Err(err))
+			th.TestLogger.Warn("Error while writing response", mlog.Err(err))
 		}
 	}))
 	defer ts.Close()
@@ -958,7 +958,7 @@ func TestExecuteCommandInDirectMessageChannel(t *testing.T) {
 		require.Equal(t, http.MethodPost, r.Method)
 		w.Header().Set("Content-Type", "application/json")
 		if err := json.NewEncoder(w).Encode(expectedCommandResponse); err != nil {
-			mlog.Warn("Error while writing response", mlog.Err(err))
+			th.TestLogger.Warn("Error while writing response", mlog.Err(err))
 		}
 	}))
 	defer ts.Close()
@@ -1025,7 +1025,7 @@ func TestExecuteCommandInTeamUserIsNotOn(t *testing.T) {
 
 		w.Header().Set("Content-Type", "application/json")
 		if err := json.NewEncoder(w).Encode(expectedCommandResponse); err != nil {
-			mlog.Warn("Error while writing response", mlog.Err(err))
+			th.TestLogger.Warn("Error while writing response", mlog.Err(err))
 		}
 	}))
 	defer ts.Close()