From 81a87533a9441fd113b964997b97b4f235399567 Mon Sep 17 00:00:00 2001 From: Ben Schumacher Date: Sat, 13 Jun 2020 09:51:45 +0200 Subject: [PATCH] [MM-25607] Correctly log if plugin icon is invalid (#14679) --- app/plugin.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/plugin.go b/app/plugin.go index d2b08b95e1..07f26cbe08 100644 --- a/app/plugin.go +++ b/app/plugin.go @@ -889,8 +889,10 @@ func getIcon(iconPath string) (string, error) { if err != nil { return "", errors.Wrapf(err, "failed to open icon at path %s", iconPath) } + if !svg.Is(icon) { - return "", errors.Wrapf(err, "icon is not svg %s", iconPath) + return "", errors.Errorf("icon is not svg %s", iconPath) } + return fmt.Sprintf("data:image/svg+xml;base64,%s", base64.StdEncoding.EncodeToString(icon)), nil }