[MM-59083] Handle permissions in user management options (#27668)

webapp/channels/src/components/admin_console/system_user_detail/system_user_detail.tsx

@@ -19,7 +19,7 @@ import AdminUserCard from 'components/admin_console/admin_user_card/admin_user_c
 import BlockableLink from 'components/admin_console/blockable_link';
 import ResetPasswordModal from 'components/admin_console/reset_password_modal';
 import TeamList from 'components/admin_console/system_user_detail/team_list';
-import {ConfirmManageUserSettingsModal} from 'components/admin_console/system_users/system_users_list_actions/confirmManageUserSettingsModal';
+import ConfirmManageUserSettingsModal from 'components/admin_console/system_users/system_users_list_actions/confirm_manage_user_settings_modal';
 import ConfirmModal from 'components/confirm_modal';
 import FormError from 'components/form_error';
 import SaveButton from 'components/save_button';

webapp/channels/src/components/admin_console/system_users/system_users_list_actions/confirm_manage_user_settings_modal.tsx

@@ -14,10 +14,9 @@ type Props = {
     user: UserProfile;
     onConfirm: () => void;
     onExited: () => void;
-    onHide: () => void;
 }
 
-export function ConfirmManageUserSettingsModal(props: Props) {
+export default function ConfirmManageUserSettingsModal(props: Props) {
     const title = (
         <FormattedMessage
             id='userSettings.adminMode.modal_header'

webapp/channels/src/components/admin_console/system_users/system_users_list_actions/index.tsx

@@ -2,7 +2,7 @@
 // See LICENSE.txt for license information.
 
 import classNames from 'classnames';
-import React, {useCallback} from 'react';
+import React, {useCallback, useMemo} from 'react';
 import {FormattedMessage, useIntl} from 'react-intl';
 import {useDispatch, useSelector} from 'react-redux';
 
@@ -14,6 +14,7 @@ import {Permissions} from 'mattermost-redux/constants';
 import General from 'mattermost-redux/constants/general';
 import {getConfig} from 'mattermost-redux/selectors/entities/admin';
 import {getLicense} from 'mattermost-redux/selectors/entities/general';
+import {haveISystemPermission} from 'mattermost-redux/selectors/entities/roles_helpers';
 import {isSystemAdmin, isGuest} from 'mattermost-redux/utils/user_utils';
 
 import {adminResetMfa} from 'actions/admin_actions';
@@ -25,15 +26,15 @@ import ManageTeamsModal from 'components/admin_console/manage_teams_modal';
 import ManageTokensModal from 'components/admin_console/manage_tokens_modal';
 import ResetEmailModal from 'components/admin_console/reset_email_modal';
 import ResetPasswordModal from 'components/admin_console/reset_password_modal';
-import {
-    ConfirmManageUserSettingsModal,
-} from 'components/admin_console/system_users/system_users_list_actions/confirmManageUserSettingsModal';
 import * as Menu from 'components/menu';
 import SystemPermissionGate from 'components/permissions_gates/system_permission_gate';
 import UserSettingsModal from 'components/user_settings/modal';
 
 import Constants, {ModalIdentifiers} from 'utils/constants';
 
+import type {GlobalState} from 'types/store';
+
+import ConfirmManageUserSettingsModal from './confirm_manage_user_settings_modal';
 import CreateGroupSyncablesMembershipsModal from './create_group_syncables_membership_modal';
 import DeactivateMemberModal from './deactivate_member_modal';
 import DemoteToGuestModal from './demote_to_guest_modal';
@@ -54,6 +55,7 @@ export function SystemUsersListAction({user, currentUser, tableId, rowIndex, onE
     const dispatch = useDispatch();
     const config = useSelector(getConfig);
     const isLicensed = useSelector(getLicense)?.IsLicensed === 'true';
+    const haveSysConsoleWriteUserManagementUsersPermissions = useSelector((state: GlobalState) => haveISystemPermission(state, {permission: Permissions.SYSCONSOLE_WRITE_USERMANAGEMENT_USERS}));
     const showManageUserSettings = useSelector(getShowManageUserSettings);
 
     function getTranslatedUserRole(userRoles: UserProfile['roles']) {
@@ -92,40 +94,222 @@ export function SystemUsersListAction({user, currentUser, tableId, rowIndex, onE
     const menuId = `actionMenu-${tableId}-${rowIndex}`;
     const menuItemIdPrefix = `actionMenuItem-${tableId}-${rowIndex}`;
 
+    const isCurrentUserSystemAdmin = useMemo(() => isSystemAdmin(currentUser.roles), [currentUser.roles]);
+
     // Disable if SystemAdmin being edited by non SystemAdmin eg. userManager with EditOtherUsers permissions
-    const isDisabled = !isSystemAdmin(currentUser.roles) && isSystemAdmin(user.roles);
+    const isNonSystemAdminEditingSystemAdmin = !isCurrentUserSystemAdmin && isSystemAdmin(user.roles);
+    const disableEditingOtherUsers = isNonSystemAdminEditingSystemAdmin || !haveSysConsoleWriteUserManagementUsersPermissions;
 
-    const onDeactivateMember = () => updateUser({delete_at: new Date().getMilliseconds()});
+    const handleManageRolesClick = useCallback(() => {
-    const onUpdateRoles = (roles: string) => updateUser({roles});
+        function onRoleUpdateSuccess(roles: string) {
-    const onSwitchToEmailPassword = () => updateUser({auth_service: undefined});
+            updateUser({roles});
-    const onUpdateEmail = (email: string) => updateUser({email});
+        }
-    const onPromoteToMember = () => updateUser({roles: user.roles.replace(General.SYSTEM_GUEST_ROLE, '')});
-    const onDemoteToGuest = () => updateUser({roles: `${user.roles} ${General.SYSTEM_GUEST_ROLE}`});
 
-    const openUserSettingsModal = useCallback(() => {
         dispatch(openModal({
-            modalId: ModalIdentifiers.USER_SETTINGS,
+            modalId: ModalIdentifiers.MANAGE_ROLES_MODAL,
-            dialogType: UserSettingsModal,
+            dialogType: ManageRolesModal,
             dialogProps: {
-                adminMode: true,
+                user,
-                isContentProductSettings: true,
+                onSuccess: onRoleUpdateSuccess,
-                userID: user.id,
             },
         }));
-    }, [dispatch, user.id]);
+    }, [user, updateUser]);
+
+    const handleManageTeamsClick = useCallback(() => {
+        dispatch(openModal({
+            modalId: ModalIdentifiers.MANAGE_TEAMS_MODAL,
+            dialogType: ManageTeamsModal,
+            dialogProps: {
+                user,
+            },
+        }));
+    }, [user]);
+
+    const handleManageUserSettingsClick = useCallback(() => {
+        function onConfirmManageUserSettingsClick() {
+            dispatch(openModal({
+                modalId: ModalIdentifiers.USER_SETTINGS,
+                dialogType: UserSettingsModal,
+                dialogProps: {
+                    adminMode: true,
+                    isContentProductSettings: true,
+                    userID: user.id,
+                },
+            }));
+        }
+
+        dispatch(openModal({
+            modalId: ModalIdentifiers.CONFIRM_MANAGE_USER_SETTINGS_MODAL,
+            dialogType: ConfirmManageUserSettingsModal,
+            dialogProps: {
+                user,
+                onConfirm: onConfirmManageUserSettingsClick,
+            },
+        }));
+    }, [user]);
+
+    const handleManageTokensClick = useCallback(() => {
+        dispatch(openModal({
+            modalId: ModalIdentifiers.MANAGE_TOKENS_MODAL,
+            dialogType: ManageTokensModal,
+            dialogProps: {
+                user,
+            },
+        }));
+    }, [user.id]);
+
+    const handleResetPasswordClick = useCallback(() => {
+        dispatch(openModal({
+            modalId: ModalIdentifiers.RESET_PASSWORD_MODAL,
+            dialogType: ResetPasswordModal,
+            dialogProps: {
+                user,
+            },
+        }));
+    }, [user]);
+
+    const handleRemoveMfaClick = useCallback(async () => {
+        await adminResetMfa(user.id, null, onError).then(() => {
+            updateUser({mfa_active: false});
+        });
+
+        try {
+            await adminResetMfa(user.id, null, onError);
+            updateUser({mfa_active: false});
+        } catch (error) {
+            onError(error);
+        }
+    }, [user.id, updateUser, onError]);
+
+    const handleSwitchToEmailPasswordClick = useCallback(() => {
+        function onSwitchToEmailPasswordSuccess() {
+            updateUser({auth_service: undefined});
+        }
+
+        dispatch(openModal({
+            modalId: ModalIdentifiers.RESET_PASSWORD_MODAL,
+            dialogType: ResetPasswordModal,
+            dialogProps: {
+                user,
+                onSuccess: onSwitchToEmailPasswordSuccess,
+            },
+        }));
+    }, [user, updateUser]);
+
+    const handleUpdateEmailClick = useCallback(() => {
+        function onUpdateEmailSuccess(email: string) {
+            updateUser({email});
+        }
+
+        dispatch(openModal({
+            modalId: ModalIdentifiers.RESET_EMAIL_MODAL,
+            dialogType: ResetEmailModal,
+            dialogProps: {
+                user,
+                onSuccess: onUpdateEmailSuccess,
+            },
+        }));
+    }, [user, updateUser]);
+
+    const handlePromoteToMemberClick = useCallback(() => {
+        function onPromoteToMemberSuccess() {
+            updateUser({roles: user.roles.replace(General.SYSTEM_GUEST_ROLE, '')});
+        }
+
+        dispatch(openModal({
+            modalId: ModalIdentifiers.PROMOTE_TO_MEMBER_MODAL,
+            dialogType: PromoteToMemberModal,
+            dialogProps: {
+                user,
+                onError,
+                onSuccess: onPromoteToMemberSuccess,
+            },
+        }));
+    }, [user, updateUser, onError]);
+
+    const handleDemoteToGuestClick = useCallback(() => {
+        function onDemoteToGuestSuccess() {
+            updateUser({roles: `${user.roles} ${General.SYSTEM_GUEST_ROLE}`});
+        }
+
+        dispatch(openModal({
+            modalId: ModalIdentifiers.DEMOTE_TO_GUEST_MODAL,
+            dialogType: DemoteToGuestModal,
+            dialogProps: {
+                user,
+                onError,
+                onSuccess: onDemoteToGuestSuccess,
+            },
+        }));
+    }, [user, updateUser, onError]);
+
+    const handleRemoveSessionsClick = useCallback(() => {
+        dispatch(openModal({
+            modalId: ModalIdentifiers.REVOKE_SESSIONS_MODAL,
+            dialogType: RevokeSessionsModal,
+            dialogProps: {
+                user,
+                currentUser,
+                onError,
+            },
+        }));
+    }, [user, currentUser.id, onError]);
+
+    const handleReSyncUserViaLdapGroupsClick = useCallback(() => {
+        dispatch(openModal({
+            modalId: ModalIdentifiers.CREATE_GROUP_SYNCABLES_MEMBERSHIP_MODAL,
+            dialogType: CreateGroupSyncablesMembershipsModal,
+            dialogProps: {
+                user,
+                onError,
+            },
+        }));
+    }, [user, onError]);
+
+    const handleActivateUserClick = useCallback(async () => {
+        if (user.auth_service === Constants.LDAP_SERVICE) {
+            return;
+        }
+
+        const {error} = await dispatch(updateUserActive(user.id, true));
+
+        if (error) {
+            onError(error);
+        } else {
+            updateUser({delete_at: 0});
+        }
+    }, [user.id, user.auth_service, updateUser, onError]);
+
+    const handleDeactivateMemberClick = useCallback(() => {
+        function onDeactivateMemberSuccess() {
+            updateUser({delete_at: new Date().getMilliseconds()});
+        }
+
+        dispatch(
+            openModal({
+                modalId: ModalIdentifiers.DEACTIVATE_MEMBER_MODAL,
+                dialogType: DeactivateMemberModal,
+                dialogProps: {
+                    user,
+                    onError,
+                    onSuccess: onDeactivateMemberSuccess,
+                },
+            }),
+        );
+    }, [user, updateUser, onError]);
 
     return (
         <Menu.Container
             menuButton={{
                 id: menuButtonId,
                 class: classNames('btn btn-quaternary btn-sm', {
-                    disabled: isDisabled,
+                    disabled: disableEditingOtherUsers,
                 }),
-                disabled: isDisabled,
+                disabled: disableEditingOtherUsers,
                 children: (
                     <>
                         {getTranslatedUserRole(user.roles)}
-                        {!isDisabled && (
+                        {!disableEditingOtherUsers && (
                             <i
                                 aria-hidden='true'
                                 className='icon icon-chevron-down'
@@ -142,74 +326,31 @@ export function SystemUsersListAction({user, currentUser, tableId, rowIndex, onE
                 }),
             }}
         >
-            {user.delete_at > 0 &&
+            {user.delete_at > 0 && (
-            <Menu.Item
+                <Menu.Item
-                id={`${menuItemIdPrefix}-active`}
+                    id={`${menuItemIdPrefix}-active`}
-                labels={
+                    labels={
-                    <FormattedMessage
+                        <FormattedMessage
-                        id='admin.system_users.list.actions.menu.activate'
+                            id='admin.system_users.list.actions.menu.activate'
-                        defaultMessage='Activate'
+                            defaultMessage='Activate'
-                    />
+                        />
-                }
-                disabled={user.auth_service === Constants.LDAP_SERVICE}
-                onClick={async () => {
-                    if (user.auth_service === Constants.LDAP_SERVICE) {
-                        return;
                     }
-
+                    disabled={user.auth_service === Constants.LDAP_SERVICE}
-                    const {error} = await dispatch(updateUserActive(user.id, true));
+                    onClick={handleActivateUserClick}
-                    if (error) {
+                />
-                        onError(error);
+            )}
-                    } else {
+            {isCurrentUserSystemAdmin &&
-                        updateUser({delete_at: 0});
+                <Menu.Item
+                    id={`${menuItemIdPrefix}-manageRoles`}
+                    labels={
+                        <FormattedMessage
+                            id='admin.system_users.list.actions.menu.manageRoles'
+                            defaultMessage='Manage roles'
+                        />
                     }
-                }}
+                    onClick={handleManageRolesClick}
-            />}
+                />
-
+            }
-            {user.delete_at === 0 &&
-            <Menu.Item
-                id={`${menuItemIdPrefix}-deactivate`}
-                isDestructive={true}
-                labels={
-                    <FormattedMessage
-                        id='admin.system_users.list.actions.menu.deactivate'
-                        defaultMessage='Deactivate'
-                    />
-                }
-                onClick={() => {
-                    dispatch(openModal({
-                        modalId: ModalIdentifiers.DEACTIVATE_MEMBER_MODAL,
-                        dialogType: DeactivateMemberModal,
-                        dialogProps: {
-                            user,
-                            onError,
-                            onSuccess: onDeactivateMember,
-                        },
-                    }));
-                }}
-            />}
-
-            {isSystemAdmin(currentUser.roles) &&
-            <Menu.Item
-                id={`${menuItemIdPrefix}-manageRoles`}
-                labels={
-                    <FormattedMessage
-                        id='admin.system_users.list.actions.menu.manageRoles'
-                        defaultMessage='Manage roles'
-                    />
-                }
-                onClick={() => {
-                    dispatch(openModal({
-                        modalId: ModalIdentifiers.MANAGE_ROLES_MODAL,
-                        dialogType: ManageRolesModal,
-                        dialogProps: {
-                            user,
-                            onSuccess: onUpdateRoles,
-                        },
-                    }));
-                }}
-            />}
-
             <Menu.Item
                 id={`${menuItemIdPrefix}-manageTeams`}
                 labels={
@@ -218,212 +359,145 @@ export function SystemUsersListAction({user, currentUser, tableId, rowIndex, onE
                         defaultMessage='Manage teams'
                     />
                 }
-                onClick={() => {
+                onClick={handleManageTeamsClick}
-                    dispatch(openModal({
-                        modalId: ModalIdentifiers.MANAGE_TEAMS_MODAL,
-                        dialogType: ManageTeamsModal,
-                        dialogProps: {user},
-                    }));
-                }}
             />
-
+            {showManageUserSettings &&
-            {
-                showManageUserSettings &&
                 <Menu.Item
                     id={`${menuItemIdPrefix}-manageTeams`}
                     labels={
                         <FormattedMessage
-                            id='admin.user_item.manageSettings'
+                            id='admin.system_users.list.actions.menu.manageSettings'
-                            defaultMessage='Manage User Settings'
+                            defaultMessage='Manage user settings'
                         />
                     }
-                    onClick={() => {
+                    onClick={handleManageUserSettingsClick}
-                        dispatch(openModal({
-                            modalId: ModalIdentifiers.CONFIRM_MANAGE_USER_SETTINGS_MODAL,
-                            dialogType: ConfirmManageUserSettingsModal,
-                            dialogProps: {
-                                user,
-                                onConfirm: openUserSettingsModal,
-                            },
-                        }));
-                    }}
                 />
             }
-
             {config.ServiceSettings?.EnableUserAccessTokens &&
-            <Menu.Item
-                id={`${menuItemIdPrefix}-manageTokens`}
-                labels={
-                    <FormattedMessage
-                        id='admin.system_users.list.actions.menu.manageTokens'
-                        defaultMessage='Manage tokens'
-                    />
-                }
-                onClick={() => {
-                    dispatch(openModal({
-                        modalId: ModalIdentifiers.MANAGE_TOKENS_MODAL,
-                        dialogType: ManageTokensModal,
-                        dialogProps: {user},
-                    }));
-                }}
-            />}
-
-            {!user.auth_service &&
-            <Menu.Item
-                id={`${menuItemIdPrefix}-resetPassword`}
-                labels={
-                    <FormattedMessage
-                        id='admin.system_users.list.actions.menu.resetPassword'
-                        defaultMessage='Reset password'
-                    />
-                }
-                onClick={() => {
-                    dispatch(openModal({
-                        modalId: ModalIdentifiers.RESET_PASSWORD_MODAL,
-                        dialogType: ResetPasswordModal,
-                        dialogProps: {user},
-                    }));
-                }}
-            />}
-
-            {user.mfa_active && config.ServiceSettings?.EnableMultifactorAuthentication &&
-            <Menu.Item
-                id={`${menuItemIdPrefix}-removeMFA`}
-                labels={
-                    <FormattedMessage
-                        id='admin.system_users.list.actions.menu.removeMFA'
-                        defaultMessage='Remove MFA'
-                    />
-                }
-                onClick={() => {
-                    adminResetMfa(user.id, null, onError).then(() => {
-                        updateUser({mfa_active: false});
-                    });
-                }}
-            />}
-
-            {Boolean(user.auth_service) && config.ServiceSettings?.ExperimentalEnableAuthenticationTransfer &&
-            <Menu.Item
-                id={`${menuItemIdPrefix}-switchToEmailPassword`}
-                labels={
-                    <FormattedMessage
-                        id='admin.system_users.list.actions.menu.switchToEmailPassword'
-                        defaultMessage='Switch to Email/Password'
-                    />
-                }
-                onClick={() => {
-                    dispatch(openModal({
-                        modalId: ModalIdentifiers.RESET_PASSWORD_MODAL,
-                        dialogType: ResetPasswordModal,
-                        dialogProps: {
-                            user,
-                            onSuccess: onSwitchToEmailPassword,
-                        },
-                    }));
-                }}
-            />}
-
-            {!user.auth_service &&
-            <Menu.Item
-                id={`${menuItemIdPrefix}-updateEmail`}
-                labels={
-                    <FormattedMessage
-                        id='admin.system_users.list.actions.menu.updateEmail'
-                        defaultMessage='Update email'
-                    />
-                }
-                onClick={() => {
-                    dispatch(openModal({
-                        modalId: ModalIdentifiers.RESET_EMAIL_MODAL,
-                        dialogType: ResetEmailModal,
-                        dialogProps: {
-                            user,
-                            onSuccess: onUpdateEmail,
-                        },
-                    }));
-                }}
-            />}
-
-            {isGuest(user.roles) &&
-            <Menu.Item
-                id={`${menuItemIdPrefix}-promoteToMember`}
-                labels={
-                    <FormattedMessage
-                        id='admin.system_users.list.actions.menu.promoteToMember'
-                        defaultMessage='Promote to member'
-                    />
-                }
-                onClick={() => {
-                    dispatch(openModal({
-                        modalId: ModalIdentifiers.PROMOTE_TO_MEMBER_MODAL,
-                        dialogType: PromoteToMemberModal,
-                        dialogProps: {
-                            user,
-                            onError,
-                            onSuccess: onPromoteToMember,
-                        },
-                    }));
-                }}
-            />}
-            {!isGuest(user.roles) && user.id !== currentUser.id && isLicensed && config.GuestAccountsSettings?.Enable &&
-            <Menu.Item
-                id={`${menuItemIdPrefix}-demoteToGuest`}
-                labels={
-                    <FormattedMessage
-                        id='admin.system_users.list.actions.menu.demoteToGuest'
-                        defaultMessage='Demote to guest'
-                    />
-                }
-                onClick={() => {
-                    dispatch(openModal({
-                        modalId: ModalIdentifiers.DEMOTE_TO_GUEST_MODAL,
-                        dialogType: DemoteToGuestModal,
-                        dialogProps: {
-                            user,
-                            onError,
-                            onSuccess: onDemoteToGuest,
-                        },
-                    }));
-                }}
-            />}
-            <SystemPermissionGate permissions={[Permissions.REVOKE_USER_ACCESS_TOKEN]}>
-                {!user.delete_at &&
                 <Menu.Item
-                    id={`${menuItemIdPrefix}-removeSessions`}
+                    id={`${menuItemIdPrefix}-manageTokens`}
                     labels={
                         <FormattedMessage
-                            id='admin.system_users.list.actions.menu.removeSessions'
+                            id='admin.system_users.list.actions.menu.manageTokens'
-                            defaultMessage='Remove sessions'
+                            defaultMessage='Manage tokens'
                         />
                     }
-                    onClick={() => {
+                    onClick={handleManageTokensClick}
-                        dispatch(openModal({
+                />
-                            modalId: ModalIdentifiers.REVOKE_SESSIONS_MODAL,
+            }
-                            dialogType: RevokeSessionsModal,
+            {!user.auth_service &&
-                            dialogProps: {user, currentUser, onError},
+                <Menu.Item
-                        }));
+                    id={`${menuItemIdPrefix}-resetPassword`}
-                    }}
+                    labels={
-                />}
+                        <FormattedMessage
+                            id='admin.system_users.list.actions.menu.resetPassword'
+                            defaultMessage='Reset password'
+                        />
+                    }
+                    onClick={handleResetPasswordClick}
+                />
+            }
+            {user.mfa_active && config.ServiceSettings?.EnableMultifactorAuthentication &&
+                <Menu.Item
+                    id={`${menuItemIdPrefix}-removeMFA`}
+                    labels={
+                        <FormattedMessage
+                            id='admin.system_users.list.actions.menu.removeMFA'
+                            defaultMessage='Remove MFA'
+                        />
+                    }
+                    onClick={handleRemoveMfaClick}
+                />
+            }
+            {Boolean(user.auth_service) && config.ServiceSettings?.ExperimentalEnableAuthenticationTransfer &&
+                <Menu.Item
+                    id={`${menuItemIdPrefix}-switchToEmailPassword`}
+                    labels={
+                        <FormattedMessage
+                            id='admin.system_users.list.actions.menu.switchToEmailPassword'
+                            defaultMessage='Switch to Email/Password'
+                        />
+                    }
+                    onClick={handleSwitchToEmailPasswordClick}
+                />
+            }
+            {!user.auth_service &&
+                <Menu.Item
+                    id={`${menuItemIdPrefix}-updateEmail`}
+                    labels={
+                        <FormattedMessage
+                            id='admin.system_users.list.actions.menu.updateEmail'
+                            defaultMessage='Update email'
+                        />
+                    }
+                    onClick={handleUpdateEmailClick}
+                />
+            }
+            {isGuest(user.roles) &&
+                <Menu.Item
+                    id={`${menuItemIdPrefix}-promoteToMember`}
+                    labels={
+                        <FormattedMessage
+                            id='admin.system_users.list.actions.menu.promoteToMember'
+                            defaultMessage='Promote to member'
+                        />
+                    }
+                    onClick={handlePromoteToMemberClick}
+                />
+            }
+            {!isGuest(user.roles) && user.id !== currentUser.id && isLicensed && config.GuestAccountsSettings?.Enable &&
+                <Menu.Item
+                    id={`${menuItemIdPrefix}-demoteToGuest`}
+                    labels={
+                        <FormattedMessage
+                            id='admin.system_users.list.actions.menu.demoteToGuest'
+                            defaultMessage='Demote to guest'
+                        />
+                    }
+                    onClick={handleDemoteToGuestClick}
+                />
+            }
+            <SystemPermissionGate permissions={[Permissions.REVOKE_USER_ACCESS_TOKEN]}>
+                {!user.delete_at &&
+                    <Menu.Item
+                        id={`${menuItemIdPrefix}-removeSessions`}
+                        labels={
+                            <FormattedMessage
+                                id='admin.system_users.list.actions.menu.removeSessions'
+                                defaultMessage='Remove sessions'
+                            />
+                        }
+                        onClick={handleRemoveSessionsClick}
+                    />
+                }
             </SystemPermissionGate>
             <SystemPermissionGate permissions={[Permissions.SYSCONSOLE_WRITE_USERMANAGEMENT_GROUPS]}>
                 {(user.auth_service === Constants.LDAP_SERVICE || (user.auth_service === Constants.SAML_SERVICE && config.SamlSettings?.EnableSyncWithLdap)) &&
+                    <Menu.Item
+                        id={`${menuItemIdPrefix}-resyncUserViaLdapGroups`}
+                        labels={
+                            <FormattedMessage
+                                id='admin.system_users.list.actions.menu.resyncUserViaLdapGroups'
+                                defaultMessage='Re-sync user via LDAP groups'
+                            />
+                        }
+                        onClick={handleReSyncUserViaLdapGroupsClick}
+                    />
+                }
+            </SystemPermissionGate>
+            {user.delete_at === 0 && (
                 <Menu.Item
-                    id={`${menuItemIdPrefix}-resyncUserViaLdapGroups`}
+                    id={`${menuItemIdPrefix}-deactivate`}
+                    isDestructive={true}
                     labels={
                         <FormattedMessage
-                            id='admin.system_users.list.actions.menu.resyncUserViaLdapGroups'
+                            id='admin.system_users.list.actions.menu.deactivate'
-                            defaultMessage='Re-sync user via LDAP groups'
+                            defaultMessage='Deactivate'
                         />
                     }
-                    onClick={() => {
+                    onClick={handleDeactivateMemberClick}
-                        dispatch(openModal({
+                />
-                            modalId: ModalIdentifiers.CREATE_GROUP_SYNCABLES_MEMBERSHIP_MODAL,
+            )}
-                            dialogType: CreateGroupSyncablesMembershipsModal,
-                            dialogProps: {user, onError},
-                        }));
-                    }}
-                />}
-            </SystemPermissionGate>
         </Menu.Container>
     );
 }

webapp/channels/src/i18n/en.json

@@ -2494,6 +2494,7 @@
   "admin.system_users.list.actions.menu.demoteToGuest": "Demote to guest",
   "admin.system_users.list.actions.menu.dropdownAriaLabel": "User actions menu",
   "admin.system_users.list.actions.menu.manageRoles": "Manage roles",
+  "admin.system_users.list.actions.menu.manageSettings": "Manage user settings",
   "admin.system_users.list.actions.menu.manageTeams": "Manage teams",
   "admin.system_users.list.actions.menu.manageTokens": "Manage tokens",
   "admin.system_users.list.actions.menu.promoteToMember": "Promote to member",