Channel Bookmarks (#25449)

* create ChannelBookmarks table

* ChannelBookmark model

* channel bookamrks Store layer

* add GetBookmarksForAllChannelByIdSince

* add channel bookmarks to test store

* Add channel bookmarks to app layer

* remove index for createAt in channel bookmarks migrations

* remove createAt from select channel bookmark query and enable store delete bookmark test

* update reponse of UpdateBookmark

* rename db migration files

* channel bookmarks store update sort order

* channel bookmarks app layer update sort order

* fix lint & tests

* Fix lint and introduce util functions to insert / remove from slice

* remove model etag

* i18n

* defer remove file info after test run

* Fix tests passing the request context

* fix migrations

* fix TestRetry

* Add bookmark permissions (#25560)

* Adds channel bookmarks permissions

* Fix linter

* Remove unnecessary empty lines

* Remove scss change as it's not necessary anymore

* Fix mock store

* Fix mock store and add role entry

* Fix test

* Adds cypress test and update permissions migration to update admin roles

* Adds channel bookmarks roles to default admin roles

* Adds bookmark permissions to default role permissions constant in webapp

* Update mmctl test

* Update permission test after normalising the roles

* fix store tests

* fix app layer tests

* Add new bookmark endpoint (#25624)

* Adds channel bookmarks api scaffold and create endpoint

* Applies review comments to the API docs

* Adds websocket test to create channel bookmark

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

* MM-54426 exclude Channel Bookmarks files from data retention (#25656)

* Augment channel APIs to include bookmarks (#25567)

* update files docs for server 9.4

* Adds update channel bookmark endpoint (#25653)

* Adds update channel bookmark sort order endpoint (#25686)

* Adds update channel bookmark endpoint

* Updates edit app method to return the right deleted bookmark and adds tests

* Adds the update channel bookmark sort order endpoint

* Fix repeated test after merge

* Assign right permissions to each test

* Update store and app layer to return specific errors and add tests

* Adds delete channel bookmark endpoint (#25693)

* Updates edit app method to return the right deleted bookmark and adds tests

* Fix repeated test after merge

* Updates edit app method to return the right deleted bookmark and adds tests

* Adds delete channel bookmark endpoint

* Adds list channel bookmarks endpoint (#25700)

* Add channel moderation to bookmarks (#25716)

* fix migrations index

* fix getChannelsForTeamForUser

* fix getChannelsForTeamForUser

* fix bad merge client4

* fix file api with bookmark permission

* add ChannelBookmarks feature flag

* add missing translations

* Set DB column for type as enum

* use custom type for bookmark query using sqlx

* use transaction when saving bookmark

* return NewErrNotFound instead of Sql.ErrNoRows

* use squirrel for IN query

* add a limit of 1K for records in GetBookmarksForAllChannelByIdSince

* UpdateSortOrder with one single query instead of multiple updates

* fix shadow declaration

* fix channel bookmarks permission string definition in admin console

* fix another shadow declaration

* Fix model conversion

* add SplitSliceInChunks

* remove include bookmarks in channels api

* Cap amount of bookmarks per channel

* add etag back to get channels

* feedback review

* update file info when replacing a bookmark file

* return 501 not implemented when the license is not available

* add detail message when getting channel member on bookmark api

* start audit before permission check on create bookmark api

* use require.Eventuallyf for testing WS events

* remove unnecessary log in app layer

* use require instead of assert to avoid panics

* enforce limit when querying bookmarks since

* prevent to create/update bookmark if file is already attached

* fix lint

* delete file when a bookmark is deleted

* Dot allow to set a fileId and a url at the same time to a bookmark

* fix query to delete a file that belongs to a bookmark

* do not patch the bookmark type

* Server side FeatureFlag check (#26145)

* use ff in server, set ff to false

* turn on FF for unit tests

* defer unset FF for unit tests

* turn ff on for testing

* only allow attaching files that were uploaded for bookmark

* Set feature flag off as default

* fix lint

* update email templates as PR failed

* revert templates

* force the assignment of ID when creating a bookmark

* Fix unit tests

---------

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Caleb Roseland <caleb@calebroseland.com>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>

server/channels/db/migrations/migrations.list

@@ -236,6 +236,8 @@ channels/db/migrations/mysql/000118_create_index_poststats.down.sql
 channels/db/migrations/mysql/000118_create_index_poststats.up.sql
 channels/db/migrations/mysql/000119_msteams_shared_channels_opts.down.sql
 channels/db/migrations/mysql/000119_msteams_shared_channels_opts.up.sql
+channels/db/migrations/mysql/000120_create_channelbookmarks_table.down.sql
+channels/db/migrations/mysql/000120_create_channelbookmarks_table.up.sql
 channels/db/migrations/postgres/000001_create_teams.down.sql
 channels/db/migrations/postgres/000001_create_teams.up.sql
 channels/db/migrations/postgres/000002_create_team_members.down.sql
@@ -472,3 +474,5 @@ channels/db/migrations/postgres/000118_create_index_poststats.down.sql
 channels/db/migrations/postgres/000118_create_index_poststats.up.sql
 channels/db/migrations/postgres/000119_msteams_shared_channels_opts.down.sql
 channels/db/migrations/postgres/000119_msteams_shared_channels_opts.up.sql
+channels/db/migrations/postgres/000120_create_channelbookmarks_table.down.sql
+channels/db/migrations/postgres/000120_create_channelbookmarks_table.up.sql

server/channels/db/migrations/mysql/000120_create_channelbookmarks_table.down.sql

@@ -0,0 +1 @@
+DROP TABLE IF EXISTS ChannelBookmarks;

server/channels/db/migrations/mysql/000120_create_channelbookmarks_table.up.sql

@@ -0,0 +1,21 @@
+CREATE TABLE IF NOT EXISTS ChannelBookmarks (
+    Id varchar(26) NOT NULL,
+    OwnerId varchar(26) NOT NULL,
+    ChannelId varchar(26) NOT NULL,
+    FileInfoId varchar(26) DEFAULT NULL,
+    CreateAt bigint(20) DEFAULT 0,
+    UpdateAt bigint(20) DEFAULT 0,
+    DeleteAt bigint(20) DEFAULT 0,
+    DisplayName text,
+    SortOrder bigint(20) DEFAULT 0,
+    LinkUrl text DEFAULT NULL,
+    ImageUrl text DEFAULT NULL,
+    Emoji varchar(64) DEFAULT NULL,
+    Type ENUM('link', 'file'),
+    OriginalId varchar(26) DEFAULT NULL,
+    ParentId varchar(26) DEFAULT NULL,
+    PRIMARY KEY (Id),
+    KEY idx_channelbookmarks_channelid (ChannelId),
+    KEY idx_channelbookmarks_update_at (UpdateAt),
+    KEY idx_channelbookmarks_delete_at (DeleteAt)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;

server/channels/db/migrations/postgres/000120_create_channelbookmarks_table.down.sql

@@ -0,0 +1,18 @@
+DROP INDEX IF EXISTS idx_channelbookmarks_channelid;
+DROP INDEX IF EXISTS idx_channelbookmarks_update_at;
+DROP INDEX IF EXISTS idx_channelbookmarks_delete_at;
+
+DROP TABLE IF EXISTS channelbookmarks;
+
+DO
+$$
+BEGIN
+  IF EXISTS (SELECT * FROM pg_type typ
+                            INNER JOIN pg_namespace nsp ON nsp.oid = typ.typnamespace
+                        WHERE nsp.nspname = current_schema()
+                            AND typ.typname = 'channel_bookmark_type') THEN
+    DROP TYPE channel_bookmark_type;
+  END IF;
+END;
+$$
+LANGUAGE plpgsql;

server/channels/db/migrations/postgres/000120_create_channelbookmarks_table.up.sql

@@ -0,0 +1,34 @@
+DO
+$$
+BEGIN
+  IF NOT EXISTS (SELECT * FROM pg_type typ
+                            INNER JOIN pg_namespace nsp ON nsp.oid = typ.typnamespace
+                        WHERE nsp.nspname = current_schema()
+                            AND typ.typname = 'channel_bookmark_type') THEN
+    CREATE TYPE channel_bookmark_type AS ENUM ('link', 'file');
+  END IF;
+END;
+$$
+LANGUAGE plpgsql;
+
+CREATE TABLE IF NOT EXISTS channelbookmarks (
+    id varchar(26) PRIMARY KEY,
+    ownerid varchar(26) NOT NULL,
+    channelid varchar(26) NOT NULL,
+    fileinfoid varchar(26) DEFAULT NULL,
+    createat bigint DEFAULT 0,
+    updateat bigint DEFAULT 0,
+    deleteat bigint DEFAULT 0,
+    displayname text DEFAULT '',
+    sortorder integer DEFAULT 0,
+    linkurl text DEFAULT NULL,
+    imageurl text DEFAULT NULL,
+    emoji varchar(64) DEFAULT NULL,
+    type channel_bookmark_type DEFAULT 'link',
+    originalid varchar(26) DEFAULT NULL,
+    parentid varchar(26) DEFAULT NULL
+);
+
+CREATE INDEX IF NOT EXISTS idx_channelbookmarks_channelid ON channelbookmarks (channelid);
+CREATE INDEX IF NOT EXISTS idx_channelbookmarks_update_at ON channelbookmarks (updateat);
+CREATE INDEX IF NOT EXISTS idx_channelbookmarks_delete_at ON channelbookmarks (deleteat);