From 7e621975205add7ab1b52cc4354ea387f81d1c70 Mon Sep 17 00:00:00 2001 From: Arya Khochare <91268931+Aryakoste@users.noreply.github.com> Date: Fri, 4 Oct 2024 13:04:29 +0530 Subject: [PATCH] errcheck issues fixed (#28476) --- server/.golangci.yml | 1 - server/channels/api4/post.go | 12 +++++++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index 0eabc70d67..efc67641c1 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -98,7 +98,6 @@ issues: channels/api4/permission.go|\ channels/api4/plugin.go|\ channels/api4/plugin_test.go|\ - channels/api4/post.go|\ channels/api4/post_test.go|\ channels/api4/preference_test.go|\ channels/api4/reaction.go|\ diff --git a/server/channels/api4/post.go b/server/channels/api4/post.go index d41f58e3f2..559fec1c4d 100644 --- a/server/channels/api4/post.go +++ b/server/channels/api4/post.go @@ -1127,7 +1127,9 @@ func acknowledgePost(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(js) + if _, err := w.Write(js); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func unacknowledgePost(c *Context, w http.ResponseWriter, r *http.Request) { @@ -1284,7 +1286,9 @@ func getFileInfosForPost(c *Context, w http.ResponseWriter, r *http.Request) { w.Header().Set("Cache-Control", "max-age=2592000, private") w.Header().Set(model.HeaderEtagServer, model.GetEtagForFileInfos(infos)) - w.Write(js) + if _, err := w.Write(js); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func getPostInfo(c *Context, w http.ResponseWriter, r *http.Request) { @@ -1305,7 +1309,9 @@ func getPostInfo(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(js) + if _, err := w.Write(js); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func hasPermittedWranglerRole(c *Context, user *model.User, channelMember *model.ChannelMember) bool {