Remove global cfg vars (#8099)

* remove global cfg vars

* enterprise update

utils/config.go

@@ -4,7 +4,6 @@
 package utils
 
 import (
-	"crypto/md5"
 	"encoding/json"
 	"fmt"
 	"io"
@@ -14,7 +13,6 @@ import (
 	"path/filepath"
 	"strconv"
 	"strings"
-	"sync"
 
 	l4g "github.com/alecthomas/log4go"
 	"github.com/fsnotify/fsnotify"
@@ -35,12 +33,9 @@ const (
 	LOG_FILENAME    = "mattermost.log"
 )
 
-var cfgMutex = &sync.Mutex{}
-var Cfg *model.Config = &model.Config{}
-var CfgHash = ""
-var CfgFileName string = ""
 var originalDisableDebugLvl l4g.Level = l4g.DEBUG
 var siteURL = ""
+var Cfg *model.Config
 
 func GetSiteURL() string {
 	return siteURL
@@ -50,22 +45,6 @@ func SetSiteURL(url string) {
 	siteURL = strings.TrimRight(url, "/")
 }
 
-var cfgListeners = map[string]func(*model.Config, *model.Config){}
-
-// Registers a function with a given to be called when the config is reloaded and may have changed. The function
-// will be called with two arguments: the old config and the new config. AddConfigListener returns a unique ID
-// for the listener that can later be used to remove it.
-func AddConfigListener(listener func(*model.Config, *model.Config)) string {
-	id := model.NewId()
-	cfgListeners[id] = listener
-	return id
-}
-
-// Removes a listener function by the unique ID returned when AddConfigListener was called
-func RemoveConfigListener(id string) {
-	delete(cfgListeners, id)
-}
-
 // FindConfigFile attempts to find an existing configuration file. fileName can be an absolute or
 // relative path or name such as "/opt/mattermost/config.json" or simply "config.json". An empty
 // string is returned if no configuration is found.
@@ -103,8 +82,6 @@ func FindDir(dir string) (string, bool) {
 }
 
 func DisableDebugLogForTest() {
-	cfgMutex.Lock()
-	defer cfgMutex.Unlock()
 	if l4g.Global["stdout"] != nil {
 		originalDisableDebugLvl = l4g.Global["stdout"].Level
 		l4g.Global["stdout"].Level = l4g.ERROR
@@ -112,8 +89,6 @@ func DisableDebugLogForTest() {
 }
 
 func EnableDebugLogForTest() {
-	cfgMutex.Lock()
-	defer cfgMutex.Unlock()
 	if l4g.Global["stdout"] != nil {
 		l4g.Global["stdout"].Level = originalDisableDebugLvl
 	}
@@ -123,12 +98,12 @@ func ConfigureCmdLineLog() {
 	ls := model.LogSettings{}
 	ls.EnableConsole = true
 	ls.ConsoleLevel = "WARN"
-	configureLog(&ls)
+	ConfigureLog(&ls)
 }
 
 // TODO: this code initializes console and file logging. It will eventually be replaced by JSON logging in logger/logger.go
 // See PLT-3893 for more information
-func configureLog(s *model.LogSettings) {
+func ConfigureLog(s *model.LogSettings) {
 
 	l4g.Close()
 
@@ -182,9 +157,6 @@ func GetLogFileLocation(fileLocation string) string {
 }
 
 func SaveConfig(fileName string, config *model.Config) *model.AppError {
-	cfgMutex.Lock()
-	defer cfgMutex.Unlock()
-
 	b, err := json.MarshalIndent(config, "", "    ")
 	if err != nil {
 		return model.NewAppError("SaveConfig", "utils.config.save_config.saving.app_error",
@@ -206,7 +178,7 @@ type ConfigWatcher struct {
 	closed  chan struct{}
 }
 
-func NewConfigWatcher(cfgFileName string) (*ConfigWatcher, error) {
+func NewConfigWatcher(cfgFileName string, f func()) (*ConfigWatcher, error) {
 	watcher, err := fsnotify.NewWatcher()
 	if err != nil {
 		return nil, errors.Wrapf(err, "failed to create config watcher for file: "+cfgFileName)
@@ -235,7 +207,7 @@ func NewConfigWatcher(cfgFileName string) (*ConfigWatcher, error) {
 						l4g.Info(fmt.Sprintf("Config file watcher detected a change reloading %v", cfgFileName))
 
 						if _, configReadErr := ReadConfigFile(cfgFileName, true); configReadErr == nil {
-							LoadGlobalConfig(cfgFileName)
+							f()
 						} else {
 							l4g.Error(fmt.Sprintf("Failed to read while watching config file at %v with err=%v", cfgFileName, configReadErr.Error()))
 						}
@@ -322,7 +294,7 @@ func EnsureConfigFile(fileName string) (string, error) {
 // LoadConfig will try to search around for the corresponding config file.  It will search
 // /tmp/fileName then attempt ./config/fileName, then ../config/fileName and last it will look at
 // fileName.
-func LoadConfig(fileName string) (configPath string, config *model.Config, appErr *model.AppError) {
+func LoadConfig(fileName string) (config *model.Config, configPath string, appErr *model.AppError) {
 	if fileName != filepath.Base(fileName) {
 		configPath = fileName
 	} else {
@@ -346,7 +318,7 @@ func LoadConfig(fileName string) (configPath string, config *model.Config, appEr
 	config.SetDefaults()
 
 	if err := config.IsValid(); err != nil {
-		return "", nil, err
+		return nil, "", err
 	}
 
 	if needSave {
@@ -368,41 +340,7 @@ func LoadConfig(fileName string) (configPath string, config *model.Config, appEr
 		}
 	}
 
-	return configPath, config, nil
-}
-
-// XXX: This is deprecated. Use LoadConfig instead if possible.
-func LoadGlobalConfig(fileName string) *model.Config {
-	configPath, config, err := LoadConfig(fileName)
-	if err != nil {
-		fmt.Fprintln(os.Stderr, err.SystemMessage(T))
-		os.Exit(1)
-	}
-
-	cfgMutex.Lock()
-	defer cfgMutex.Unlock()
-
-	CfgFileName = configPath
-
-	configureLog(&config.LogSettings)
-
-	// Cfg should never be null
-	oldConfig := *Cfg
-
-	Cfg = config
-	CfgHash = fmt.Sprintf("%x", md5.Sum([]byte(Cfg.ToJson())))
-
-	SetSiteURL(*Cfg.ServiceSettings.SiteURL)
-
-	InvokeGlobalConfigListeners(&oldConfig, config)
-
-	return config
-}
-
-func InvokeGlobalConfigListeners(old, current *model.Config) {
-	for _, listener := range cfgListeners {
-		listener(old, current)
-	}
+	return config, configPath, nil
 }
 
 func GenerateClientConfig(c *model.Config, diagnosticId string) map[string]string {
@@ -659,46 +597,3 @@ func ValidateLocales(cfg *model.Config) *model.AppError {
 
 	return err
 }
-
-func Desanitize(cfg *model.Config) {
-	if cfg.LdapSettings.BindPassword != nil && *cfg.LdapSettings.BindPassword == model.FAKE_SETTING {
-		*cfg.LdapSettings.BindPassword = *Cfg.LdapSettings.BindPassword
-	}
-
-	if *cfg.FileSettings.PublicLinkSalt == model.FAKE_SETTING {
-		*cfg.FileSettings.PublicLinkSalt = *Cfg.FileSettings.PublicLinkSalt
-	}
-	if cfg.FileSettings.AmazonS3SecretAccessKey == model.FAKE_SETTING {
-		cfg.FileSettings.AmazonS3SecretAccessKey = Cfg.FileSettings.AmazonS3SecretAccessKey
-	}
-
-	if cfg.EmailSettings.InviteSalt == model.FAKE_SETTING {
-		cfg.EmailSettings.InviteSalt = Cfg.EmailSettings.InviteSalt
-	}
-	if cfg.EmailSettings.SMTPPassword == model.FAKE_SETTING {
-		cfg.EmailSettings.SMTPPassword = Cfg.EmailSettings.SMTPPassword
-	}
-
-	if cfg.GitLabSettings.Secret == model.FAKE_SETTING {
-		cfg.GitLabSettings.Secret = Cfg.GitLabSettings.Secret
-	}
-
-	if *cfg.SqlSettings.DataSource == model.FAKE_SETTING {
-		*cfg.SqlSettings.DataSource = *Cfg.SqlSettings.DataSource
-	}
-	if cfg.SqlSettings.AtRestEncryptKey == model.FAKE_SETTING {
-		cfg.SqlSettings.AtRestEncryptKey = Cfg.SqlSettings.AtRestEncryptKey
-	}
-
-	if *cfg.ElasticsearchSettings.Password == model.FAKE_SETTING {
-		*cfg.ElasticsearchSettings.Password = *Cfg.ElasticsearchSettings.Password
-	}
-
-	for i := range cfg.SqlSettings.DataSourceReplicas {
-		cfg.SqlSettings.DataSourceReplicas[i] = Cfg.SqlSettings.DataSourceReplicas[i]
-	}
-
-	for i := range cfg.SqlSettings.DataSourceSearchReplicas {
-		cfg.SqlSettings.DataSourceSearchReplicas[i] = Cfg.SqlSettings.DataSourceSearchReplicas[i]
-	}
-}

utils/config_test.go

@@ -9,18 +9,16 @@ import (
 	"path/filepath"
 	"strings"
 	"testing"
-	"time"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-
-	"github.com/mattermost/mattermost-server/model"
 )
 
 func TestConfig(t *testing.T) {
 	TranslationsPreInit()
-	LoadGlobalConfig("config.json")
-	InitTranslations(Cfg.LocalizationSettings)
+	cfg, _, err := LoadConfig("config.json")
+	require.Nil(t, err)
+	InitTranslations(cfg.LocalizationSettings)
 }
 
 func TestFindConfigFile(t *testing.T) {
@@ -47,21 +45,22 @@ func TestConfigFromEnviroVars(t *testing.T) {
 	os.Setenv("MM_SERVICESETTINGS_READTIMEOUT", "400")
 
 	TranslationsPreInit()
-	LoadGlobalConfig("config.json")
+	cfg, cfgPath, err := LoadConfig("config.json")
+	require.Nil(t, err)
 
-	if Cfg.TeamSettings.SiteName != "From Enviroment" {
+	if cfg.TeamSettings.SiteName != "From Enviroment" {
 		t.Fatal("Couldn't read config from enviroment var")
 	}
 
-	if *Cfg.TeamSettings.CustomBrandText != "Custom Brand" {
+	if *cfg.TeamSettings.CustomBrandText != "Custom Brand" {
 		t.Fatal("Couldn't read config from enviroment var")
 	}
 
-	if *Cfg.ServiceSettings.EnableCommands {
+	if *cfg.ServiceSettings.EnableCommands {
 		t.Fatal("Couldn't read config from enviroment var")
 	}
 
-	if *Cfg.ServiceSettings.ReadTimeout != 400 {
+	if *cfg.ServiceSettings.ReadTimeout != 400 {
 		t.Fatal("Couldn't read config from enviroment var")
 	}
 
@@ -70,169 +69,67 @@ func TestConfigFromEnviroVars(t *testing.T) {
 	os.Unsetenv("MM_SERVICESETTINGS_ENABLECOMMANDS")
 	os.Unsetenv("MM_SERVICESETTINGS_READTIMEOUT")
 
-	Cfg.TeamSettings.SiteName = "Mattermost"
-	*Cfg.ServiceSettings.SiteURL = ""
-	*Cfg.ServiceSettings.EnableCommands = true
-	*Cfg.ServiceSettings.ReadTimeout = 300
-	SaveConfig(CfgFileName, Cfg)
+	cfg.TeamSettings.SiteName = "Mattermost"
+	*cfg.ServiceSettings.SiteURL = ""
+	*cfg.ServiceSettings.EnableCommands = true
+	*cfg.ServiceSettings.ReadTimeout = 300
+	SaveConfig(cfgPath, cfg)
 
-	LoadGlobalConfig("config.json")
+	cfg, _, err = LoadConfig("config.json")
+	require.Nil(t, err)
 
-	if Cfg.TeamSettings.SiteName != "Mattermost" {
+	if cfg.TeamSettings.SiteName != "Mattermost" {
 		t.Fatal("should have been reset")
 	}
 }
 
-func TestRedirectStdLog(t *testing.T) {
-	TranslationsPreInit()
-	LoadGlobalConfig("config.json")
-	InitTranslations(Cfg.LocalizationSettings)
-
-	log := NewRedirectStdLog("test", false)
-
-	log.Println("[DEBUG] this is a message")
-	log.Println("[DEBG] this is a message")
-	log.Println("[WARN] this is a message")
-	log.Println("[ERROR] this is a message")
-	log.Println("[EROR] this is a message")
-	log.Println("[ERR] this is a message")
-	log.Println("[INFO] this is a message")
-	log.Println("this is a message")
-
-	time.Sleep(time.Second * 1)
-}
-
-func TestAddRemoveConfigListener(t *testing.T) {
-	numIntitialCfgListeners := len(cfgListeners)
-
-	id1 := AddConfigListener(func(*model.Config, *model.Config) {
-	})
-	if len(cfgListeners) != numIntitialCfgListeners+1 {
-		t.Fatal("should now have 1 listener")
-	}
-
-	id2 := AddConfigListener(func(*model.Config, *model.Config) {
-	})
-	if len(cfgListeners) != numIntitialCfgListeners+2 {
-		t.Fatal("should now have 2 listeners")
-	}
-
-	RemoveConfigListener(id1)
-	if len(cfgListeners) != numIntitialCfgListeners+1 {
-		t.Fatal("should've removed first listener")
-	}
-
-	RemoveConfigListener(id2)
-	if len(cfgListeners) != numIntitialCfgListeners {
-		t.Fatal("should've removed both listeners")
-	}
-}
-
-func TestConfigListener(t *testing.T) {
-	TranslationsPreInit()
-	LoadGlobalConfig("config.json")
-
-	SiteName := Cfg.TeamSettings.SiteName
-	defer func() {
-		Cfg.TeamSettings.SiteName = SiteName
-		SaveConfig(CfgFileName, Cfg)
-	}()
-	Cfg.TeamSettings.SiteName = "test123"
-
-	listenerCalled := false
-	listener := func(oldConfig *model.Config, newConfig *model.Config) {
-		if listenerCalled {
-			t.Fatal("listener called twice")
-		}
-
-		if oldConfig.TeamSettings.SiteName != "test123" {
-			t.Fatal("old config contains incorrect site name")
-		} else if newConfig.TeamSettings.SiteName != "Mattermost" {
-			t.Fatal("new config contains incorrect site name")
-		}
-
-		listenerCalled = true
-	}
-	listenerId := AddConfigListener(listener)
-	defer RemoveConfigListener(listenerId)
-
-	listener2Called := false
-	listener2 := func(oldConfig *model.Config, newConfig *model.Config) {
-		if listener2Called {
-			t.Fatal("listener2 called twice")
-		}
-
-		listener2Called = true
-	}
-	listener2Id := AddConfigListener(listener2)
-	defer RemoveConfigListener(listener2Id)
-
-	LoadGlobalConfig("config.json")
-
-	if !listenerCalled {
-		t.Fatal("listener should've been called")
-	} else if !listener2Called {
-		t.Fatal("listener 2 should've been called")
-	}
-}
-
 func TestValidateLocales(t *testing.T) {
 	TranslationsPreInit()
-	LoadGlobalConfig("config.json")
+	cfg, _, err := LoadConfig("config.json")
+	require.Nil(t, err)
 
-	defaultServerLocale := *Cfg.LocalizationSettings.DefaultServerLocale
-	defaultClientLocale := *Cfg.LocalizationSettings.DefaultClientLocale
-	availableLocales := *Cfg.LocalizationSettings.AvailableLocales
+	*cfg.LocalizationSettings.DefaultServerLocale = "en"
+	*cfg.LocalizationSettings.DefaultClientLocale = "en"
+	*cfg.LocalizationSettings.AvailableLocales = ""
 
-	defer func() {
-		*Cfg.LocalizationSettings.DefaultClientLocale = defaultClientLocale
-		*Cfg.LocalizationSettings.DefaultServerLocale = defaultServerLocale
-		*Cfg.LocalizationSettings.AvailableLocales = availableLocales
-	}()
-
-	*Cfg.LocalizationSettings.DefaultServerLocale = "en"
-	*Cfg.LocalizationSettings.DefaultClientLocale = "en"
-	*Cfg.LocalizationSettings.AvailableLocales = ""
-
-	// t.Logf("*Cfg.LocalizationSettings.DefaultClientLocale: %+v", *Cfg.LocalizationSettings.DefaultClientLocale)
-	if err := ValidateLocales(Cfg); err != nil {
+	// t.Logf("*cfg.LocalizationSettings.DefaultClientLocale: %+v", *cfg.LocalizationSettings.DefaultClientLocale)
+	if err := ValidateLocales(cfg); err != nil {
 		t.Fatal("Should have not returned an error")
 	}
 
 	// validate DefaultServerLocale
-	*Cfg.LocalizationSettings.DefaultServerLocale = "junk"
-	if err := ValidateLocales(Cfg); err != nil {
-		if *Cfg.LocalizationSettings.DefaultServerLocale != "en" {
-			t.Fatal("DefaultServerLocale should have assigned to en as a default value")
-		}
-	} else {
-
-		t.Fatal("Should have returned an error validating DefaultServerLocale")
-	}
-
-	*Cfg.LocalizationSettings.DefaultServerLocale = ""
-	if err := ValidateLocales(Cfg); err != nil {
-		if *Cfg.LocalizationSettings.DefaultServerLocale != "en" {
+	*cfg.LocalizationSettings.DefaultServerLocale = "junk"
+	if err := ValidateLocales(cfg); err != nil {
+		if *cfg.LocalizationSettings.DefaultServerLocale != "en" {
 			t.Fatal("DefaultServerLocale should have assigned to en as a default value")
 		}
 	} else {
 		t.Fatal("Should have returned an error validating DefaultServerLocale")
 	}
 
-	*Cfg.LocalizationSettings.AvailableLocales = "en"
-	*Cfg.LocalizationSettings.DefaultServerLocale = "de"
-	if err := ValidateLocales(Cfg); err != nil {
-		if strings.Contains(*Cfg.LocalizationSettings.AvailableLocales, *Cfg.LocalizationSettings.DefaultServerLocale) {
+	*cfg.LocalizationSettings.DefaultServerLocale = ""
+	if err := ValidateLocales(cfg); err != nil {
+		if *cfg.LocalizationSettings.DefaultServerLocale != "en" {
+			t.Fatal("DefaultServerLocale should have assigned to en as a default value")
+		}
+	} else {
+		t.Fatal("Should have returned an error validating DefaultServerLocale")
+	}
+
+	*cfg.LocalizationSettings.AvailableLocales = "en"
+	*cfg.LocalizationSettings.DefaultServerLocale = "de"
+	if err := ValidateLocales(cfg); err != nil {
+		if strings.Contains(*cfg.LocalizationSettings.AvailableLocales, *cfg.LocalizationSettings.DefaultServerLocale) {
 			t.Fatal("DefaultServerLocale should not be added to AvailableLocales")
 		}
 		t.Fatal("Should have not returned an error validating DefaultServerLocale")
 	}
 
 	// validate DefaultClientLocale
-	*Cfg.LocalizationSettings.AvailableLocales = ""
-	*Cfg.LocalizationSettings.DefaultClientLocale = "junk"
-	if err := ValidateLocales(Cfg); err != nil {
-		if *Cfg.LocalizationSettings.DefaultClientLocale != "en" {
+	*cfg.LocalizationSettings.AvailableLocales = ""
+	*cfg.LocalizationSettings.DefaultClientLocale = "junk"
+	if err := ValidateLocales(cfg); err != nil {
+		if *cfg.LocalizationSettings.DefaultClientLocale != "en" {
 			t.Fatal("DefaultClientLocale should have assigned to en as a default value")
 		}
 	} else {
@@ -240,19 +137,19 @@ func TestValidateLocales(t *testing.T) {
 		t.Fatal("Should have returned an error validating DefaultClientLocale")
 	}
 
-	*Cfg.LocalizationSettings.DefaultClientLocale = ""
-	if err := ValidateLocales(Cfg); err != nil {
-		if *Cfg.LocalizationSettings.DefaultClientLocale != "en" {
+	*cfg.LocalizationSettings.DefaultClientLocale = ""
+	if err := ValidateLocales(cfg); err != nil {
+		if *cfg.LocalizationSettings.DefaultClientLocale != "en" {
 			t.Fatal("DefaultClientLocale should have assigned to en as a default value")
 		}
 	} else {
 		t.Fatal("Should have returned an error validating DefaultClientLocale")
 	}
 
-	*Cfg.LocalizationSettings.AvailableLocales = "en"
-	*Cfg.LocalizationSettings.DefaultClientLocale = "de"
-	if err := ValidateLocales(Cfg); err != nil {
-		if !strings.Contains(*Cfg.LocalizationSettings.AvailableLocales, *Cfg.LocalizationSettings.DefaultClientLocale) {
+	*cfg.LocalizationSettings.AvailableLocales = "en"
+	*cfg.LocalizationSettings.DefaultClientLocale = "de"
+	if err := ValidateLocales(cfg); err != nil {
+		if !strings.Contains(*cfg.LocalizationSettings.AvailableLocales, *cfg.LocalizationSettings.DefaultClientLocale) {
 			t.Fatal("DefaultClientLocale should have added to AvailableLocales")
 		}
 	} else {
@@ -260,34 +157,34 @@ func TestValidateLocales(t *testing.T) {
 	}
 
 	// validate AvailableLocales
-	*Cfg.LocalizationSettings.DefaultServerLocale = "en"
-	*Cfg.LocalizationSettings.DefaultClientLocale = "en"
-	*Cfg.LocalizationSettings.AvailableLocales = "junk"
-	if err := ValidateLocales(Cfg); err != nil {
-		if *Cfg.LocalizationSettings.AvailableLocales != "" {
+	*cfg.LocalizationSettings.DefaultServerLocale = "en"
+	*cfg.LocalizationSettings.DefaultClientLocale = "en"
+	*cfg.LocalizationSettings.AvailableLocales = "junk"
+	if err := ValidateLocales(cfg); err != nil {
+		if *cfg.LocalizationSettings.AvailableLocales != "" {
 			t.Fatal("AvailableLocales should have assigned to empty string as a default value")
 		}
 	} else {
 		t.Fatal("Should have returned an error validating AvailableLocales")
 	}
 
-	*Cfg.LocalizationSettings.AvailableLocales = "en,de,junk"
-	if err := ValidateLocales(Cfg); err != nil {
-		if *Cfg.LocalizationSettings.AvailableLocales != "" {
+	*cfg.LocalizationSettings.AvailableLocales = "en,de,junk"
+	if err := ValidateLocales(cfg); err != nil {
+		if *cfg.LocalizationSettings.AvailableLocales != "" {
 			t.Fatal("AvailableLocales should have assigned to empty string as a default value")
 		}
 	} else {
 		t.Fatal("Should have returned an error validating AvailableLocales")
 	}
 
-	*Cfg.LocalizationSettings.DefaultServerLocale = "fr"
-	*Cfg.LocalizationSettings.DefaultClientLocale = "de"
-	*Cfg.LocalizationSettings.AvailableLocales = "en"
-	if err := ValidateLocales(Cfg); err != nil {
-		if strings.Contains(*Cfg.LocalizationSettings.AvailableLocales, *Cfg.LocalizationSettings.DefaultServerLocale) {
+	*cfg.LocalizationSettings.DefaultServerLocale = "fr"
+	*cfg.LocalizationSettings.DefaultClientLocale = "de"
+	*cfg.LocalizationSettings.AvailableLocales = "en"
+	if err := ValidateLocales(cfg); err != nil {
+		if strings.Contains(*cfg.LocalizationSettings.AvailableLocales, *cfg.LocalizationSettings.DefaultServerLocale) {
 			t.Fatal("DefaultServerLocale should not be added to AvailableLocales")
 		}
-		if !strings.Contains(*Cfg.LocalizationSettings.AvailableLocales, *Cfg.LocalizationSettings.DefaultClientLocale) {
+		if !strings.Contains(*cfg.LocalizationSettings.AvailableLocales, *cfg.LocalizationSettings.DefaultClientLocale) {
 			t.Fatal("DefaultClientLocale should have added to AvailableLocales")
 		}
 	} else {
@@ -297,10 +194,11 @@ func TestValidateLocales(t *testing.T) {
 
 func TestGetClientConfig(t *testing.T) {
 	TranslationsPreInit()
-	LoadGlobalConfig("config.json")
+	cfg, _, err := LoadConfig("config.json")
+	require.Nil(t, err)
 
-	configMap := GenerateClientConfig(Cfg, "")
-	if configMap["EmailNotificationContentsType"] != *Cfg.EmailSettings.EmailNotificationContentsType {
+	configMap := GenerateClientConfig(cfg, "")
+	if configMap["EmailNotificationContentsType"] != *cfg.EmailSettings.EmailNotificationContentsType {
 		t.Fatal("EmailSettings.EmailNotificationContentsType not exposed to client config")
 	}
 }

utils/logger/logger.go

@@ -27,15 +27,6 @@ var debugLog = l4g.Debug
 var infoLog = l4g.Info
 var errorLog = l4g.Error
 
-func init() {
-	// listens for configuration changes that we might need to respond to
-	utils.AddConfigListener(func(oldConfig *model.Config, newConfig *model.Config) {
-		infoLog("Configuration change detected, reloading log settings")
-		initL4g(newConfig.LogSettings)
-	})
-	initL4g(utils.Cfg.LogSettings)
-}
-
 // assumes that ../config.go::configureLog has already been called, and has in turn called l4g.close() to clean up
 // any old filters that we might have previously created
 func initL4g(logSettings model.LogSettings) {

utils/mail_test.go

@@ -6,10 +6,13 @@ package utils
 import (
 	"strings"
 	"testing"
+
+	"github.com/stretchr/testify/require"
 )
 
 func TestMailConnection(t *testing.T) {
-	cfg := LoadGlobalConfig("config.json")
+	cfg, _, err := LoadConfig("config.json")
+	require.Nil(t, err)
 
 	if conn, err := connectToSMTPServer(cfg); err != nil {
 		t.Log(err)
@@ -32,7 +35,8 @@ func TestMailConnection(t *testing.T) {
 }
 
 func TestSendMailUsingConfig(t *testing.T) {
-	cfg := LoadGlobalConfig("config.json")
+	cfg, _, err := LoadConfig("config.json")
+	require.Nil(t, err)
 	T = GetUserTranslations("en")
 
 	var emailTo string = "test@example.com"

utils/redirect_std_log_test.go

@@ -0,0 +1,24 @@
+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
+// See License.txt for license information.
+
+package utils
+
+import (
+	"testing"
+	"time"
+)
+
+func TestRedirectStdLog(t *testing.T) {
+	log := NewRedirectStdLog("test", false)
+
+	log.Println("[DEBUG] this is a message")
+	log.Println("[DEBG] this is a message")
+	log.Println("[WARN] this is a message")
+	log.Println("[ERROR] this is a message")
+	log.Println("[EROR] this is a message")
+	log.Println("[ERR] this is a message")
+	log.Println("[INFO] this is a message")
+	log.Println("this is a message")
+
+	time.Sleep(time.Second * 1)
+}