From 7da85922af668d6c91195bf6c0cca64e4635020e Mon Sep 17 00:00:00 2001 From: Jesse Hallam Date: Fri, 14 Feb 2020 16:45:32 -0400 Subject: [PATCH] fix bin/mmctl detection using printf (#13898) The behaviour of `echo` [varies](https://stackoverflow.com/questions/8467424/echo-newline-in-bash-prints-literal-n) between operating systems. Use `printf` for maximum compatibility. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 40b067a4fb..66375384c5 100644 --- a/Makefile +++ b/Makefile @@ -172,7 +172,7 @@ prepackaged-plugins: ## Populate the prepackaged-plugins directory prepackaged-binaries: ## Populate the prepackaged-binaries to the bin directory # Externally built binaries -ifeq ($(shell test -f bin/mmctl && echo -n yes),yes) +ifeq ($(shell test -f bin/mmctl && printf "yes"),yes) @echo mmctl installed else ifeq ($(PLATFORM),Darwin) @echo Downloading prepackaged binary: https://github.com/mattermost/mmctl/releases/$(MMCTL_REL_TO_DOWNLOAD)