From 7cc26bf659a44886a1981d3f3fe7bbd38f4377a6 Mon Sep 17 00:00:00 2001
From: Martin Kraft <martinkraft@gmail.com>
Date: Thu, 20 Aug 2020 09:01:22 -0400
Subject: [PATCH] MM-27525: Obscure Global Relay's SMTP password. (#15228)

* MM-27525: Obscures the Global Relay SMTP password.

* MM-27525: Desanitize global relay's SMTP password.

* MM-27525: Does not set the fake value if the field is blank.
---
 config/utils.go | 4 ++++
 model/config.go | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/config/utils.go b/config/utils.go
index 78a16d054f..a1a552579d 100644
--- a/config/utils.go
+++ b/config/utils.go
@@ -53,6 +53,10 @@ func desanitize(actual, target *model.Config) {
 	for i := range target.SqlSettings.DataSourceSearchReplicas {
 		target.SqlSettings.DataSourceSearchReplicas[i] = actual.SqlSettings.DataSourceSearchReplicas[i]
 	}
+
+	if *target.MessageExportSettings.GlobalRelaySettings.SmtpPassword == model.FAKE_SETTING {
+		*target.MessageExportSettings.GlobalRelaySettings.SmtpPassword = *actual.MessageExportSettings.GlobalRelaySettings.SmtpPassword
+	}
 }
 
 // fixConfig patches invalid or missing data in the configuration, returning true if changed.
diff --git a/model/config.go b/model/config.go
index 183c639e33..f73c601959 100644
--- a/model/config.go
+++ b/model/config.go
@@ -3487,4 +3487,8 @@ func (o *Config) Sanitize() {
 	for i := range o.SqlSettings.DataSourceSearchReplicas {
 		o.SqlSettings.DataSourceSearchReplicas[i] = FAKE_SETTING
 	}
+
+	if o.MessageExportSettings.GlobalRelaySettings.SmtpPassword != nil && len(*o.MessageExportSettings.GlobalRelaySettings.SmtpPassword) > 0 {
+		*o.MessageExportSettings.GlobalRelaySettings.SmtpPassword = FAKE_SETTING
+	}
 }