[MM-16784] Sync GetUserTeamIds (#11579)

* [MM-16784] Sync GetUserTeamIds

* fix format

* [MM-16784] put error in one line

* [MM-16784] Remove docstring as per CR request

* [MM-16784] Revert "Remove docstring as per CR request"

This reverts commit 8a64d3841b726d1806e2afb18ffd9802b51f3f21.

store/sqlstore/team_store.go

@@ -999,46 +999,42 @@ func (s SqlTeamStore) GetAllForExportAfter(limit int, afterId string) ([]*model.
 	return data, nil
 }
 
-func (s SqlTeamStore) GetUserTeamIds(userId string, allowFromCache bool) store.StoreChannel {
-	return store.Do(func(result *store.StoreResult) {
-		if allowFromCache {
-			if cacheItem, ok := allTeamIdsForUserCache.Get(userId); ok {
-				if s.metrics != nil {
-					s.metrics.IncrementMemCacheHitCounter("All Team Ids for User")
-				}
-				result.Data = cacheItem.([]string)
-				return
+// GetUserTeamIds get the team ids to which the user belongs to
+func (s SqlTeamStore) GetUserTeamIds(userID string, allowFromCache bool) ([]string, *model.AppError) {
+	if allowFromCache {
+		if cacheItem, ok := allTeamIdsForUserCache.Get(userID); ok {
+			if s.metrics != nil {
+				s.metrics.IncrementMemCacheHitCounter("All Team Ids for User")
 			}
+			return cacheItem.([]string), nil
 		}
+	}
 
-		if s.metrics != nil {
-			s.metrics.IncrementMemCacheMissCounter("All Team Ids for User")
-		}
+	if s.metrics != nil {
+		s.metrics.IncrementMemCacheMissCounter("All Team Ids for User")
+	}
 
-		var teamIds []string
-		_, err := s.GetReplica().Select(&teamIds, `
-	SELECT
-		TeamId
-	FROM
-		TeamMembers
-	INNER JOIN
-		Teams ON TeamMembers.TeamId = Teams.Id
-	WHERE
-		TeamMembers.UserId = :UserId
-		AND TeamMembers.DeleteAt = 0
-		AND Teams.DeleteAt = 0`,
-			map[string]interface{}{"UserId": userId})
-		if err != nil {
-			result.Err = model.NewAppError("SqlTeamStore.GetUserTeamIds", "store.sql_team.get_user_team_ids.app_error", nil, "userId="+userId+" "+err.Error(), http.StatusInternalServerError)
-			return
-		}
+	var teamIds []string
+	_, err := s.GetReplica().Select(&teamIds,
+		`SELECT
+			TeamId
+		FROM
+			TeamMembers
+		INNER JOIN
+			Teams ON TeamMembers.TeamId = Teams.Id
+		WHERE
+			TeamMembers.UserId = :UserId
+			AND TeamMembers.DeleteAt = 0
+			AND Teams.DeleteAt = 0`,
+		map[string]interface{}{"UserId": userID})
+	if err != nil {
+		return []string{}, model.NewAppError("SqlTeamStore.GetUserTeamIds", "store.sql_team.get_user_team_ids.app_error", nil, "userID="+userID+" "+err.Error(), http.StatusInternalServerError)
+	}
 
-		result.Data = teamIds
-
-		if allowFromCache {
-			allTeamIdsForUserCache.AddWithExpiresInSecs(userId, teamIds, ALL_TEAM_IDS_FOR_USER_CACHE_SEC)
-		}
-	})
+	if allowFromCache {
+		allTeamIdsForUserCache.AddWithExpiresInSecs(userID, teamIds, ALL_TEAM_IDS_FOR_USER_CACHE_SEC)
+	}
+	return teamIds, nil
 }
 
 func (s SqlTeamStore) GetTeamMembersForExport(userId string) ([]*model.TeamMemberForExport, *model.AppError) {