MM-44863 - update trial details in product menu (#20534)

* MM-44863 - update trial details in product menu

* update the test to reflect the initial returned subscription

Co-authored-by: Pablo Velez Vidal <pablo.velez@mattermost.com>

api4/cloud.go

@@ -57,17 +57,32 @@ func getSubscription(c *Context, w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	if !c.App.SessionHasPermissionTo(*c.AppContext.Session(), model.PermissionSysconsoleReadBilling) {
-		c.SetPermissionError(model.PermissionSysconsoleReadBilling)
-		return
-	}
-
 	subscription, err := c.App.Cloud().GetSubscription(c.AppContext.Session().UserId)
 	if err != nil {
 		c.Err = model.NewAppError("Api4.getSubscription", "api.cloud.request_error", nil, err.Error(), http.StatusInternalServerError)
 		return
 	}
 
+	// if it is an end user, return basic subscription data without sensitive information
+	if !c.App.SessionHasPermissionTo(*c.AppContext.Session(), model.PermissionSysconsoleReadBilling) {
+		subscription = &model.Subscription{
+			ID:          subscription.ID,
+			ProductID:   subscription.ProductID,
+			IsFreeTrial: subscription.IsFreeTrial,
+			TrialEndAt:  subscription.TrialEndAt,
+			CustomerID:  "",
+			AddOns:      []string{},
+			StartAt:     0,
+			EndAt:       0,
+			CreateAt:    0,
+			Seats:       0,
+			Status:      "",
+			DNS:         "",
+			IsPaidTier:  "",
+			LastInvoice: &model.Invoice{},
+		}
+	}
+
 	json, err := json.Marshal(subscription)
 	if err != nil {
 		c.Err = model.NewAppError("Api4.getSubscription", "api.cloud.request_error", nil, err.Error(), http.StatusInternalServerError)