add model.NewX funcs for builtin types (#7692)

* add model.NewX funcs for builtin types

* whoops, forgot to add the new file

api4/user_test.go

@@ -990,12 +990,9 @@ func TestPatchUser(t *testing.T) {
 
 	patch := &model.UserPatch{}
 
-	patch.Nickname = new(string)
-	*patch.Nickname = "Joram Wilander"
-	patch.FirstName = new(string)
-	*patch.FirstName = "Joram"
-	patch.LastName = new(string)
-	*patch.LastName = "Wilander"
+	patch.Nickname = model.NewString("Joram Wilander")
+	patch.FirstName = model.NewString("Joram")
+	patch.LastName = model.NewString("Wilander")
 	patch.Position = new(string)
 	patch.NotifyProps = model.StringMap{}
 	patch.NotifyProps["comment"] = "somethingrandom"
@@ -1023,8 +1020,7 @@ func TestPatchUser(t *testing.T) {
 		t.Fatal("NotifyProps did not update properly")
 	}
 
-	patch.Username = new(string)
-	*patch.Username = th.BasicUser2.Username
+	patch.Username = model.NewString(th.BasicUser2.Username)
 	_, resp = Client.PatchUser(user.Id, patch)
 	CheckBadRequestStatus(t, resp)
 
@@ -1051,8 +1047,7 @@ func TestPatchUser(t *testing.T) {
 	session.IsOAuth = true
 	app.AddSessionToCache(session)
 
-	patch.Email = new(string)
-	*patch.Email = GenerateTestEmail()
+	patch.Email = model.NewString(GenerateTestEmail())
 	_, resp = Client.PatchUser(user.Id, patch)
 	CheckForbiddenStatus(t, resp)