Add minor code review changes.

api4/license.go

@@ -368,16 +368,17 @@ func requestTrueUpReview(c *Context, w http.ResponseWriter, r *http.Request) {
 	}
 
 	// Authentication Features
-	mfaUsed := c.App.Config().ServiceSettings.EnforceMultifactorAuthentication
+	config := c.App.Config()
-	ldapUsed := c.App.Config().LdapSettings.Enable
+	mfaUsed := config.ServiceSettings.EnforceMultifactorAuthentication
-	samlUsed := c.App.Config().SamlSettings.Enable
+	ldapUsed := config.LdapSettings.Enable
-	openIdUsed := c.App.Config().OpenIdSettings.Enable
+	samlUsed := config.SamlSettings.Enable
-	guessAccessAllowed := c.App.Config().GuestAccountsSettings.Enable
+	openIdUsed := config.OpenIdSettings.Enable
+	guessAccessAllowed := config.GuestAccountsSettings.Enable
 
 	authFeatures := map[string]*bool{
 		model.TrueUpReviewAuthFeaturesMfa:        mfaUsed,
-		model.TueUpReviewAuthFeaturesAdLdap:      ldapUsed,
+		model.TrueUpReviewAuthFeaturesADLdap:     ldapUsed,
-		model.TrueUpReviewauthFeaturesSaml:       samlUsed,
+		model.TrueUpReviewAuthFeaturesSaml:       samlUsed,
 		model.TrueUpReviewAuthFeatureOpenId:      openIdUsed,
 		model.TrueUpReviewAuthFeatureGuestAccess: guessAccessAllowed,
 	}

model/license.go

@@ -40,10 +40,10 @@ var (
 )
 
 const (
-	TrueUpReviewTelemetryName          = "true-up-review-sent"
+	TrueUpReviewTelemetryName          = "true_up_review_sent"
 	TrueUpReviewAuthFeaturesMfa        = "multi_factor_authentication"
-	TueUpReviewAuthFeaturesAdLdap      = "ad_ldap_sign_in"
+	TrueUpReviewAuthFeaturesADLdap     = "ad_ldap_sign_in"
-	TrueUpReviewauthFeaturesSaml       = "saml_sign_in"
+	TrueUpReviewAuthFeaturesSaml       = "saml_sign_in"
 	TrueUpReviewAuthFeatureOpenId      = "openid_connect"
 	TrueUpReviewAuthFeatureGuestAccess = "guest_access"
 )

model/true_up_review_profile.go

@@ -7,7 +7,7 @@ type TrueUpReviewProfile struct {
 	ServerId               string              `json:"server_id"`
 	ServerVersion          string              `json:"server_version"`
 	ServerInstallationType string              `json:"server_installation_type"`
-	LicenseId              string              `json:"licnes_id"`
+	LicenseId              string              `json:"license_id"`
 	LicensedSeats          int                 `json:"licensed_seats"`
 	LicensePlan            string              `json:"license_plan"`
 	CustomerName           string              `json:"customer_name"`

services/telemetry/telemetry.go

@@ -82,8 +82,6 @@ const (
 	TrackLicense  = "license"
 	TrackServer   = "server"
 	TrackPlugins  = "plugins"
-
-	TrackTrueUpReview = "true_up_review"
 )
 
 type ServerIface interface {