MM-16465 Only enable NPS plugin by default if diagnostics are enabled (#11279)

model/config.go

@@ -2177,7 +2177,7 @@ type PluginSettings struct {
 	PluginStates      map[string]*PluginState
 }
 
-func (s *PluginSettings) SetDefaults() {
+func (s *PluginSettings) SetDefaults(ls LogSettings) {
 	if s.Enable == nil {
 		s.Enable = NewBool(true)
 	}
@@ -2215,7 +2215,8 @@ func (s *PluginSettings) SetDefaults() {
 	}
 
 	if s.PluginStates["com.mattermost.nps"] == nil {
-		s.PluginStates["com.mattermost.nps"] = &PluginState{Enable: true}
+		// Enable the NPS plugin by default if diagnostics are enabled
+		s.PluginStates["com.mattermost.nps"] = &PluginState{Enable: ls.EnableDiagnostics == nil || *ls.EnableDiagnostics}
 	}
 }
 
@@ -2441,7 +2442,7 @@ func (o *Config) SetDefaults() {
 	o.AnnouncementSettings.SetDefaults()
 	o.ThemeSettings.SetDefaults()
 	o.ClusterSettings.SetDefaults()
-	o.PluginSettings.SetDefaults()
+	o.PluginSettings.SetDefaults(o.LogSettings)
 	o.AnalyticsSettings.SetDefaults()
 	o.ComplianceSettings.SetDefaults()
 	o.LocalizationSettings.SetDefaults()