[MM-58059] Remove PostPriority feature flag (#26929)

server/channels/app/post_persistent_notification_test.go

@@ -4,7 +4,6 @@
 package app
 
 import (
-	"os"
 	"testing"
 
 	"github.com/mattermost/mattermost/server/public/model"
@@ -16,9 +15,6 @@ import (
 
 func TestResolvePersistentNotification(t *testing.T) {
 	t.Run("should not delete when no posts exist", func(t *testing.T) {
-		os.Setenv("MM_FEATUREFLAGS_POSTPRIORITY", "true")
-		defer os.Unsetenv("MM_FEATUREFLAGS_POSTPRIORITY")
-
 		th := SetupWithStoreMock(t)
 		defer th.TearDown()
 
@@ -42,9 +38,6 @@ func TestResolvePersistentNotification(t *testing.T) {
 	})
 
 	t.Run("should delete for mentioned user", func(t *testing.T) {
-		os.Setenv("MM_FEATUREFLAGS_POSTPRIORITY", "true")
-		defer os.Unsetenv("MM_FEATUREFLAGS_POSTPRIORITY")
-
 		th := SetupWithStoreMock(t)
 		defer th.TearDown()
 
@@ -108,9 +101,6 @@ func TestResolvePersistentNotification(t *testing.T) {
 	})
 
 	t.Run("should not delete for non-mentioned user", func(t *testing.T) {
-		os.Setenv("MM_FEATUREFLAGS_POSTPRIORITY", "true")
-		defer os.Unsetenv("MM_FEATUREFLAGS_POSTPRIORITY")
-
 		th := SetupWithStoreMock(t)
 		defer th.TearDown()
 
@@ -159,9 +149,6 @@ func TestResolvePersistentNotification(t *testing.T) {
 
 func TestDeletePersistentNotification(t *testing.T) {
 	t.Run("should not delete when no posts exist", func(t *testing.T) {
-		os.Setenv("MM_FEATUREFLAGS_POSTPRIORITY", "true")
-		defer os.Unsetenv("MM_FEATUREFLAGS_POSTPRIORITY")
-
 		th := SetupWithStoreMock(t)
 		defer th.TearDown()
 
@@ -185,9 +172,6 @@ func TestDeletePersistentNotification(t *testing.T) {
 	})
 
 	t.Run("should delete", func(t *testing.T) {
-		os.Setenv("MM_FEATUREFLAGS_POSTPRIORITY", "true")
-		defer os.Unsetenv("MM_FEATUREFLAGS_POSTPRIORITY")
-
 		th := SetupWithStoreMock(t)
 		defer th.TearDown()
 

server/channels/app/post_test.go

@@ -8,7 +8,6 @@ import (
 	"errors"
 	"fmt"
 	"net/http"
-	"os"
 	"strconv"
 	"sync"
 	"testing"
@@ -2451,9 +2450,6 @@ func TestCountMentionsFromPost(t *testing.T) {
 	})
 
 	t.Run("should count urgent mentions", func(t *testing.T) {
-		os.Setenv("MM_FEATUREFLAGS_POSTPRIORITY", "true")
-		defer os.Unsetenv("MM_FEATUREFLAGS_POSTPRIORITY")
-
 		th := Setup(t).InitBasic()
 		defer th.TearDown()