From 726e157f5e4d7f11dd7933f16a8912da3ab19b14 Mon Sep 17 00:00:00 2001
From: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
Date: Tue, 19 Dec 2023 14:42:38 +0500
Subject: [PATCH] Updating sidebar position in settings modal (#25738)

* Updating sidebar position in settings modal

* Updating sidebar

* Updating css

* Updating commit

* Fixing lint
---
 .../components/settings_sidebar/settings_sidebar.tsx   |  7 -------
 webapp/channels/src/sass/responsive/_mobile.scss       |  4 ----
 webapp/channels/src/sass/routes/_settings.scss         | 10 ----------
 3 files changed, 21 deletions(-)

diff --git a/webapp/channels/src/components/settings_sidebar/settings_sidebar.tsx b/webapp/channels/src/components/settings_sidebar/settings_sidebar.tsx
index b6d7260f4d..e794272a92 100644
--- a/webapp/channels/src/components/settings_sidebar/settings_sidebar.tsx
+++ b/webapp/channels/src/components/settings_sidebar/settings_sidebar.tsx
@@ -7,7 +7,6 @@ import {FormattedMessage} from 'react-intl';
 
 import Constants from 'utils/constants';
 import {isKeyPressed} from 'utils/keyboard';
-import * as UserAgent from 'utils/user_agent';
 import {a11yFocus} from 'utils/utils';
 
 export type Tab = {
@@ -53,12 +52,6 @@ export default class SettingsSidebar extends React.PureComponent<Props> {
         }
     };
 
-    public componentDidMount() {
-        if (UserAgent.isFirefox()) {
-            document.querySelector('.settings-modal .settings-table .nav')?.classList.add('position--top');
-        }
-    }
-
     private renderTab(tab: Tab, index: number) {
         const key = `${tab.name}_li`;
         const isActive = this.props.activeTab === tab.name;
diff --git a/webapp/channels/src/sass/responsive/_mobile.scss b/webapp/channels/src/sass/responsive/_mobile.scss
index 6d8852e504..cc3e852272 100644
--- a/webapp/channels/src/sass/responsive/_mobile.scss
+++ b/webapp/channels/src/sass/responsive/_mobile.scss
@@ -273,10 +273,6 @@
                         width: 100%;
                         margin: 0;
 
-                        &.position--top {
-                            top: auto;
-                        }
-
                         >li {
                             >a {
                                 font-size: 1.1em;
diff --git a/webapp/channels/src/sass/routes/_settings.scss b/webapp/channels/src/sass/routes/_settings.scss
index 5bdd7dc7c4..b44d157b5d 100644
--- a/webapp/channels/src/sass/routes/_settings.scss
+++ b/webapp/channels/src/sass/routes/_settings.scss
@@ -198,16 +198,6 @@
                 vertical-align: top;
             }
 
-            .nav {
-                position: fixed;
-                width: 179px;
-                margin: 0;
-
-                &.position--top {
-                    top: 57px;
-                }
-            }
-
             .security-links {
                 margin-right: 20px;